Re: [edk2-devel] [PATCH] SbsaQemu: EFI implementation for SbsaQemu platform

["Leif Lindholm" <leif.lindholm@linaro.org>]

Hi Phil,

Many thanks for review!

On Wed, Dec 04, 2019 at 23:01:17 +0100, Philippe Mathieu-Daudé wrote:
> > diff --git a/Platform/Qemu/SbsaQemu/Readme.md b/Platform/Qemu/SbsaQemu/Readme.md
> > new file mode 100644
> > index 0000000000..34d483f028
> > --- /dev/null
> > +++ b/Platform/Qemu/SbsaQemu/Readme.md
> > @@ -0,0 +1,156 @@
> > +# Overview
> > +
> > +This directory holds UEFI implementation for Sbsa-ref machine which is faithful
> > +as possible to real hardware. In opposition to existing Qemu Virt machine which
> > +is suited for performing workloads, the purpose of this machine is development
> > +of firmware and OS for AARCH64 server alike platforms (like in situation where
> > +real HW is not available yet or the debugging is easier to control under
> > +emulation). The SBSAQemu name, was chosen because the modeled HW is aimed to
> > +follow way that server-style armv8 machines are recommended to be set up.
> > +Implementation does not use fw-cfg nor DT provided by Qemu.
> 
> "fw_cfg", "QEMU".
> 
> > +
> > +# How to build (Linux Environment)
> > +
> > +## Prerequisites
> > +
> > +Build process for sbsa-ref uses fdf file for flash image composition. This is
> 
> "SBSA-ref"? "FDF"

Capitalisation ftw...
Well, the machine name in QEMU is 'sbsa-ref'.

I would argue sticking with the QEMU capitalisation rather than
retro-applying the capitalisation of the specification on which the
QEMU machine is based is preferable for this document - reserving
upper-case SBSA for talking about the specification itself.

Now, I'm a linguo-anarchist to the point where I would just ignore the
"sentences begin with a capital letter" rule as well in some instances
below. But I think Sbsa-ref is preferable to SBSA-ref.

Best Regards,

Leif