From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web11.7570.1575544040326026987 for ; Thu, 05 Dec 2019 03:07:20 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=B8a0NyN3; spf=pass (domain: linaro.org, ip: 209.85.128.65, mailfrom: leif.lindholm@linaro.org) Received: by mail-wm1-f65.google.com with SMTP id n9so2680367wmd.3 for ; Thu, 05 Dec 2019 03:07:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=c76kJv67tYyIukVgZi9Es9/OlxXpk0iQY8oTq1DHCmA=; b=B8a0NyN3WIJuUYRewlrBTZQmpssUKipUflYcrJYCp0M3+PpybIpPX7ChQP3DswNm6N kaRA7OUwVK6Tx8SJ0gQLkZvfz/P6sSol2vccLydcWXGq9H8WNrGQu01Ci4D74QbAz7BB tSyRTIRJKao06kmO8Ev6unofPjGRP6kkw9m1j6jSg2yHv1K7U6Etp7aLx+/LgEhXwCUw 5NkZ9iWB3V0k0mh41+PGBU3Zv5qRMEluKRouQX8Xv4OBGcblYmW3I17aDBtSrYAbAaa+ HXcXABKM7vkjxr84lfjzm7bAxGJXuvyDPNaHz5tPVn5Enq1bhDZQM+s8RZGtqUOSHEAO xHMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=c76kJv67tYyIukVgZi9Es9/OlxXpk0iQY8oTq1DHCmA=; b=on14luYXjm6qBWmbj8wVKbN0UNtR6obKW1vvMLicnoLctHDwf+HA80Zf13hxaSUiIG UDconJc5Ng3MeNEmcBijyB6QfkjJnYLxfebs6H/NVTSmcl7fPwZfKN4WmYqIUHCnHoEr Ct+MGULEvwSwShvGWoWKKXZFCdoNVGm+i1D9osVr5Ov/bcKgN+z9JMDPw7FOx4mxW404 9O1RKC/Y+HnI+O69YmGBNcoUG0WF7MrF/tvFFxf0JdrAblFSgiU5W/tkRnwjLYh+H0F+ 6nEe1/n5byiK0er4GN/p2g7imy2C4li7rC7O9JqX5VnlissAowysguuxCZ6EhO/WLKro W8gQ== X-Gm-Message-State: APjAAAVZPgqMEcfplkt1KDWbi7wXp9vrMdnTHecRSdcTGLBj/IR0n7bn mkw6Pu0E+ZvPSkM63YJYV+IoZw== X-Google-Smtp-Source: APXvYqxf1ByoITZnKEFMjCcLRsjeFTgcBHyw7YjxWundXpL/czeHgMiBLr2Gv2Po7jdW4pTbS87vdQ== X-Received: by 2002:a05:600c:230d:: with SMTP id 13mr4547279wmo.12.1575544038729; Thu, 05 Dec 2019 03:07:18 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a186sm9932802wmd.41.2019.12.05.03.07.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Dec 2019 03:07:17 -0800 (PST) Date: Thu, 5 Dec 2019 11:07:16 +0000 From: "Leif Lindholm" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: devel@edk2.groups.io, tanmay.jagdale@linaro.org, ard.biesheuvel@linaro.org, Radoslaw Biernacki Subject: Re: [edk2-devel] [PATCH] SbsaQemu: EFI implementation for SbsaQemu platform Message-ID: <20191205110716.GP7359@bivouac.eciton.net> References: <20191204170455.26141-1-tanmay.jagdale@linaro.org> <13ac9052-6a12-c1be-fdf2-b583b5772a8d@redhat.com> MIME-Version: 1.0 In-Reply-To: <13ac9052-6a12-c1be-fdf2-b583b5772a8d@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Hi Phil, Many thanks for review! On Wed, Dec 04, 2019 at 23:01:17 +0100, Philippe Mathieu-Daudé wrote: > > diff --git a/Platform/Qemu/SbsaQemu/Readme.md b/Platform/Qemu/SbsaQemu/Readme.md > > new file mode 100644 > > index 0000000000..34d483f028 > > --- /dev/null > > +++ b/Platform/Qemu/SbsaQemu/Readme.md > > @@ -0,0 +1,156 @@ > > +# Overview > > + > > +This directory holds UEFI implementation for Sbsa-ref machine which is faithful > > +as possible to real hardware. In opposition to existing Qemu Virt machine which > > +is suited for performing workloads, the purpose of this machine is development > > +of firmware and OS for AARCH64 server alike platforms (like in situation where > > +real HW is not available yet or the debugging is easier to control under > > +emulation). The SBSAQemu name, was chosen because the modeled HW is aimed to > > +follow way that server-style armv8 machines are recommended to be set up. > > +Implementation does not use fw-cfg nor DT provided by Qemu. > > "fw_cfg", "QEMU". > > > + > > +# How to build (Linux Environment) > > + > > +## Prerequisites > > + > > +Build process for sbsa-ref uses fdf file for flash image composition. This is > > "SBSA-ref"? "FDF" Capitalisation ftw... Well, the machine name in QEMU is 'sbsa-ref'. I would argue sticking with the QEMU capitalisation rather than retro-applying the capitalisation of the specification on which the QEMU machine is based is preferable for this document - reserving upper-case SBSA for talking about the specification itself. Now, I'm a linguo-anarchist to the point where I would just ignore the "sentences begin with a capital letter" rule as well in some instances below. But I think Sbsa-ref is preferable to SBSA-ref. Best Regards, Leif