From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web12.2112.1575630139097717363 for ; Fri, 06 Dec 2019 03:02:19 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=Wf2UKbiw; spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wm1-f67.google.com with SMTP id p9so7385346wmg.0 for ; Fri, 06 Dec 2019 03:02:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=kuhHCf+JWxImdpDAZIN8I9X+E06B4aTs2dz96AkWZ6Y=; b=Wf2UKbiw0ZtqrA4PnQNxkeXfFAbmyFJlPjk2WoWv69G8518Iqd/3IOdNhT5Tz2zOT1 DFdjO14V0Y9GX08ikzeIS1AOsxz3dYXpSrRbJanz0mzUEzMOG7qdiJ5zIQFSpsJz2nnE U7klYtn1u+k0+pqlW5J6S1CZLmZiqeeeE+BA9EMBVHbZbv5ONgkOnKpr2YvOjfr7VRP0 kd6N3O/LIOVEIRdCsMeVYHBP5BQUTWdowMoSEVOO6/bFeFfdK2bbEnCir8m3kZ9GG/k3 jU4cCwCJWZ7ViPvGZ6zAdl0gBhskw6PLSm7LnnQPSZKIQeKcMX8UbyFpTKAz0yIQKZnl zbag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=kuhHCf+JWxImdpDAZIN8I9X+E06B4aTs2dz96AkWZ6Y=; b=pnCKa/6srXbDMh9EYWer5FuWPwOInnFqVTDc/5WPozlIlmZ9jCdKl3HaA+oYth+QHi hMx1RLwxWVOoN93tPz2RUxL5fESYvu37SJ2faK5qPR+mCJyXL/1cwh4MneJPJmMtKVZ/ OvLWtTqM3XmyPHUF3rtO2rBxZhk+Tz9maIE4lTmn2GUTbFAHjsLwht58Ew5tf1N1qGMD bOWtGGFKAoiLE3KQ9MeInhnO7XUZ3Z12QI0Ed9Cq+5hyi5RNpsbT9SIuYZNo50O34YZs Pa0a/xt8EYn1PKMJPCK6SGnnfedxHyBOw9VC83GSrZk3xhZnXDoJIXd9CN8M/7HcOHhr ZqrA== X-Gm-Message-State: APjAAAUu+X91KmzdJ4xnnVXoEzRhdegjwxEKsN7C2tDxHnr/vbjE3Gz+ lo90rzeDTZMG00yIZJCh94Fae93ykTC9TA== X-Google-Smtp-Source: APXvYqzlqcXFozGIznmkg64qioxo6dQXth/B8zUdUClceq5//nyAANdqLHI8iw3z+fVATV5zDZq8gw== X-Received: by 2002:a1c:1dd3:: with SMTP id d202mr10091013wmd.130.1575630136818; Fri, 06 Dec 2019 03:02:16 -0800 (PST) Return-Path: Received: from e123331-lin.cambridge.arm.com (fw-tnat-cam5.arm.com. [217.140.106.53]) by smtp.gmail.com with ESMTPSA id g2sm303001wrw.76.2019.12.06.03.02.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Dec 2019 03:02:16 -0800 (PST) From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Sami Mujawar , Laszlo Ersek , Leif Lindholm Subject: [PATCH edk2-platforms 0/2] Platform/ARM/Juno: remove explicit PCIe enumeration Date: Fri, 6 Dec 2019 11:02:17 +0000 Message-Id: <20191206110219.32190-1-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.1 The platform DXE driver of the Juno platform enumerates the PCIe explicitly by calling ConnectController on the PCIe root bridge, in order to ensure that all PCI I/O protocols have been instantiated when we try to locate the one describing the Marvel Yukon NIC, so that we can program its MAC address. Taking control of core firmware behavior like this has already caused confusion when reasoning about why and when PCIe option ROMs get dispatched, and is likely to cause more confusion down the road. So let's fix this, by triggering the MAC programming via a protocol notify on the PCI I/O protocol. This has been build tested only at the moment. Cc: Sami Mujawar Cc: Laszlo Ersek Cc: Leif Lindholm Ard Biesheuvel (2): Platform/ARM/ArmJunoDxe: make mAcpiRegistration STATIC Platform/ARM/ArmJunoDxe: use PciIo protocol notify to program the MAC .../JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 163 ++++-------------- .../JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf | 1 - 2 files changed, 31 insertions(+), 133 deletions(-) -- 2.17.1