From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web10.2145.1575630139973117739 for ; Fri, 06 Dec 2019 03:02:20 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=XZ03J4Wm; spf=pass (domain: linaro.org, ip: 209.85.128.65, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wm1-f65.google.com with SMTP id p17so6911297wmi.3 for ; Fri, 06 Dec 2019 03:02:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xpg2RtVjs7ue20myVVigN/6AT74zpHebNPiYdqJHd1U=; b=XZ03J4WmS893Hbt9ZcYjhCmMVqf3IGR2dI3qM9smzV9O88rYSTlG53SdGXm5I0L5oy NRsvcWYU6ONHqGMx/NTXHfqR55m73VKxhVXwQwQacIbjrKBhSn4bdYU4GtjSPhlpf6Is KSmKfD/yCtkCwc/bEV2sQAGoQc0Ab7yuRpAbe+TkznU78/lpT+NjrviRKMOQ+h/jBX4l xDu6LD+kaeaD2ec/pi2qQ6khfJMvatlblL7ysvkT+Q6gLPg4Et/amhoy581JZpPeyKHR BnEcE80V7ygxN5FcGALeGmNwBKzwFfb62WPhe3c4miHEqTSTraYHiKseJvdRQJ8Wtyyi 2hPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xpg2RtVjs7ue20myVVigN/6AT74zpHebNPiYdqJHd1U=; b=nrookQUteicXvTjZW+cyqib/Zh92/jZQySpzHt/2YhsesxnZrrk+Vu3Xrb75+6uwXf 2td9sWVrciBgGtNLCDXB46f6S72KUAleKv1YIaVKfFKkFEwurJVHwS7evYnxJNWG3Y0W YQNRcK+p7CU/adGproLPxNRi9bwlJWTnhgDU1j1cTYTjtBTrw9LXV1E/bnkNze2/4Saq V6HW6sREdz76IF3BiSonnXOV9v+ISjaQjmB18plwJim2AzjBF0YRgeHahFzBjnXUzL17 Zv40AwYPsQp920I3JP2+DHUFM2ykmGGIyEeRm75Qt5ULt554x3UmftWMPCUytAkiIfZ1 G7tQ== X-Gm-Message-State: APjAAAWO1tVNikhbq8rVJ1hCQUO0jkF4n4M7qiS7OC9344jUR2gIjV01 tXEELg4zOditj/ABT/v503TFDwltetfBQg== X-Google-Smtp-Source: APXvYqy9LqaPBTqSRxgRJS5SlHAPjlrhrjKAbvccJEVZpkSR6zSKO9cXe5fGxLqMWBWpD1wjcbCf2Q== X-Received: by 2002:a1c:6207:: with SMTP id w7mr10349542wmb.16.1575630137717; Fri, 06 Dec 2019 03:02:17 -0800 (PST) Return-Path: Received: from e123331-lin.cambridge.arm.com (fw-tnat-cam5.arm.com. [217.140.106.53]) by smtp.gmail.com with ESMTPSA id g2sm303001wrw.76.2019.12.06.03.02.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Dec 2019 03:02:16 -0800 (PST) From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Sami Mujawar , Laszlo Ersek , Leif Lindholm Subject: [PATCH edk2-platforms 1/2] Platform/ARM/ArmJunoDxe: make mAcpiRegistration STATIC Date: Fri, 6 Dec 2019 11:02:18 +0000 Message-Id: <20191206110219.32190-2-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191206110219.32190-1-ard.biesheuvel@linaro.org> References: <20191206110219.32190-1-ard.biesheuvel@linaro.org> Generally, variables should only have external linkage if needed, so make mAcpiRegistration STATIC, given that static linkage suffices for it. Signed-off-by: Ard Biesheuvel --- Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c index ea7591d70443..c0ad7ced2959 100644 --- a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c +++ b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c @@ -64,7 +64,7 @@ STATIC CONST EFI_PCI_ROOT_BRIDGE_DEVICE_PATH mPciRootComplexDevicePath = { } }; -EFI_EVENT mAcpiRegistration = NULL; +STATIC EFI_EVENT mAcpiRegistration = NULL; /** This function reads PCI ID of the controller. -- 2.17.1