From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web12.2186.1575630770640663657 for ; Fri, 06 Dec 2019 03:12:50 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=NuAKbsrV; spf=pass (domain: linaro.org, ip: 209.85.128.65, mailfrom: leif.lindholm@linaro.org) Received: by mail-wm1-f65.google.com with SMTP id q9so7390414wmj.5 for ; Fri, 06 Dec 2019 03:12:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WJt/NKV0SvTWm9rsefBS6BwHM8oXj1RXRj2c0k2Z3ts=; b=NuAKbsrVSKI+4fh7kqWJ/wVCIwNY+HtIj6h1ItqIQKKUnHFkykjoi2jDFytmK08KH6 teYEcJV9E88q4kM5O5FUelJHMPxyk/fd+O3m5t/7ov9t2jnmj6zIxJfEz4VQTM360KCf Ncct/ha1i4HLKvAynP0ER7d3lPJVdBUcRMNUidhrvxR3QZ/z8Yzcv5Zo66fckhWEJ3vS IVdviPKSux76sPsg6N7/c1uip7jI0WS0Kvh4cwtJewOtnbg/xCIzqTTU7Me+ApGWFyO0 y/DTYW1vHjkKDZI1Zc2XGfKWtis3omNXVGfGyi13oyRvmGCIrgpQipALuP6i3FWtiNcn qFHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=WJt/NKV0SvTWm9rsefBS6BwHM8oXj1RXRj2c0k2Z3ts=; b=CYYvFSAU6CDZQCC9QstuwqDYSmIFJryLqJPEgOvn3lTgK/EiY/bUls5c4Ei3gUlgTs XC8QQ0NYYIvW9Bl/Zam/L6S9Dx1ZQnXLjbkJBwdttzkjIC8VRFjtc1a2JgICdyPH7YzB GLFcdyytfcz4LatXLu+LCfLqa94pSiPvb1ob2hnsFl9iTslm2z9hDc1hAHKxsyWS9kSB 8MMUH0YDGwcZtuIx7iTjy2hW+9REKNC4VQnzM2ScyzCXP4zv/PzQ3AO7x4uc7cmS3Owt RnGolfvETtAv/HDQBoRIC/J8CmD2OjcdTzCjvb+O6/rzrlhzd/+pRVP9kBloBMFnYZXW SClQ== X-Gm-Message-State: APjAAAUOrJK0vzYbt3UFCq6ULShYmxwI4wDN9EZR/JLSyteoW/jmgUbq GX9l52oB717iLiHOzaFLND0Wfw== X-Google-Smtp-Source: APXvYqytPy5LrG7kSOB40XAuY2phXsjU74xiBFeppNsNxypFP8CF5/VFUPTZmLbys0VX07JLVKLidw== X-Received: by 2002:a1c:f003:: with SMTP id a3mr9423971wmb.41.1575630769132; Fri, 06 Dec 2019 03:12:49 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id n10sm15601870wrt.14.2019.12.06.03.12.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Dec 2019 03:12:48 -0800 (PST) Date: Fri, 6 Dec 2019 11:12:46 +0000 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io, Sami Mujawar , Laszlo Ersek Subject: Re: [PATCH edk2-platforms 0/2] Platform/ARM/Juno: remove explicit PCIe enumeration Message-ID: <20191206111246.GR7359@bivouac.eciton.net> References: <20191206110219.32190-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20191206110219.32190-1-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 06, 2019 at 11:02:17 +0000, Ard Biesheuvel wrote: > The platform DXE driver of the Juno platform enumerates the PCIe explicitly > by calling ConnectController on the PCIe root bridge, in order to ensure > that all PCI I/O protocols have been instantiated when we try to locate the > one describing the Marvel Yukon NIC, so that we can program its MAC address. > > Taking control of core firmware behavior like this has already caused > confusion when reasoning about why and when PCIe option ROMs get dispatched, > and is likely to cause more confusion down the road. > > So let's fix this, by triggering the MAC programming via a protocol notify > on the PCI I/O protocol. > > This has been build tested only at the moment. > > Cc: Sami Mujawar > Cc: Laszlo Ersek > Cc: Leif Lindholm This looks sensible to me (and way more can-of-wormish than I would have expected) - so: Acked-by: Leif Lindholm *but* we need tested-by from somewhere before merging 2/2. 1/2 could go in whenever. / Leif > Ard Biesheuvel (2): > Platform/ARM/ArmJunoDxe: make mAcpiRegistration STATIC > Platform/ARM/ArmJunoDxe: use PciIo protocol notify to program the MAC > > .../JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 163 ++++-------------- > .../JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf | 1 - > 2 files changed, 31 insertions(+), 133 deletions(-) > > -- > 2.17.1 >