From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: devel@edk2.groups.io
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Leif Lindholm <leif.lindholm@linaro.org>,
Laszlo Ersek <lersek@redhat.com>,
Zhichao Gao <zhichao.gao@intel.com>, Ray Ni <ray.ni@intel.com>,
Maurice Ma <maurice.ma@intel.com>, Guo Dong <guo.dong@intel.com>,
Benjamin You <benjamin.you@intel.com>
Subject: [RFC PATCH 1/2] MdeModulePkg/PlatformBootManagerLib: document change of Driver#### handling
Date: Fri, 6 Dec 2019 15:31:27 +0100 [thread overview]
Message-ID: <20191206143128.19371-2-ard.biesheuvel@linaro.org> (raw)
In-Reply-To: <20191206143128.19371-1-ard.biesheuvel@linaro.org>
A future patch will change the order in which Driver#### options are
processed, removing the possibility to create such options in
PlatformBootManagerBeforeConsole(). Update the code comments duplicated
across the tree to reflect this upcoming change, and replace Driver####
with SysPrep####, which can be used for the same purpose instead.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 2 +-
ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 2 +-
MdeModulePkg/Include/Library/PlatformBootManagerLib.h | 2 +-
MdeModulePkg/Library/PlatformBootManagerLibNull/PlatformBootManager.c | 2 +-
MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 2 +-
OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 2 +-
UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c | 2 +-
7 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
index e6e788e0f107..d436eacd3494 100644
--- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
+++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
@@ -532,7 +532,7 @@ PlatformRegisterOptionsAndKeys (
Possible things that can be done in PlatformBootManagerBeforeConsole:
> Update console variable: 1. include hot-plug devices;
> 2. Clear ConIn and add SOL for AMT
- > Register new Driver#### or Boot####
+ > Register new SysPrep#### or Boot####
> Register new Key####: e.g.: F12
> Signal ReadyToLock event
> Authentication action: 1. connect Auth devices;
diff --git a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
index 5f6cfe64daca..2df874a0dedd 100644
--- a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
+++ b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
@@ -674,7 +674,7 @@ PlatformRegisterOptionsAndKeys (
Possible things that can be done in PlatformBootManagerBeforeConsole:
> Update console variable: 1. include hot-plug devices;
> 2. Clear ConIn and add SOL for AMT
- > Register new Driver#### or Boot####
+ > Register new SysPrep#### or Boot####
> Register new Key####: e.g.: F12
> Signal ReadyToLock event
> Authentication action: 1. connect Auth devices;
diff --git a/MdeModulePkg/Include/Library/PlatformBootManagerLib.h b/MdeModulePkg/Include/Library/PlatformBootManagerLib.h
index 5d3062e9ddea..0b296b55bcab 100644
--- a/MdeModulePkg/Include/Library/PlatformBootManagerLib.h
+++ b/MdeModulePkg/Include/Library/PlatformBootManagerLib.h
@@ -17,7 +17,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
Such as:
Update console variable;
- Register new Driver#### or Boot####;
+ Register new SysPrep#### or Boot####;
Signal ReadyToLock event.
**/
VOID
diff --git a/MdeModulePkg/Library/PlatformBootManagerLibNull/PlatformBootManager.c b/MdeModulePkg/Library/PlatformBootManagerLibNull/PlatformBootManager.c
index 43560bf2aa6c..45cf81c1226b 100644
--- a/MdeModulePkg/Library/PlatformBootManagerLibNull/PlatformBootManager.c
+++ b/MdeModulePkg/Library/PlatformBootManagerLibNull/PlatformBootManager.c
@@ -15,7 +15,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
Such as:
Update console variable;
- Register new Driver#### or Boot####;
+ Register new SysPrep#### or Boot####;
Signal ReadyToLock event.
**/
VOID
diff --git a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c b/MdeModulePkg/Universal/BdsDxe/BdsEntry.c
index d387dbe7ac12..1fb04dcbbcda 100644
--- a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c
+++ b/MdeModulePkg/Universal/BdsDxe/BdsEntry.c
@@ -854,7 +854,7 @@ BdsEntry (
// Do the platform init, can be customized by OEM/IBV
// Possible things that can be done in PlatformBootManagerBeforeConsole:
// > Update console variable: 1. include hot-plug devices; 2. Clear ConIn and add SOL for AMT
- // > Register new Driver#### or Boot####
+ // > Register new SysPrep#### or Boot####
// > Register new Key####: e.g.: F12
// > Signal ReadyToLock event
// > Authentication action: 1. connect Auth devices; 2. Identify auto logon user.
diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
index 8af9b71f18a3..b7dc9a1fefdc 100644
--- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
+++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
@@ -339,7 +339,7 @@ SaveS3BootScript (
> Update console variable: 1. include hot-plug devices;
> 2. Clear ConIn and add SOL for AMT
- > Register new Driver#### or Boot####
+ > Register new SysPrep#### or Boot####
> Register new Key####: e.g.: F12
> Signal ReadyToLock event
> Authentication action: 1. connect Auth devices;
diff --git a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
index c5c6af0abcb2..2833d2b03019 100644
--- a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
+++ b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
@@ -143,7 +143,7 @@ PlatformRegisterFvBootOption (
Such as:
Update console variable;
- Register new Driver#### or Boot####;
+ Register new SysPrep#### or Boot####;
Signal ReadyToLock event.
**/
VOID
--
2.17.1
next prev parent reply other threads:[~2019-12-06 14:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 14:31 [RFC PATCH 0/2] MdeModulePkg: reorder Driver#### handling for console drivers Ard Biesheuvel
2019-12-06 14:31 ` Ard Biesheuvel [this message]
2019-12-06 14:31 ` [RFC PATCH 2/2] MdeModulePkg/BdsDxe: allow consoles on drivers loaded via Driver#### Ard Biesheuvel
2019-12-06 15:43 ` Laszlo Ersek
2019-12-06 15:50 ` Ard Biesheuvel
2019-12-09 2:12 ` Ni, Ray
2019-12-09 8:42 ` Ard Biesheuvel
2019-12-11 10:40 ` Ard Biesheuvel
2019-12-12 8:59 ` [edk2-devel] " Ni, Ray
2019-12-12 9:05 ` Ard Biesheuvel
2019-12-23 14:09 ` Ard Biesheuvel
2020-01-09 12:54 ` Ard Biesheuvel
2020-01-10 1:19 ` Ni, Ray
2020-01-10 14:37 ` Ni, Ray
2020-01-10 16:23 ` Laszlo Ersek
2020-01-13 17:28 ` Ard Biesheuvel
2020-01-13 17:57 ` Andrew Fish
2020-01-14 16:46 ` Ard Biesheuvel
2020-01-14 17:45 ` Andrew Fish
2020-01-15 3:12 ` Ni, Ray
2020-01-15 3:14 ` Ni, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191206143128.19371-2-ard.biesheuvel@linaro.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox