From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mx.groups.io with SMTP id smtpd.web11.4443.1575642696799395415 for ; Fri, 06 Dec 2019 06:31:37 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=GQXB5I9u; spf=pass (domain: linaro.org, ip: 209.85.128.49, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wm1-f49.google.com with SMTP id f129so7555067wmf.2 for ; Fri, 06 Dec 2019 06:31:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=phrydUCEKxQ3/a4hKmoNPLbak0p6XxWFp5U0TmpuyPk=; b=GQXB5I9uGjNL5f3CEmYsQEehyyFY1XQhdNviL8eSWS+ae/6cYpzaVK6gkIFrJgXlUD cJtT14/gK3tfy/cKvLJt4AIC1fomonyPBbb/zqNsybUCteeoqMcsAdyQKOwO3KJxZSLP 7WOGTT900ifkrLvOVN1BVBW7fozVQ8hpdroRgpoyo5uWwQSxCj92vEVY98CYfigTdaXL BBtFWJb2yP9/zD11cB/DlT7dfOrHGrMYj0jJe/e4jL2PgssIGrifAEjP+STsNTvAdrh8 88OHuUXR22NU3Nu/BWbQ/DAAjpu2O2IK06LtBFbIqcNmNUD5mpRYo+rV1uhJgkGQctiw kr9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=phrydUCEKxQ3/a4hKmoNPLbak0p6XxWFp5U0TmpuyPk=; b=irA9V1LRmXEXGeyKF1zT3CCy00JYcri1kWaIRl5vTMaII3cC0z2tHvbhZxffB2LE/0 Zw+5aHZzo7U+l8d8JoxU6CHU6jkIHbdUL1Wd7QWnXdwdeCGjHh97LZdgAT0MxDb5wVBJ jSW2HBw9LmgXmBZQThw5pZ0zeCCzPC65ZynAUv5hRDlmeGYct57+whwyOxU+63RYeghk 0VCmj8JcsV02Wy53TozgljQkPNlDdJj0LAhBXYL+JFY6HNjIDRc+Yh9GnfIihx8nlZ/R AsTEx4umus1VgNHg2zud4KeG4/JF0TUEDeHgEFOC/yJhyi0xHDdwO8zQ2xG5SQaRPHaf SHTg== X-Gm-Message-State: APjAAAXPkmdLeXONBYvB17hPj14ORn60bwUeu8Yvn5Lf4WETqoWgRBWA VyWTyct7S6FpynppeDKQ9apllnqsaon6Nmdh X-Google-Smtp-Source: APXvYqz3NwoEtnAPDiTXQx+IDBGpB5mzrai4hSUl/9t7Rn0cqyaH2OB6wn3xcPwcA5/imQhI04UxoA== X-Received: by 2002:a1c:7e13:: with SMTP id z19mr1698148wmc.67.1575642694968; Fri, 06 Dec 2019 06:31:34 -0800 (PST) Return-Path: Received: from sudo.home ([2a01:cb1d:112:6f00:488a:43c8:1cd8:def8]) by smtp.gmail.com with ESMTPSA id b63sm3281032wmb.40.2019.12.06.06.31.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Dec 2019 06:31:34 -0800 (PST) From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Laszlo Ersek , Zhichao Gao , Ray Ni , Maurice Ma , Guo Dong , Benjamin You Subject: [RFC PATCH 1/2] MdeModulePkg/PlatformBootManagerLib: document change of Driver#### handling Date: Fri, 6 Dec 2019 15:31:27 +0100 Message-Id: <20191206143128.19371-2-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191206143128.19371-1-ard.biesheuvel@linaro.org> References: <20191206143128.19371-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A future patch will change the order in which Driver#### options are processed, removing the possibility to create such options in PlatformBootManagerBeforeConsole(). Update the code comments duplicated across the tree to reflect this upcoming change, and replace Driver#### with SysPrep####, which can be used for the same purpose instead. Signed-off-by: Ard Biesheuvel --- ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 2 +- ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 2 +- MdeModulePkg/Include/Library/PlatformBootManagerLib.h | 2 +- MdeModulePkg/Library/PlatformBootManagerLibNull/PlatformBootManager.c | 2 +- MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 2 +- OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 2 +- UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c index e6e788e0f107..d436eacd3494 100644 --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c @@ -532,7 +532,7 @@ PlatformRegisterOptionsAndKeys ( Possible things that can be done in PlatformBootManagerBeforeConsole: > Update console variable: 1. include hot-plug devices; > 2. Clear ConIn and add SOL for AMT - > Register new Driver#### or Boot#### + > Register new SysPrep#### or Boot#### > Register new Key####: e.g.: F12 > Signal ReadyToLock event > Authentication action: 1. connect Auth devices; diff --git a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c index 5f6cfe64daca..2df874a0dedd 100644 --- a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c +++ b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c @@ -674,7 +674,7 @@ PlatformRegisterOptionsAndKeys ( Possible things that can be done in PlatformBootManagerBeforeConsole: > Update console variable: 1. include hot-plug devices; > 2. Clear ConIn and add SOL for AMT - > Register new Driver#### or Boot#### + > Register new SysPrep#### or Boot#### > Register new Key####: e.g.: F12 > Signal ReadyToLock event > Authentication action: 1. connect Auth devices; diff --git a/MdeModulePkg/Include/Library/PlatformBootManagerLib.h b/MdeModulePkg/Include/Library/PlatformBootManagerLib.h index 5d3062e9ddea..0b296b55bcab 100644 --- a/MdeModulePkg/Include/Library/PlatformBootManagerLib.h +++ b/MdeModulePkg/Include/Library/PlatformBootManagerLib.h @@ -17,7 +17,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent Such as: Update console variable; - Register new Driver#### or Boot####; + Register new SysPrep#### or Boot####; Signal ReadyToLock event. **/ VOID diff --git a/MdeModulePkg/Library/PlatformBootManagerLibNull/PlatformBootManager.c b/MdeModulePkg/Library/PlatformBootManagerLibNull/PlatformBootManager.c index 43560bf2aa6c..45cf81c1226b 100644 --- a/MdeModulePkg/Library/PlatformBootManagerLibNull/PlatformBootManager.c +++ b/MdeModulePkg/Library/PlatformBootManagerLibNull/PlatformBootManager.c @@ -15,7 +15,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent Such as: Update console variable; - Register new Driver#### or Boot####; + Register new SysPrep#### or Boot####; Signal ReadyToLock event. **/ VOID diff --git a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c b/MdeModulePkg/Universal/BdsDxe/BdsEntry.c index d387dbe7ac12..1fb04dcbbcda 100644 --- a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c +++ b/MdeModulePkg/Universal/BdsDxe/BdsEntry.c @@ -854,7 +854,7 @@ BdsEntry ( // Do the platform init, can be customized by OEM/IBV // Possible things that can be done in PlatformBootManagerBeforeConsole: // > Update console variable: 1. include hot-plug devices; 2. Clear ConIn and add SOL for AMT - // > Register new Driver#### or Boot#### + // > Register new SysPrep#### or Boot#### // > Register new Key####: e.g.: F12 // > Signal ReadyToLock event // > Authentication action: 1. connect Auth devices; 2. Identify auto logon user. diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c index 8af9b71f18a3..b7dc9a1fefdc 100644 --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c @@ -339,7 +339,7 @@ SaveS3BootScript ( > Update console variable: 1. include hot-plug devices; > 2. Clear ConIn and add SOL for AMT - > Register new Driver#### or Boot#### + > Register new SysPrep#### or Boot#### > Register new Key####: e.g.: F12 > Signal ReadyToLock event > Authentication action: 1. connect Auth devices; diff --git a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c index c5c6af0abcb2..2833d2b03019 100644 --- a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c +++ b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c @@ -143,7 +143,7 @@ PlatformRegisterFvBootOption ( Such as: Update console variable; - Register new Driver#### or Boot####; + Register new SysPrep#### or Boot####; Signal ReadyToLock event. **/ VOID -- 2.17.1