From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web11.3907.1576073687983975738 for ; Wed, 11 Dec 2019 06:14:48 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=VEIQMexD; spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: leif.lindholm@linaro.org) Received: by mail-wm1-f67.google.com with SMTP id p17so2793680wmb.0 for ; Wed, 11 Dec 2019 06:14:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PFEyZhM0XNPm5wF2TlqGjWagXPmTLFYyMoL+jBP+dQM=; b=VEIQMexDZUZrIcXY+Bi/e4ew57FzHKFUjJjwsoHfXNOe8XBefZiF6gRFf0BQ4HJaVo 4Te/ZkSDBj+huA9WGcYjxpAYXAVcRD2cI4zXASilvaw5o1wcuaG5Yg7MVVXqIQEfd5PY cToLx/ZZGDU3fE6aZEh7AE+N/itobBnoJeFEE7QlcDK2YYOncY0DqjJIAUolO7JYqhmj 9ivBxjDPSCDnv76Mme24un+7eFc8M7vd64J0S5lvoBify7XUs2TPELpbe0f0xm2Ek+1k U8fnFfwC+jSX+wIHTrq+av6OK/aEi5XRJoY9DPb6IjmGKG9pFod/omtv7jU3c24JHP6W 5xFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PFEyZhM0XNPm5wF2TlqGjWagXPmTLFYyMoL+jBP+dQM=; b=W8s6NVccYQh2kpZo3GeIpLlx97wnt55QMeXe+tZGc/m1J1GK8wTUd1WKJrAKZDT8yO LUH9sVduL73U4sRPSg1SjnlSmzOwKvUyNy0fXY0jsP7zQaUwjVATQVQPtbeRVI5Th3Ty ZkDDQz2jsjeeXWHjb5yRgJaHj7kcRpqWTUIdh1BTZMG8UUBCb1Kwuq5SdkqJzseVgMam LOmLtBsJu+ELuqKnxX7IC7CjTfgnGPMqk8sOowIwJiZ/IHlASlsgngYcX5+hph9SNzkh riRJ8wyA4zzVpRM7KQE5BAEjqJUJbXuiUmWMrxfTsGU9o0jUGEWvQ985t6Wag/vAIYZh xDyQ== X-Gm-Message-State: APjAAAViFqb0Vv444Cl4d4o7BO04k2TKbGQuSLrDFwrXNO/sbmfUW683 ejXgK6xJKpgV+3KgOu33LEoRDg== X-Google-Smtp-Source: APXvYqyF3efWEmaat8Y60us8JxqWxfEx88ILHhS2UqJzQHDPOwJfKjGj0ZmaPtgf8T2Q62WdWPNwTw== X-Received: by 2002:a1c:f316:: with SMTP id q22mr4044348wmq.103.1576073686486; Wed, 11 Dec 2019 06:14:46 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id b67sm2529081wmc.38.2019.12.11.06.14.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Dec 2019 06:14:45 -0800 (PST) Date: Wed, 11 Dec 2019 14:14:44 +0000 From: "Leif Lindholm" To: Pete Batard Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org, philmd@redhat.com Subject: Re: [edk2-non-osi][PATCH 2/2] Platforms/RPi4: Add Trusted Firmware binaries Message-ID: <20191211141443.GB7359@bivouac.eciton.net> References: <20191211112400.1872-1-pete@akeo.ie> <20191211112400.1872-3-pete@akeo.ie> MIME-Version: 1.0 In-Reply-To: <20191211112400.1872-3-pete@akeo.ie> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Dec 11, 2019 at 11:24:00 +0000, Pete Batard wrote: > Similar to what is the case with the Raspberry Pi 3, the Raspberry Pi > 4 UEFI firmware requires the provision of a Trusted Firmware binary > (TF-A). > > The binary is built for a dtb base address of 0x00020000 and a UEFI > payload base address of 0x00030000. > > Binaries are built using a custom version of TF-A (the source of which > is documented in the Readme), since the official repository is missing > a fix to get proper baudrate when using a recent version of start4.elf, > as we as the ability to switch between PL011 and mini UART. We are > currently working with TF-A to upstream both these fixes so that we can > switch to binaries built from official source at a later date. > > In order to provide the ability to switch serial I/O controllers, a > feature we will be adding to the RPi4 UEFI Firmware, and not lose TF-A > output, two binaries are provided, one for mini UART output and one for > PL011 output. > > Signed-off-by: Pete Batard > --- > Platform/RaspberryPi/RPi4/TrustedFirmware/License.txt | 26 ++++++++++++++++++++ > Platform/RaspberryPi/RPi4/TrustedFirmware/Readme.md | 12 +++++++++ > Platform/RaspberryPi/RPi4/TrustedFirmware/bl31_miniuart.bin | Bin 0 -> 41072 bytes > Platform/RaspberryPi/RPi4/TrustedFirmware/bl31_pl011.bin | Bin 0 -> 41072 bytes > 4 files changed, 38 insertions(+) > > new file mode 100644 > index 000000000000..7f1749dfc3a0 > --- /dev/null > +++ b/Platform/RaspberryPi/RPi4/TrustedFirmware/Readme.md > @@ -0,0 +1,12 @@ > +ARM Trusted Firmware for Raspberry Pi 4 > +======================================= > + > +The `bl31_#####.bin` TF-A binaries found in this repository were built on a Debian 10.2 system > +from https://github.com/pbatard/arm-trusted-firmware/tree/pi4 (pi4 branch) using the command: > + > +``` > +make PLAT=rpi4 RPI3_PRELOADED_DTB_BASE=0x20000 PRELOADED_BL33_BASE=0x30000 SUPPORT_VFP=1 [RPI3_USE_PL011_UART=1] DEBUG=0 all > +``` > + > +The only difference between these firmwares is that the `RPI3_USE_PL011_UART=1` option was added > +to build `bl31_pl011.bin` so that it uses PL011 for serial output rather than the "mini UART". Sanity check: do the build commands still use RPI3_ options for rpi4? Best Regards, Leif