* [edk2-platforms][PATCH 1/1] Platform/RPi: Inhibit serial output for all runtime drivers
@ 2019-12-11 17:04 Pete Batard
2019-12-16 15:11 ` Leif Lindholm
0 siblings, 1 reply; 3+ messages in thread
From: Pete Batard @ 2019-12-11 17:04 UTC (permalink / raw)
To: devel; +Cc: ard.biesheuvel, leif.lindholm, philmd
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
This is an improvement of e9db04631b63574b090aeab769cc47dcb75a29f7
where we inhibit serial output of MMIO mapped UARTs to all runtime
drivers rather than just RTC, as other drivers may crash the OS
just the same.
Also add it to the Pi 4 platform where it was missing altogether.
Signed-off-by: Pete Batard <pete@akeo.ie>
---
Platform/RaspberryPi/RPi3/RPi3.dsc | 3 ++-
Platform/RaspberryPi/RPi4/RPi4.dsc | 2 ++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
index 945baa5021f8..2368b04f40a4 100644
--- a/Platform/RaspberryPi/RPi3/RPi3.dsc
+++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
@@ -200,6 +200,8 @@ [LibraryClasses.common.UEFI_DRIVER]
MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
[LibraryClasses.common.DXE_RUNTIME_DRIVER]
+ # Runtime debug messages may crash an OS unless serial output to MMIO mapped UARTs is inhibited
+ DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf
@@ -505,7 +507,6 @@ [Components.common]
EmbeddedPkg/ResetRuntimeDxe/ResetRuntimeDxe.inf
EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf {
<LibraryClasses>
- DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
RealTimeClockLib|EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf
}
EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf
diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
index 3764d1b3d794..03139e57a8db 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.dsc
+++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
@@ -202,6 +202,8 @@ [LibraryClasses.common.UEFI_DRIVER]
MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
[LibraryClasses.common.DXE_RUNTIME_DRIVER]
+ # Runtime debug messages may crash an OS unless serial output to MMIO mapped UARTs is inhibited
+ DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-platforms][PATCH 1/1] Platform/RPi: Inhibit serial output for all runtime drivers
2019-12-11 17:04 [edk2-platforms][PATCH 1/1] Platform/RPi: Inhibit serial output for all runtime drivers Pete Batard
@ 2019-12-16 15:11 ` Leif Lindholm
2019-12-19 17:26 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2019-12-16 15:11 UTC (permalink / raw)
To: Pete Batard; +Cc: devel, ard.biesheuvel, philmd
On Wed, Dec 11, 2019 at 17:04:01 +0000, Pete Batard wrote:
> From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Oops - sorry, I missed the From: - thanks for the poke.
Yeah, I'm good with this change:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> This is an improvement of e9db04631b63574b090aeab769cc47dcb75a29f7
> where we inhibit serial output of MMIO mapped UARTs to all runtime
> drivers rather than just RTC, as other drivers may crash the OS
> just the same.
>
> Also add it to the Pi 4 platform where it was missing altogether.
>
> Signed-off-by: Pete Batard <pete@akeo.ie>
> ---
> Platform/RaspberryPi/RPi3/RPi3.dsc | 3 ++-
> Platform/RaspberryPi/RPi4/RPi4.dsc | 2 ++
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
> index 945baa5021f8..2368b04f40a4 100644
> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc
> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
> @@ -200,6 +200,8 @@ [LibraryClasses.common.UEFI_DRIVER]
> MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
>
> [LibraryClasses.common.DXE_RUNTIME_DRIVER]
> + # Runtime debug messages may crash an OS unless serial output to MMIO mapped UARTs is inhibited
> + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
> MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
> EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf
> @@ -505,7 +507,6 @@ [Components.common]
> EmbeddedPkg/ResetRuntimeDxe/ResetRuntimeDxe.inf
> EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf {
> <LibraryClasses>
> - DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
> RealTimeClockLib|EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf
> }
> EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
> index 3764d1b3d794..03139e57a8db 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> @@ -202,6 +202,8 @@ [LibraryClasses.common.UEFI_DRIVER]
> MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
>
> [LibraryClasses.common.DXE_RUNTIME_DRIVER]
> + # Runtime debug messages may crash an OS unless serial output to MMIO mapped UARTs is inhibited
> + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
> MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
> EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf
> --
> 2.21.0.windows.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-platforms][PATCH 1/1] Platform/RPi: Inhibit serial output for all runtime drivers
2019-12-16 15:11 ` Leif Lindholm
@ 2019-12-19 17:26 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2019-12-19 17:26 UTC (permalink / raw)
To: Leif Lindholm
Cc: Pete Batard, edk2-devel-groups-io, Philippe Mathieu-Daudé
On Mon, 16 Dec 2019 at 17:11, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Wed, Dec 11, 2019 at 17:04:01 +0000, Pete Batard wrote:
> > From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Oops - sorry, I missed the From: - thanks for the poke.
>
> Yeah, I'm good with this change:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
Thanks
Pushed as e9395c53ba2c..479821a9677c
> > This is an improvement of e9db04631b63574b090aeab769cc47dcb75a29f7
> > where we inhibit serial output of MMIO mapped UARTs to all runtime
> > drivers rather than just RTC, as other drivers may crash the OS
> > just the same.
> >
> > Also add it to the Pi 4 platform where it was missing altogether.
> >
> > Signed-off-by: Pete Batard <pete@akeo.ie>
> > ---
> > Platform/RaspberryPi/RPi3/RPi3.dsc | 3 ++-
> > Platform/RaspberryPi/RPi4/RPi4.dsc | 2 ++
> > 2 files changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
> > index 945baa5021f8..2368b04f40a4 100644
> > --- a/Platform/RaspberryPi/RPi3/RPi3.dsc
> > +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
> > @@ -200,6 +200,8 @@ [LibraryClasses.common.UEFI_DRIVER]
> > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
> >
> > [LibraryClasses.common.DXE_RUNTIME_DRIVER]
> > + # Runtime debug messages may crash an OS unless serial output to MMIO mapped UARTs is inhibited
> > + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
> > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
> > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
> > EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf
> > @@ -505,7 +507,6 @@ [Components.common]
> > EmbeddedPkg/ResetRuntimeDxe/ResetRuntimeDxe.inf
> > EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf {
> > <LibraryClasses>
> > - DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
> > RealTimeClockLib|EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf
> > }
> > EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf
> > diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
> > index 3764d1b3d794..03139e57a8db 100644
> > --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> > +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> > @@ -202,6 +202,8 @@ [LibraryClasses.common.UEFI_DRIVER]
> > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
> >
> > [LibraryClasses.common.DXE_RUNTIME_DRIVER]
> > + # Runtime debug messages may crash an OS unless serial output to MMIO mapped UARTs is inhibited
> > + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
> > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
> > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
> > EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf
> > --
> > 2.21.0.windows.1
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-19 17:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-11 17:04 [edk2-platforms][PATCH 1/1] Platform/RPi: Inhibit serial output for all runtime drivers Pete Batard
2019-12-16 15:11 ` Leif Lindholm
2019-12-19 17:26 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox