From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web11.6322.1576083858158144710 for ; Wed, 11 Dec 2019 09:04:18 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=sa9xF04m; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.128.68, mailfrom: pete@akeo.ie) Received: by mail-wm1-f68.google.com with SMTP id d139so1648312wmd.0 for ; Wed, 11 Dec 2019 09:04:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=0IJcY0pkg/4UHVK8lBRRZt0JMUx9M4b37yE/Pq3W5Hc=; b=sa9xF04mAyvLrvItVXionjDHxuorrdj9IvrkYC24CEyYTN1Vn/6TB91GOXpFUUjYLC mHHriERhZyGiPHhiooriwyE3d6a0YT1i/faayX6gbFJOyS3AjHtB8t64TZsgjJw7whWL R4QyhJgzwmEPrSN2D8vR0r7Kvhn0TH5YbvpIvy51jFYVZIyUX+EPP6PMn+K9djz12zOO 9evr1Dq1JcJc4mWmdPUaUlfbvFzRPHMyU7ezPZXlJLmWRWDy+IFZkc14LU84B9DO0jMl h6ZRFoHYJO1UvdmDBTOzgyh+Uf//lOau3bClroY3u4BRs5c2p4nw9dKliWaw/Z7pcxw1 LrrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=0IJcY0pkg/4UHVK8lBRRZt0JMUx9M4b37yE/Pq3W5Hc=; b=L1DfnQPrBxEA81+lyA3VaXhpgjEyxYcmoOpJNZoXWOm3Nsysb/nx4R63aCSRaD4qrp 9l1AkE0Wcgdhv656v2ZHiGfP456eOJk3ea9e2mx6c98XNckdz8kpV4rzkpir3LBI7FxK +bw9gQKbZ4mJeDD7zFwVX+MxXH4tjJZMR4Vhl8hGJ3cV0W4Ts0b21JyAy9D/2GyL6seq DsuLj2hUNnt3ZXbp21FXZOIxqmCPF8TaM68P1195VgKKtiAVRMW0l458Ti7srT2pyRPT il9mxr6G5iEKewG1E+McDkyId6GRdP2Etgb/T/7S3JnFG2MBlYinDXzOAmowRIijus4i 243w== X-Gm-Message-State: APjAAAU+nk1HjkhBYCg7nh0drAuvAg1xWWCN1uBx6FeS/g1y/4z4q3xg Ep4HCfDVk/hXbSeyz7nniZNp9jRWwMSVqw== X-Google-Smtp-Source: APXvYqwi2RGFUmhC/NwMfR+BfCBXhKZmQBqyTEQOdXZKY/Yn8t1Ezg4ybRh1UtTVC60AYBJ2KCN7/Q== X-Received: by 2002:a1c:2083:: with SMTP id g125mr877881wmg.89.1576083856333; Wed, 11 Dec 2019 09:04:16 -0800 (PST) Return-Path: Received: from localhost.localdomain ([84.203.45.230]) by smtp.gmail.com with ESMTPSA id m3sm2922904wrs.53.2019.12.11.09.04.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Dec 2019 09:04:15 -0800 (PST) From: "Pete Batard" To: devel@edk2.groups.io Cc: ard.biesheuvel@linaro.org, leif.lindholm@linaro.org, philmd@redhat.com Subject: [edk2-platforms][PATCH 1/1] Platform/RPi: Inhibit serial output for all runtime drivers Date: Wed, 11 Dec 2019 17:04:01 +0000 Message-Id: <20191211170401.7336-1-pete@akeo.ie> X-Mailer: git-send-email 2.21.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Ard Biesheuvel This is an improvement of e9db04631b63574b090aeab769cc47dcb75a29f7 where we inhibit serial output of MMIO mapped UARTs to all runtime drivers rather than just RTC, as other drivers may crash the OS just the same. Also add it to the Pi 4 platform where it was missing altogether. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/RPi3.dsc | 3 ++- Platform/RaspberryPi/RPi4/RPi4.dsc | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc index 945baa5021f8..2368b04f40a4 100644 --- a/Platform/RaspberryPi/RPi3/RPi3.dsc +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc @@ -200,6 +200,8 @@ [LibraryClasses.common.UEFI_DRIVER] MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf [LibraryClasses.common.DXE_RUNTIME_DRIVER] + # Runtime debug messages may crash an OS unless serial output to MMIO mapped UARTs is inhibited + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf @@ -505,7 +507,6 @@ [Components.common] EmbeddedPkg/ResetRuntimeDxe/ResetRuntimeDxe.inf EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf { - DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf RealTimeClockLib|EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf } EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc index 3764d1b3d794..03139e57a8db 100644 --- a/Platform/RaspberryPi/RPi4/RPi4.dsc +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc @@ -202,6 +202,8 @@ [LibraryClasses.common.UEFI_DRIVER] MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf [LibraryClasses.common.DXE_RUNTIME_DRIVER] + # Runtime debug messages may crash an OS unless serial output to MMIO mapped UARTs is inhibited + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf -- 2.21.0.windows.1