From: "Anthony PERARD" <anthony.perard@citrix.com>
To: <devel@edk2.groups.io>, <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>,
Steven Shi <steven.shi@intel.com>,
Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [Patch 1/4 V6] BaseTools: Add build option for dependency file generation
Date: Mon, 16 Dec 2019 14:13:36 +0000 [thread overview]
Message-ID: <20191216141336.GB1267@perard.uk.xensource.com> (raw)
In-Reply-To: <20191206152658.26476-2-bob.c.feng@intel.com>
On Fri, Dec 06, 2019 at 11:26:55PM +0800, Bob Feng wrote:
> BaseTools/Conf/tools_def.template | 181 ++++++++++++++++--------------
Hi Bob,
That patch introduces the first two UTF-8 characters (the quote ’ ) in
an otherwise all-ascii file. And that prevent our CI from building OVMF.
Part of the error log:
Running edk2 build for OvmfPkgX64
build.py...
: error 0001: File open failure
/home/osstest/build.144860.build-amd64/xen/tools/firmware/ovmf-dir-remote/Conf/tools_def.txt
Traceback (most recent call last):
File "/home/osstest/build.144860.build-amd64/xen/tools/firmware/ovmf-dir-remote/BaseTools/Source/Python/Common/ToolDefClassObject.py", line 117, in IncludeToolDefFile
FileContent = F.readlines()
File "/usr/lib/python3.5/encodings/ascii.py", line 26, in decode
return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 2289: ordinal not in range(128)
Full build log can be found here, with ovmf build near the bottom:
http://logs.test-lab.xenproject.org/osstest/logs/144860/build-amd64/6.ts-xen-build.log
Should we replaces the two offending quotes by proper ascii quotes? Or
should we fix IncludeToolDefFile to always use UTF-8 decoding? Or both?
Thanks,
--
Anthony PERARD
next prev parent reply other threads:[~2019-12-16 14:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 15:26 [Patch 0/4 V6] Enhance Incremental Build Bob Feng
2019-12-06 15:26 ` [Patch 1/4 V6] BaseTools: Add build option for dependency file generation Bob Feng
2019-12-16 14:13 ` Anthony PERARD [this message]
2019-12-16 23:30 ` [edk2-devel] " Michael D Kinney
2019-12-17 0:25 ` Bob Feng
2019-12-18 2:31 ` Bob Feng
2019-12-06 15:26 ` [Patch 2/4 V6] BaseTools: Generate dependent files for ASL and ASM files Bob Feng
2019-12-06 15:26 ` [Patch 3/4 V6] BaseTools: Update build_rule.txt to generate dependent files Bob Feng
2019-12-06 15:26 ` [Patch 4/4 V6] BaseTools: Enhance Basetool for incremental build Bob Feng
2019-12-08 23:35 ` [edk2-devel] [Patch 0/4 V6] Enhance Incremental Build Liming Gao
2019-12-09 5:44 ` Bob Feng
2019-12-10 1:40 ` Bob Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216141336.GB1267@perard.uk.xensource.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox