From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by mx.groups.io with SMTP id smtpd.web11.6939.1576505619590641217 for ; Mon, 16 Dec 2019 06:13:43 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@citrix.com header.s=securemail header.b=HFnxCbBT; spf=pass (domain: citrix.com, ip: 216.71.145.142, mailfrom: anthony.perard@citrix.com) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1576505620; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=jjkr0oLKmU3aNQiakON3x03qHckqZG61t10z0hYPq4o=; b=HFnxCbBTtHmdYMdiG/HyqSksvsBuv2+lFF0WrfXpMCM7ti2HCDx0VVvH kXsDxpIa3c0Od1g9kj7RR/hHMve/cYa/FPg+eSE5ucf74p9LYLXSpbdrs f3Rq4C6/XiYEkgwb9B8PxFcp0MTPnB1dHt/pB1LbBgIoyn//2aJq0vZBU I=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa1.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: qHOWrRQAzCER0OefAlL7s75S6ePFyYRJueguIAM656IQLYtKCa+lNe/rOlDEy6VC+fLfDB0LJJ qHYhyUsZ9E2k7Ul3zxxuYNZzqhBNeMZpxT3SABJnpsRcjUrMeWcHsTgWVQleeUaxUuE1IsliiR 3zRRVWSC1cO3LOHh2BrcQCmT35FdOky00JgWV3heJaxGMquDFmdV9okhN00hRuc10FgFUbRWpU JCly7jSce9GGd3lNavC9ZvWL/4NhZAnX3qzPW1hwldEdBRR0k4/XtUONkPw4tWrAsKBxNhtp8u RFg= X-SBRS: 2.7 X-MesageID: 9859366 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,321,1571716800"; d="scan'208";a="9859366" Date: Mon, 16 Dec 2019 14:13:36 +0000 From: "Anthony PERARD" To: , CC: Liming Gao , Steven Shi , Michael D Kinney Subject: Re: [edk2-devel] [Patch 1/4 V6] BaseTools: Add build option for dependency file generation Message-ID: <20191216141336.GB1267@perard.uk.xensource.com> References: <20191206152658.26476-1-bob.c.feng@intel.com> <20191206152658.26476-2-bob.c.feng@intel.com> MIME-Version: 1.0 In-Reply-To: <20191206152658.26476-2-bob.c.feng@intel.com> Return-Path: anthony.perard@citrix.com Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit On Fri, Dec 06, 2019 at 11:26:55PM +0800, Bob Feng wrote: > BaseTools/Conf/tools_def.template | 181 ++++++++++++++++-------------- Hi Bob, That patch introduces the first two UTF-8 characters (the quote ’ ) in an otherwise all-ascii file. And that prevent our CI from building OVMF. Part of the error log: Running edk2 build for OvmfPkgX64 build.py... : error 0001: File open failure /home/osstest/build.144860.build-amd64/xen/tools/firmware/ovmf-dir-remote/Conf/tools_def.txt Traceback (most recent call last): File "/home/osstest/build.144860.build-amd64/xen/tools/firmware/ovmf-dir-remote/BaseTools/Source/Python/Common/ToolDefClassObject.py", line 117, in IncludeToolDefFile FileContent = F.readlines() File "/usr/lib/python3.5/encodings/ascii.py", line 26, in decode return codecs.ascii_decode(input, self.errors)[0] UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 2289: ordinal not in range(128) Full build log can be found here, with ovmf build near the bottom: http://logs.test-lab.xenproject.org/osstest/logs/144860/build-amd64/6.ts-xen-build.log Should we replaces the two offending quotes by proper ascii quotes? Or should we fix IncludeToolDefFile to always use UTF-8 decoding? Or both? Thanks, -- Anthony PERARD