From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web12.7615.1576509107115107564 for ; Mon, 16 Dec 2019 07:11:47 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=R598RPa5; spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: leif.lindholm@linaro.org) Received: by mail-wm1-f67.google.com with SMTP id p9so7138581wmc.2 for ; Mon, 16 Dec 2019 07:11:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=U3562j9pM59AMT7GXcwR9gTfGsPeoErSo61OgTJx+wg=; b=R598RPa5+xVIBdq8R7IhLbh2fUXnitI/hAnoD2hjxRZtEvmoBYyqgiov+6MIAqAVXA MdWFOv3Xpg7YxHfe/3YdL8og2AqCec2V/it2k6OU+5laMEEp9WXUpIQpezI90sebuBim y/9ayCU/B9WyNi7epHBgxZg5PQ3LZm0ifRifTbGNds9gXGMDorPKsL+d+iixZQ6JP7+1 Lxho0cHj8rJl9rFMGjFFLWfkCiOzubFCgwM+qToaqEv01jwatWmAFVGMMLiWuEsqSgUT c53H+clwOuIpKD7F4bmpRLPOZJbS1sB07o7wllu1Wkucn9jE/QNt/UB4mmd1Hw/QMcFz ElyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=U3562j9pM59AMT7GXcwR9gTfGsPeoErSo61OgTJx+wg=; b=Oj+L/TGhpWsZSTNFGBk3Vn56wRejhUKmCIuZTaZDV/cG0CONOlXmbG+ZbtQKE5ycE0 FFJ28/XZD8aZsxYE+M8tkoTipyn1t/tAI5KKjVNRmaAj5+ZnQEPS5+Lq98VyVtysN8T8 QMmHvQDle/wWfm50x/Z5jCyehLNtbp4kHlLUmYxaoE8UwH2XY+gR8E5CUDvcTCVzlLZm 56p5FdrdIrd1Znp1HQVgl2hai2oGXpVVAuJFRAQDRj4mf6RgRgO1XVwJA8mcYrZ4iqmn 6sXSCiyG0NLWTMrCc4Tdouukva6qrg/Qmw7sUPy/E6RZoEmB8orIyNj4uRVpAFH96dtL VcYA== X-Gm-Message-State: APjAAAURty17+a2KAS67nq+tqbXUPyZakC9mLKEPHL1963RajXzr1oQj 1DbSKMFgA8Tl90gSzCsSIk6d2g== X-Google-Smtp-Source: APXvYqxwRTg3WK6xlBMBKYVqhDC1um2Sy47eZv8I8JblJxxJSs6EnP6IiSLqzyNR4wqBk/yIAIGyqQ== X-Received: by 2002:a05:600c:2290:: with SMTP id 16mr32669497wmf.93.1576509105594; Mon, 16 Dec 2019 07:11:45 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o66sm17928566wmo.20.2019.12.16.07.11.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2019 07:11:44 -0800 (PST) Date: Mon, 16 Dec 2019 15:11:43 +0000 From: "Leif Lindholm" To: Pete Batard Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org, philmd@redhat.com Subject: Re: [edk2-platforms][PATCH 1/1] Platform/RPi: Inhibit serial output for all runtime drivers Message-ID: <20191216151143.GJ7359@bivouac.eciton.net> References: <20191211170401.7336-1-pete@akeo.ie> MIME-Version: 1.0 In-Reply-To: <20191211170401.7336-1-pete@akeo.ie> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Dec 11, 2019 at 17:04:01 +0000, Pete Batard wrote: > From: Ard Biesheuvel Oops - sorry, I missed the From: - thanks for the poke. Yeah, I'm good with this change: Reviewed-by: Leif Lindholm > This is an improvement of e9db04631b63574b090aeab769cc47dcb75a29f7 > where we inhibit serial output of MMIO mapped UARTs to all runtime > drivers rather than just RTC, as other drivers may crash the OS > just the same. > > Also add it to the Pi 4 platform where it was missing altogether. > > Signed-off-by: Pete Batard > --- > Platform/RaspberryPi/RPi3/RPi3.dsc | 3 ++- > Platform/RaspberryPi/RPi4/RPi4.dsc | 2 ++ > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc > index 945baa5021f8..2368b04f40a4 100644 > --- a/Platform/RaspberryPi/RPi3/RPi3.dsc > +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc > @@ -200,6 +200,8 @@ [LibraryClasses.common.UEFI_DRIVER] > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > + # Runtime debug messages may crash an OS unless serial output to MMIO mapped UARTs is inhibited > + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf > @@ -505,7 +507,6 @@ [Components.common] > EmbeddedPkg/ResetRuntimeDxe/ResetRuntimeDxe.inf > EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf { > > - DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > RealTimeClockLib|EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf > } > EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf > diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc > index 3764d1b3d794..03139e57a8db 100644 > --- a/Platform/RaspberryPi/RPi4/RPi4.dsc > +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc > @@ -202,6 +202,8 @@ [LibraryClasses.common.UEFI_DRIVER] > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > + # Runtime debug messages may crash an OS unless serial output to MMIO mapped UARTs is inhibited > + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf > -- > 2.21.0.windows.1 >