Re: [PATCH] Platform/Qemu/Sbsa: Add TF-A binaries

["Leif Lindholm" <leif.lindholm@linaro.org>]

On Wed, Dec 04, 2019 at 22:48:14 +0530, Tanmay Jagdale wrote:
> Add fip.bin and bl1.bin binaries for the Qemu Sbsa model
> 
> Signed-off-by: Tanmay Jagdale <tanmay.jagdale@linaro.org>
> ---
> The bl1.bin and fip.bin binaries are present in the following git repository
> https://git.linaro.org/people/tanmay.jagdale/edk2-non-osi.git/tree/Platform/Qemu/Sbsa
> 
>  Platform/Qemu/Sbsa/License.txt |  25 +++++++++++++++++++++++++
>  Platform/Qemu/Sbsa/Readme.md   |  19 +++++++++++++++++++
>  Platform/Qemu/Sbsa/bl1.bin     | Bin 0 -> 19064 bytes
>  Platform/Qemu/Sbsa/fip.bin     | Bin 0 -> 53984 bytes
>  4 files changed, 44 insertions(+)
>  create mode 100644 Platform/Qemu/Sbsa/License.txt
>  create mode 100644 Platform/Qemu/Sbsa/Readme.md
>  create mode 100755 Platform/Qemu/Sbsa/bl1.bin
>  create mode 100644 Platform/Qemu/Sbsa/fip.bin
> 
> diff --git a/Platform/Qemu/Sbsa/License.txt b/Platform/Qemu/Sbsa/License.txt
> new file mode 100644
> index 0000000..b45969c
> --- /dev/null
> +++ b/Platform/Qemu/Sbsa/License.txt
> @@ -0,0 +1,25 @@
> +opyright (c) 2019, Linaro Ltd. All rights reserved.

Missing leading 'C'.

> +
> +Redistribution and use in source and binary forms, with or without
> +modification, are permitted provided that the following conditions
> +are met:
> +
> +* Redistributions of source code must retain the above copyright
> +  notice, this list of conditions and the following disclaimer.
> +* Redistributions in binary form must reproduce the above copyright
> +  notice, this list of conditions and the following disclaimer in
> +  the documentation and/or other materials provided with the
> +  distribution.
> +
> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> +"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> +LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
> +FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
> +COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
> +INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
> +BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
> +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
> +CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
> +LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
> +ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> +POSSIBILITY OF SUCH DAMAGE.
> diff --git a/Platform/Qemu/Sbsa/Readme.md b/Platform/Qemu/Sbsa/Readme.md
> new file mode 100644
> index 0000000..7febaa8
> --- /dev/null
> +++ b/Platform/Qemu/Sbsa/Readme.md
> @@ -0,0 +1,19 @@
> +Qemu SBSA TF-A binaries
> +-----------------------
> +
> +These binaries have been created from the mainline TF-A
> +code checked out at the following commit ID:
> +
> +commit a74e3a16b50c70a34936b03876c2018c52ae8311
> +Merge: a04808c1 b30646a8
> +Author: Alexei Fedorov <Alexei.Fedorov@arm.com>
> +Date:   Fri Oct 25 09:36:59 2019 +0000
> +
> +    Merge "plat/arm: use Aff3 bits also to validate mpidr" into integration
> +
> +

This really only needs the commit hash, but the above is not useful,
so we can keep it in.

> +No modifications to the source code have been done.

That is implicit, so this line can be deleted.

But I can do that and the C before pushing this patch, if you're OK
with that? If so

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

(But I will hold off on pushing until the edk2-platforms support is
ready to go in.)

Regards,

Leif

> +The binaries have been generated for the AARCH64 platform
> +with the following command:
> +
> +	make PLAT=qemu_sbsa all fip
> diff --git a/Platform/Qemu/Sbsa/bl1.bin b/Platform/Qemu/Sbsa/bl1.bin
> new file mode 100755
> index 0000000..c23afd0
> Binary files /dev/null and b/Platform/Qemu/Sbsa/bl1.bin differ
> diff --git a/Platform/Qemu/Sbsa/fip.bin b/Platform/Qemu/Sbsa/fip.bin
> new file mode 100644
> index 0000000..fcde089
> Binary files /dev/null and b/Platform/Qemu/Sbsa/fip.bin differ
> -- 
> 2.17.1
>