From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.5269.1576632791164480421 for ; Tue, 17 Dec 2019 17:33:11 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Dec 2019 17:33:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,327,1571727600"; d="scan'208";a="266743138" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by FMSMGA003.fm.intel.com with ESMTP; 17 Dec 2019 17:33:10 -0800 Received: from orsmsx125.amr.corp.intel.com (10.22.240.125) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Dec 2019 17:33:10 -0800 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.106]) by ORSMSX125.amr.corp.intel.com ([169.254.3.12]) with mapi id 14.03.0439.000; Tue, 17 Dec 2019 17:33:10 -0800 From: "Nate DeSimone" To: "Agyeman, Prince" CC: "devel@edk2.groups.io" , "Kubacki, Michael A" , "Chiu, Chasel" Subject: Re: [edk2-platforms] [PATCH 04/11] MinPlatformPkg: Add BDS Board Boot Manager library Thread-Topic: [edk2-platforms] [PATCH 04/11] MinPlatformPkg: Add BDS Board Boot Manager library Thread-Index: AQHVsh5k+OXSNZqz10SDzL7sPTmIIqe/qBSA Date: Wed, 18 Dec 2019 01:33:09 +0000 Message-ID: <20191218013309.GE1930@nate-virtualbox> References: <1a09aca176f54fff55f69ad40935d01d7330350a.1576282834.git.prince.agyeman@intel.com> In-Reply-To: <1a09aca176f54fff55f69ad40935d01d7330350a.1576282834.git.prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.7.159.63] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: <7BE0085E12EA0C42BACA948A455B1CFF@intel.com> Content-Transfer-Encoding: quoted-printable Hi Prince, Reviewed-by: Nate DeSimone Thanks, Nate On Sat, Dec 14, 2019 at 01:32:30AM +0000, Agyeman, Prince wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2336 >=20 > As Minplatform's PlatformBootManager library instance implements > event signals (as specified in the minimum platform specification) > to trigger board actions, some of its functions namely > PlatformBootManagerWaitCallback and PlatformBootManagerUnableToBoot > will not have events signaled for boards to take action. >=20 > This library implements PlatformBootManagerWaitCallback > and PlatformBootManagerUnableToBoot which will be linked to Minplatform's > PlatformBootManager libary instance. >=20 > Added is an interface/header file that defines the board boot manager > library. >=20 > Also added is a NULL implementation of the board boot manager library >=20 > Cc: Michael Kubacki > Cc: Chasel Chiu > Cc: Nate DeSimone >=20 > Signed-off-by: Prince Agyeman > --- > .../BoardBootManagerLib.c | 38 ++++++++++++++++++ > .../BoardBootManagerLibNull.inf | 31 +++++++++++++++ > .../Include/Library/BoardBootManagerLib.h | 39 +++++++++++++++++++ > 3 files changed, 108 insertions(+) > create mode 100644 Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootMa= nagerLibNull/BoardBootManagerLib.c > create mode 100644 Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootMa= nagerLibNull/BoardBootManagerLibNull.inf > create mode 100644 Platform/Intel/MinPlatformPkg/Include/Library/BoardBo= otManagerLib.h >=20 > diff --git a/Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootManagerLi= bNull/BoardBootManagerLib.c b/Platform/Intel/MinPlatformPkg/Bds/Library/Boa= rdBootManagerLibNull/BoardBootManagerLib.c > new file mode 100644 > index 0000000000..46fce8f59f > --- /dev/null > +++ b/Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootManagerLibNull/B= oardBootManagerLib.c > @@ -0,0 +1,38 @@ > +/** @file > + This file include board specific boot manager callbacks > + > + Copyright (c) 2018, Intel Corporation. All rights reserved.
> + SPDX-License-Identifier: BSD-2-Clause-Patent > +**/ > + > +#include > + > +/** > + This function is called each second during the boot manager waits time= out. > + > + @param TimeoutRemain The remaining timeout. > +**/ > +VOID > +EFIAPI > +BoardBootManagerWaitCallback ( > + IN UINT16 TimeoutRemain > + ) > +{ > + return; > +} > + > +/** > + The function is called when no boot option could be launched, > + including platform recovery options and options pointing to applicatio= ns > + built into firmware volumes. > + > +**/ > +VOID > +EFIAPI > +BoardBootManagerUnableToBoot ( > + VOID > + ) > +{ > + return; > +} > + > diff --git a/Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootManagerLi= bNull/BoardBootManagerLibNull.inf b/Platform/Intel/MinPlatformPkg/Bds/Libra= ry/BoardBootManagerLibNull/BoardBootManagerLibNull.inf > new file mode 100644 > index 0000000000..084207b111 > --- /dev/null > +++ b/Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootManagerLibNull/B= oardBootManagerLibNull.inf > @@ -0,0 +1,31 @@ > +## @file > +# The module definition file for BoardBootManagerLib. > +# > +# Copyright (c) 2019, Intel Corporation. All rights reserved.
> +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +[Defines] > + INF_VERSION =3D 0x00010005 > + BASE_NAME =3D BoardBootManagerLib > + FILE_GUID =3D 7BA684A4-5B32-4F0C-B0FF-581F143E606= C > + MODULE_TYPE =3D DXE_DRIVER > + VERSION_STRING =3D 1.0 > + LIBRARY_CLASS =3D BoardBootManagerLib|DXE_DRIVER > + > + > +# > +# The following information is for reference only and not required by th= e build tools. > +# > +# VALID_ARCHITECTURES =3D IA32 X64 EBC > +# > + > +[Sources] > + BoardBootManagerLib.c > + > + > +[Packages] > + MdePkg/MdePkg.dec > + MdeModulePkg/MdeModulePkg.dec > + MinPlatformPkg/MinPlatformPkg.dec > diff --git a/Platform/Intel/MinPlatformPkg/Include/Library/BoardBootManag= erLib.h b/Platform/Intel/MinPlatformPkg/Include/Library/BoardBootManagerLib= .h > new file mode 100644 > index 0000000000..4240142073 > --- /dev/null > +++ b/Platform/Intel/MinPlatformPkg/Include/Library/BoardBootManagerLib.h > @@ -0,0 +1,39 @@ > +/** @file > + Board Boot Manager library definition. A platform can implement > + instances to support platform-specific behavior. > + > + Copyright (c) 2019, Intel Corporation. All rights reserved.
> + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > + > +#ifndef __BOARD_BOOT_MANAGER_LIB_H_ > +#define __BOARD_BOOT_MANAGER_LIB_H_ > +#include > + > + > +/** > + This function is called each second during boot manager waits the time= out. > + > + @param TimeoutRemain The remaining timeout. > +**/ > +VOID > +EFIAPI > +BoardBootManagerWaitCallback ( > + IN UINT16 TimeoutRemain > + ); > + > +/** > + The function is called when no boot option could be launched, > + including platform recovery options and options pointing to applicatio= ns > + built into firmware volumes. > + > +**/ > +VOID > +EFIAPI > +BoardBootManagerUnableToBoot ( > + VOID > + ); > + > +#endif > --=20 > 2.19.1.windows.1 > =