From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.5270.1576632922254746127 for ; Tue, 17 Dec 2019 17:35:22 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Dec 2019 17:35:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,327,1571727600"; d="scan'208";a="227698896" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by orsmga002.jf.intel.com with ESMTP; 17 Dec 2019 17:35:21 -0800 Received: from orsmsx163.amr.corp.intel.com (10.22.240.88) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Dec 2019 17:35:21 -0800 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.106]) by ORSMSX163.amr.corp.intel.com ([169.254.9.4]) with mapi id 14.03.0439.000; Tue, 17 Dec 2019 17:35:21 -0800 From: "Nate DeSimone" To: "Agyeman, Prince" CC: "devel@edk2.groups.io" , "Kubacki, Michael A" , "Chiu, Chasel" Subject: Re: [edk2-platforms] [PATCH 08/11] WhiskeylakeOpenBoardPkg: Add BDS Hook Dxe Driver Thread-Topic: [edk2-platforms] [PATCH 08/11] WhiskeylakeOpenBoardPkg: Add BDS Hook Dxe Driver Thread-Index: AQHVsh5n2w4wtA/EjESXwA1oJkTz2ae/qLAA Date: Wed, 18 Dec 2019 01:35:21 +0000 Message-ID: <20191218013520.GI1930@nate-virtualbox> References: <8d19c7fcaeb13430c0557bdc1bd6ce1b8835a9b1.1576282834.git.prince.agyeman@intel.com> In-Reply-To: <8d19c7fcaeb13430c0557bdc1bd6ce1b8835a9b1.1576282834.git.prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.7.159.63] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: <12E7A50A405D80428C773455289CB19C@intel.com> Content-Transfer-Encoding: quoted-printable Hi Prince, Reviewed-by: Nate DeSimone Thanks, Nate On Sat, Dec 14, 2019 at 01:32:34AM +0000, Agyeman, Prince wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2336 >=20 > Added a DXE driver that registers the minimum platform > BDS hook points, to WhiskeylakeURvp board. > These hooks are triggered on the BDS hook events >=20 > What was done: >=20 > * Included an instance of BdsHookLib and BoardBootManagerLib > from BoardModulePkg >=20 > * Included BdsHookDxe to register the callbacks implemented > in BdsHookLib >=20 > Cc: Michael Kubacki > Cc: Chasel Chiu > Cc: Nate DeSimone >=20 > Signed-off-by: Prince Agyeman > --- > .../WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc | 4 ++++ > .../WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.fdf | 1 + > 2 files changed, 5 insertions(+) >=20 > diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenB= oardPkg.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBo= ardPkg.dsc > index 47e156be08..1a9e608bd6 100644 > --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg= .dsc > +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg= .dsc > @@ -224,6 +224,8 @@ > ####################################### > DxePolicyUpdateLib|$(PLATFORM_BOARD_PACKAGE)/Policy/Library/DxePolicyU= pdateLib/DxePolicyUpdateLib.inf > DxeTbtPolicyLib|$(PLATFORM_BOARD_PACKAGE)/Features/Tbt/Library/DxeTbtP= olicyLib/DxeTbtPolicyLib.inf > + BoardBdsHookLib|BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib= .inf > + BoardBootManagerLib|BoardModulePkg/Library/BoardBootManagerLib/BoardBo= otManagerLib.inf > =20 > ####################################### > # Board-specific > @@ -452,3 +454,5 @@ > $(PLATFORM_BOARD_PACKAGE)/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf > !endif > BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > + BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf > + > diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenB= oardPkg.fdf b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBo= ardPkg.fdf > index f39b41b186..ad32268a82 100644 > --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg= .fdf > +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg= .fdf > @@ -346,6 +346,7 @@ INF MdeModulePkg/Universal/Console/GraphicsOutputDxe= /GraphicsOutputDxe.inf > INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > INF BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > INF MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf > +INF BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf > =20 > INF ShellPkg/Application/Shell/Shell.inf > =20 > --=20 > 2.19.1.windows.1 > =