From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web12.5281.1576632962163684188 for ; Tue, 17 Dec 2019 17:36:02 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Dec 2019 17:36:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,327,1571727600"; d="scan'208";a="417046644" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by fmsmga006.fm.intel.com with ESMTP; 17 Dec 2019 17:36:01 -0800 Received: from orsmsx123.amr.corp.intel.com (10.22.240.116) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Dec 2019 17:36:00 -0800 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.106]) by ORSMSX123.amr.corp.intel.com ([169.254.1.113]) with mapi id 14.03.0439.000; Tue, 17 Dec 2019 17:36:00 -0800 From: "Nate DeSimone" To: "Agyeman, Prince" CC: "devel@edk2.groups.io" , "Kubacki, Michael A" , "Chiu, Chasel" Subject: Re: [edk2-platforms] [PATCH 11/11] SimicsOpenBoardPkg: Add Bds Hook Points Thread-Topic: [edk2-platforms] [PATCH 11/11] SimicsOpenBoardPkg: Add Bds Hook Points Thread-Index: AQHVsh5lJVN+Ts+oCkmLz/yT+sRGwae/qOAA Date: Wed, 18 Dec 2019 01:36:00 +0000 Message-ID: <20191218013600.GK1930@nate-virtualbox> References: <3ef9d5be91ce7f2442cec09dd93c66bcb9a03447.1576282834.git.prince.agyeman@intel.com> In-Reply-To: <3ef9d5be91ce7f2442cec09dd93c66bcb9a03447.1576282834.git.prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.7.159.63] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: <12AEEA19DD51F749B86CC2D346D126F4@intel.com> Content-Transfer-Encoding: quoted-printable Hi Prince, Reviewed-by: Nate DeSimone Thanks, Nate On Sat, Dec 14, 2019 at 01:32:37AM +0000, Agyeman, Prince wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2336 >=20 > Added a DXE driver that registers the minimum platform > BDS hook points, to BoardX58Ich10 board. > These hooks are triggered on the BDS hook events >=20 > What was done: >=20 > * Included a board specific instance of BoardBdsHookLib > and BoardBootManagerLib >=20 > * Included Minplatforms PlatformBootManagerLib instance. > This Library instance signals the Bds event groups >=20 > * Included BoardBdsHookDxe to register the callbacks implemented > in BoardBdsHookLib >=20 > Cc: Michael Kubacki > Cc: Chasel Chiu > Cc: Nate DeSimone >=20 > Signed-off-by: Prince Agyeman > --- > .../SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 10 +++++++++- > .../SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf | 1 + > 2 files changed, 10 insertions(+), 1 deletion(-) >=20 > diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg= .dsc b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > index 7576648d57..350a75a313 100644 > --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > @@ -146,10 +146,17 @@ > SetCacheMtrrLib|$(PLATFORM_PACKAGE)/Library/SetCacheMtrrLib/SetCacheMt= rrLib.inf > =20 > [LibraryClasses.common.DXE_DRIVER] > + > + ##################################### > + # Platform Package > + ##################################### > + PlatformBootManagerLib|$(PLATFORM_PACKAGE)/Bds/Library/DxePlatformBoot= ManagerLib/DxePlatformBootManagerLib.inf > + > ####################################### > # Board Package > ####################################### > - PlatformBootManagerLib|$(BOARD_PKG)/Library/PlatformBootManagerLib/Pla= tformBootManagerLib.inf > + BoardBdsHookLib|$(BOARD_PKG)/Library/BoardBdsHookLib/BoardBdsHookLib.i= nf > + BoardBootManagerLib|$(BOARD_PKG)/Library/BoardBootManagerLib/BoardBoot= ManagerLib.inf > =20 > [LibraryClasses.common.DXE_SMM_DRIVER] > ####################################### > @@ -294,3 +301,4 @@ > $(BOARD_PKG)/SimicsVideoDxe/SimicsVideoDxe.inf > $(BOARD_PKG)/SmbiosPlatformDxe/SmbiosPlatformDxe.inf > BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > + BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf > diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg= .fdf b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf > index e0a1daddee..99bf607775 100644 > --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf > +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf > @@ -213,6 +213,7 @@ INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf > INF MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf > INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > INF BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > +INF BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf > =20 > INF MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf > =20 > --=20 > 2.19.1.windows.1 > =