From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: devel@edk2.groups.io
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <liming.gao@intel.com>
Subject: [PATCH] MdePkg/Spdm: fix Nonce structure error.
Date: Wed, 18 Dec 2019 11:00:18 +0800 [thread overview]
Message-ID: <20191218030018.18560-1-jiewen.yao@intel.com> (raw)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2427
Align to SPDM 1.0.0 specification.
Fix Nonce data structure error.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
---
MdePkg/Include/IndustryStandard/Spdm.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/MdePkg/Include/IndustryStandard/Spdm.h b/MdePkg/Include/IndustryStandard/Spdm.h
index c05395fea7..38ec7748a7 100644
--- a/MdePkg/Include/IndustryStandard/Spdm.h
+++ b/MdePkg/Include/IndustryStandard/Spdm.h
@@ -1,6 +1,6 @@
/** @file
Definitions of Security Protocol & Data Model Specification (SPDM)
- version 0.99a in Distributed Management Task Force (DMTF).
+ version 1.0.0 in Distributed Management Task Force (DMTF).
Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -215,7 +215,7 @@ typedef struct {
///
typedef struct {
SPDM_MESSAGE_HEADER Header;
- UINT32 Nonce;
+ UINT8 Nonce[32];
} SPDM_CHALLENGE_REQUEST;
///
@@ -224,7 +224,7 @@ typedef struct {
typedef struct {
SPDM_MESSAGE_HEADER Header;
//UINT8 CertChainHash[DigestSize];
-//UINT32 Nonce;
+//UINT8 Nonce[32];
//UINT8 MeasurementSummaryHash[DigestSize];
//UINT16 OpaqueLength;
//UINT8 OpaqueData[OpaqueLength];
@@ -236,7 +236,7 @@ typedef struct {
///
typedef struct {
SPDM_MESSAGE_HEADER Header;
- UINT32 Nonce;
+ UINT8 Nonce[32];
} SPDM_GET_MEASUREMENTS_REQUEST;
///
@@ -277,7 +277,7 @@ typedef struct {
UINT8 NumberOfBlocks;
UINT8 MeasurementRecordLength[3];
//UINT8 MeasurementRecord[MeasurementRecordLength];
-//UINT32 Nonce;
+//UINT8 Nonce[32];
//UINT16 OpaqueLength;
//UINT8 OpaqueData[OpaqueLength];
//UINT8 Signature[KeySize];
--
2.19.2.windows.1
next reply other threads:[~2019-12-18 3:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 3:00 Yao, Jiewen [this message]
2019-12-18 14:31 ` [PATCH] MdePkg/Spdm: fix Nonce structure error Liming Gao
2019-12-18 22:31 ` Yao, Jiewen
2019-12-19 1:16 ` Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218030018.18560-1-jiewen.yao@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox