From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web12.9970.1576764794115974486 for ; Thu, 19 Dec 2019 06:13:14 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=EfcPiauu; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576764793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wdug5i08cMq/9TIYqsfXpSQu3gkkip8RedrYZ6W0aTo=; b=EfcPiauuRUJrJBbZ7LnqAnLFb/5q1woZEx1Exaf3s2HgptvZNA5NtjK8MApeRdSLEe8NGJ si/eSFU/L76pEjcUqLQ4G9W2i8R3tdkr6pw5rlQlrSvfixNpsuKn/axoRr9aEUeRBkVALG 8Ab+ZQnRycaPKkNkjA7YIvvI3o9Yz7I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-399-DA0Tku31OSaQy7AVD03mdA-1; Thu, 19 Dec 2019 09:13:06 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E19071005514; Thu, 19 Dec 2019 14:13:04 +0000 (UTC) Received: from x1w.redhat.com (unknown [10.36.118.122]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6F8CA10013A1; Thu, 19 Dec 2019 14:12:58 +0000 (UTC) From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= To: devel@edk2.groups.io Cc: Philippe Mathieu-Daude , Liming Gao , Jordan Justen , Yonghong Zhu , Zhichao Gao Subject: [PATCH 1/1] BaseTools/PatchCheck.py: Ignore CR and LF characters in subject length Date: Thu, 19 Dec 2019 15:12:56 +0100 Message-Id: <20191219141256.25752-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: DA0Tku31OSaQy7AVD03mdA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D113 Strip the trailing characters before checking the subject line is less than 72 characters. Fixes: e61406708c83f Cc: Liming Gao Cc: Jordan Justen Signed-off-by: Philippe Mathieu-Daude --- Cc: Yonghong Zhu Cc: Zhichao Gao --- BaseTools/Scripts/PatchCheck.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck= .py index 2a4e6f603e79..b72e71963ea8 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -196,7 +196,7 @@ class CommitMessageCheck: self.error('Empty commit message!') return =20 - if count >=3D 1 and len(lines[0]) >=3D 72: + if count >=3D 1 and len(lines[0].strip()) >=3D 72: self.error('First line of commit message (subject line) ' + 'is too long.') =20 --=20 2.21.0