public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Bob Feng" <bob.c.feng@intel.com>
To: devel@edk2.groups.io
Cc: Liming Gao <liming.gao@intel.com>,
	Kilian Kegel <kilian_kegel@outlook.com>
Subject: [Patch] GenBiosId: Fixed a regression bug introduced by 8b72f720d53e
Date: Fri, 20 Dec 2019 16:41:30 +0800	[thread overview]
Message-ID: <20191220084130.18488-1-bob.c.feng@intel.com> (raw)

8b72f720d53e introduced a regression bug that make GenBiosId
failed if -ot is passed to this tool.

This patch is going to fix it.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Kilian Kegel <kilian_kegel@outlook.com>
Signed-off-by: Bob Feng <bob.c.feng@intel.com>
---
 Platform/Intel/Tools/GenBiosId/GenBiosId.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/Intel/Tools/GenBiosId/GenBiosId.py b/Platform/Intel/Tools/GenBiosId/GenBiosId.py
index 8cecb1c76f..f823fdcad1 100644
--- a/Platform/Intel/Tools/GenBiosId/GenBiosId.py
+++ b/Platform/Intel/Tools/GenBiosId/GenBiosId.py
@@ -107,11 +107,11 @@ def MyOptionParser():
     return Options
 
 
 # Check the Tool for missing variables
 def CheckOptions(Options):
-    if len(sys.argv) not in [5,6] and not (len(sys.argv) not in [7,8] and Options.OutputTextFile):
+    if len(sys.argv) not in [5,6] and not (len(sys.argv) in [7,8] and Options.OutputTextFile):
         EdkLogger("GenBiosId", OPTION_MISSING, ExtraData=_Usage)
     elif not Options.InputFile or not Options.OutputFile:
         EdkLogger("GenBiosId", OPTION_MISSING, ExtraData=_Usage)
     InputFile = Options.InputFile
     OutputFile = Options.OutputFile
-- 
2.20.1.windows.1


             reply	other threads:[~2019-12-20  8:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-20  8:41 Bob Feng [this message]
2019-12-23  0:45 ` [Patch] GenBiosId: Fixed a regression bug introduced by 8b72f720d53e Liming Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191220084130.18488-1-bob.c.feng@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox