From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web09.6783.1576831307943854592 for ; Fri, 20 Dec 2019 00:41:48 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: bob.c.feng@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Dec 2019 00:41:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,335,1571727600"; d="scan'208";a="218432150" Received: from shwdepsi1121.ccr.corp.intel.com ([10.239.158.47]) by orsmga006.jf.intel.com with ESMTP; 20 Dec 2019 00:41:46 -0800 From: "Bob Feng" To: devel@edk2.groups.io Cc: Liming Gao , Kilian Kegel Subject: [Patch] GenBiosId: Fixed a regression bug introduced by 8b72f720d53e Date: Fri, 20 Dec 2019 16:41:30 +0800 Message-Id: <20191220084130.18488-1-bob.c.feng@intel.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 8b72f720d53e introduced a regression bug that make GenBiosId failed if -ot is passed to this tool. This patch is going to fix it. Cc: Liming Gao Cc: Kilian Kegel Signed-off-by: Bob Feng --- Platform/Intel/Tools/GenBiosId/GenBiosId.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/Intel/Tools/GenBiosId/GenBiosId.py b/Platform/Intel/Tools/GenBiosId/GenBiosId.py index 8cecb1c76f..f823fdcad1 100644 --- a/Platform/Intel/Tools/GenBiosId/GenBiosId.py +++ b/Platform/Intel/Tools/GenBiosId/GenBiosId.py @@ -107,11 +107,11 @@ def MyOptionParser(): return Options # Check the Tool for missing variables def CheckOptions(Options): - if len(sys.argv) not in [5,6] and not (len(sys.argv) not in [7,8] and Options.OutputTextFile): + if len(sys.argv) not in [5,6] and not (len(sys.argv) in [7,8] and Options.OutputTextFile): EdkLogger("GenBiosId", OPTION_MISSING, ExtraData=_Usage) elif not Options.InputFile or not Options.OutputFile: EdkLogger("GenBiosId", OPTION_MISSING, ExtraData=_Usage) InputFile = Options.InputFile OutputFile = Options.OutputFile -- 2.20.1.windows.1