From: "Albecki, Mateusz" <mateusz.albecki@intel.com>
To: devel@edk2.groups.io
Cc: Mateusz Albecki <mateusz.albecki@intel.com>,
Hao A Wu <hao.a.wu@intel.com>, Marcin Wojtas <mw@semihalf.com>,
Zhichao Gao <zhichao.gao@intel.com>,
Liming Gao <liming.gao@intel.com>
Subject: [PATCH 0/2] MdeModulePkg/SdMmcPciHcDxe: Send the EdkiiSdMmcSwitchClockFreq notification before sending CMD13
Date: Fri, 20 Dec 2019 18:13:10 +0100 [thread overview]
Message-ID: <20191220171312.3120-1-mateusz.albecki@intel.com> (raw)
The first patch refactors the SdMmcClockSupply function with a goal
of sending the EdkiiSdMmcSwitchClockFreq notification before we send the
CMD13 to check the switch status in eMMC init flow. This is required to
avoid sending the CMD13 on link that still has not been fixed by platform.
To avoid changing the driver behavior we avoid sending notifications
when the clock is setup for the first time or when we setup the clock
after the voltage switch procedure(adressed in second patch).
The second patch in the series optimizes the SD card detection routine
to stop it from going through the process of internal clock setup
after switching the voltage. According to SD HC specification there
is no need to setup internal clock all over again.
Tests performed:
- Booted eMMC in HS400 mode on platform which required post clock freq fixes
I wasn't able to test SD card yet due to the lack of setup with working SD.
The patch series is available on github here: https://github.com/malbecki/edk2/tree/sdmmc_post_freq_notify
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Marcin Wojtas <mw@semihalf.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Mateusz Albecki (2):
SdMmcPciHcDxe: Send EdkiiSdMmcSwitchClockFreq after SD clock start
MdeModulePkg/SdMmcPciHcDxe: Add function to start SD clock
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 20 +--
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 25 +---
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 24 ++++
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 136 +++++++++++----------
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 45 ++-----
5 files changed, 112 insertions(+), 138 deletions(-)
--
2.14.1.windows.1
--------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.
next reply other threads:[~2019-12-20 17:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 17:13 Albecki, Mateusz [this message]
2019-12-20 17:13 ` [PATCH 1/2] SdMmcPciHcDxe: Send EdkiiSdMmcSwitchClockFreq after SD clock start Albecki, Mateusz
2019-12-24 2:52 ` Wu, Hao A
2019-12-24 9:54 ` Ard Biesheuvel
2019-12-30 8:44 ` Marcin Wojtas
2019-12-31 14:49 ` Albecki, Mateusz
2019-12-20 17:13 ` [PATCH 2/2] MdeModulePkg/SdMmcPciHcDxe: Add function to start SD clock Albecki, Mateusz
2019-12-24 2:52 ` Wu, Hao A
2019-12-24 2:51 ` [PATCH 0/2] MdeModulePkg/SdMmcPciHcDxe: Send the EdkiiSdMmcSwitchClockFreq notification before sending CMD13 Wu, Hao A
2020-01-03 11:04 ` Marcin Wojtas
2020-01-06 5:18 ` Wu, Hao A
2020-01-06 6:10 ` [edk2-devel] " Wu, Hao A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191220171312.3120-1-mateusz.albecki@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox