* [PATCH 0/4] BaseTools/PatchCheck: Check committer/author email addresses
@ 2020-01-02 15:24 Philippe Mathieu-Daudé
2020-01-02 15:36 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-01-02 15:24 UTC (permalink / raw)
To: devel; +Cc: Laszlo Ersek, Michael D Kinney, Philippe Mathieu-Daude
Last month I cleaned the git-history incorrect email
addresses: https://edk2.groups.io/g/devel/message/51834
but today I noticed more incorrect addresses got committed
(see caa917491a4..33a3293651).
To avoid having the same cleanup in the future, fix the
problem once for all by having PatchCheck doing this
automatically (on merge).
Since we already have code to check email address in
PatchCheck, factor the code out to reuse it, and
add checks for committer/author addresses.
Philippe Mathieu-Daude (4):
BaseTools/PatchCheck.py: Extract email check code to EmailAddressCheck
BaseTools/PatchCheck.py: Let EmailAddressCheck describe email checked
BaseTools/PatchCheck.py: Check the patch author email address
BaseTools/PatchCheck.py: Check the committer email address
BaseTools/Scripts/PatchCheck.py | 99 +++++++++++++++++++++++----------
1 file changed, 69 insertions(+), 30 deletions(-)
--
2.21.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/4] BaseTools/PatchCheck: Check committer/author email addresses
2020-01-02 15:24 [PATCH 0/4] BaseTools/PatchCheck: Check committer/author email addresses Philippe Mathieu-Daudé
@ 2020-01-02 15:36 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-01-02 15:36 UTC (permalink / raw)
To: devel; +Cc: Laszlo Ersek, Michael D Kinney
On 1/2/20 4:24 PM, Philippe Mathieu-Daude wrote:
> Last month I cleaned the git-history incorrect email
> addresses: https://edk2.groups.io/g/devel/message/51834
> but today I noticed more incorrect addresses got committed
> (see caa917491a4..33a3293651).
> To avoid having the same cleanup in the future, fix the
> problem once for all by having PatchCheck doing this
> automatically (on merge).
>
> Since we already have code to check email address in
> PatchCheck, factor the code out to reuse it, and
> add checks for committer/author addresses.
>
> Philippe Mathieu-Daude (4):
> BaseTools/PatchCheck.py: Extract email check code to EmailAddressCheck
> BaseTools/PatchCheck.py: Let EmailAddressCheck describe email checked
> BaseTools/PatchCheck.py: Check the patch author email address
> BaseTools/PatchCheck.py: Check the committer email address
>
> BaseTools/Scripts/PatchCheck.py | 99 +++++++++++++++++++++++----------
> 1 file changed, 69 insertions(+), 30 deletions(-)
Please disregard this cover, I forgot to use the Cc tags:
Cc: Liming Gao <liming.gao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
I hit ^C too late :S
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 0/4] BaseTools/PatchCheck: Check committer/author email addresses
@ 2020-01-02 15:25 Philippe Mathieu-Daudé
2020-01-03 13:11 ` Laszlo Ersek
0 siblings, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-01-02 15:25 UTC (permalink / raw)
To: devel
Cc: Laszlo Ersek, Michael D Kinney, Philippe Mathieu-Daude,
Liming Gao, Jordan Justen
Last month I cleaned the git-history incorrect email
addresses: https://edk2.groups.io/g/devel/message/51834
but today I noticed more incorrect addresses got committed
(see caa917491a4..33a3293651).
To avoid having the same cleanup in the future, fix the
problem once for all by having PatchCheck doing this
automatically (on merge).
Since we already have code to check email address in
PatchCheck, factor the code out to reuse it, and
add checks for committer/author addresses.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Philippe Mathieu-Daude (4):
BaseTools/PatchCheck.py: Extract email check code to EmailAddressCheck
BaseTools/PatchCheck.py: Let EmailAddressCheck describe email checked
BaseTools/PatchCheck.py: Check the patch author email address
BaseTools/PatchCheck.py: Check the committer email address
BaseTools/Scripts/PatchCheck.py | 99 +++++++++++++++++++++++----------
1 file changed, 69 insertions(+), 30 deletions(-)
--
2.21.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/4] BaseTools/PatchCheck: Check committer/author email addresses
2020-01-02 15:25 Philippe Mathieu-Daudé
@ 2020-01-03 13:11 ` Laszlo Ersek
0 siblings, 0 replies; 4+ messages in thread
From: Laszlo Ersek @ 2020-01-03 13:11 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel; +Cc: Michael D Kinney, Liming Gao, Jordan Justen
Hi,
On 01/02/20 16:25, Philippe Mathieu-Daude wrote:
> Last month I cleaned the git-history incorrect email
> addresses: https://edk2.groups.io/g/devel/message/51834
> but today I noticed more incorrect addresses got committed
> (see caa917491a4..33a3293651).
> To avoid having the same cleanup in the future, fix the
> problem once for all by having PatchCheck doing this
> automatically (on merge).
>
> Since we already have code to check email address in
> PatchCheck, factor the code out to reuse it, and
> add checks for committer/author addresses.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
>
> Philippe Mathieu-Daude (4):
> BaseTools/PatchCheck.py: Extract email check code to EmailAddressCheck
> BaseTools/PatchCheck.py: Let EmailAddressCheck describe email checked
> BaseTools/PatchCheck.py: Check the patch author email address
> BaseTools/PatchCheck.py: Check the committer email address
>
> BaseTools/Scripts/PatchCheck.py | 99 +++++++++++++++++++++++----------
> 1 file changed, 69 insertions(+), 30 deletions(-)
>
still struggling with my email backlog, so I'm going to skip this for now.
Thanks
Laszlo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-03 13:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-02 15:24 [PATCH 0/4] BaseTools/PatchCheck: Check committer/author email addresses Philippe Mathieu-Daudé
2020-01-02 15:36 ` Philippe Mathieu-Daudé
-- strict thread matches above, loose matches on Subject: below --
2020-01-02 15:25 Philippe Mathieu-Daudé
2020-01-03 13:11 ` Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox