From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web12.7111.1578566973811451406 for ; Thu, 09 Jan 2020 02:49:34 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Apu/oHoT; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578566972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=V/Sor89ulEEhOPqSxj0n0OONNt9dAivM0OLDxn2w74g=; b=Apu/oHoTNkX3EMTk9NDCuqLIUIlo7vJoRXx6kJUyXdwtudVWYEx2zvovr8M3ef1BowtThW mVcLLUtGJH4plfoUQ6NmYLMT9rXlXM/C3F9xZHKCIdr3KBpJ95O3Q5P1oC4UhlTqgLIAbd ljJhBsAw2tifVYPQ0hhQREDky45taVM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-91-YUZ0gyMlOLmyESP4QkzXUQ-1; Thu, 09 Jan 2020 05:49:27 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 33453DB20; Thu, 9 Jan 2020 10:49:26 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-107.brq.redhat.com [10.40.204.107]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7500960E3E; Thu, 9 Jan 2020 10:49:21 +0000 (UTC) From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= To: Liming Gao , Bob Feng , devel@edk2.groups.io Cc: Philippe Mathieu-Daude Subject: [PATCH v3 0/4] BaseTools/PatchCheck: Check committer/author email addresses Date: Thu, 9 Jan 2020 11:49:14 +0100 Message-Id: <20200109104918.29750-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: YUZ0gyMlOLmyESP4QkzXUQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Last month I cleaned the git-history incorrect email addresses: https://edk2.groups.io/g/devel/message/51834 but today I noticed more incorrect addresses got committed (see caa917491a4..33a3293651). To avoid having the same cleanup in the future, fix the problem once for all by having PatchCheck doing this automatically (on merge). Since we already have code to check email address in PatchCheck, factor the code out to reuse it, and add checks for committer/author addresses. Series only tested on Linux. Since v2 [1]: - Add 2020 Copyright notice in header - Add Bob Feng Reviewed-by tag Since v1 [2]: - Addressed Jordan Justen review comment [1] https://edk2.groups.io/g/devel/message/52656 [2] https://edk2.groups.io/g/devel/message/52885 Philippe Mathieu-Daud=C3=A9 (4): BaseTools/PatchCheck.py: Extract email check code to EmailAddressCheck BaseTools/PatchCheck.py: Let EmailAddressCheck describe email checked BaseTools/PatchCheck.py: Check the patch author email address BaseTools/PatchCheck.py: Check the committer email address BaseTools/Scripts/PatchCheck.py | 100 ++++++++++++++++++++++---------- 1 file changed, 70 insertions(+), 30 deletions(-) --=20 2.21.1