From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web09.7231.1578567358964928391 for ; Thu, 09 Jan 2020 02:55:59 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CqY/H5AZ; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578567358; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=S29rwnDVBx50zFTA2ho5SLx6opNsO9hEvOx29Kso3Jg=; b=CqY/H5AZVW5hoAFW8kRuwOJBRq75XEZqndfNv0gFu16MsnP+kAqImEShgcQPH6Q/RzGfWt Di8tsGnzwa5e3340nS+0PlDKZUQQVxZ8hD6nzvFq8jAVwZQ3nTOeng0jmB1rdqH8tSkks5 6Up1HCR/XDjlc6yfnJ+2SjpzobNNlqw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-401-VV5AnC47NXKMrJG_eJaCPg-1; Thu, 09 Jan 2020 05:55:56 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6BC84477; Thu, 9 Jan 2020 10:55:55 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-107.brq.redhat.com [10.40.204.107]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0393C60BE0; Thu, 9 Jan 2020 10:55:50 +0000 (UTC) From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= To: Liming Gao , Bob Feng , devel@edk2.groups.io Cc: Philippe Mathieu-Daude Subject: [PATCH v4 0/4] BaseTools/PatchCheck: Check committer/author email addresses Date: Thu, 9 Jan 2020 11:55:42 +0100 Message-Id: <20200109105546.30768-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: VV5AnC47NXKMrJG_eJaCPg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Last month I cleaned the git-history incorrect email addresses: https://edk2.groups.io/g/devel/message/51834 but today I noticed more incorrect addresses got committed (see caa917491a4..33a3293651). To avoid having the same cleanup in the future, fix the problem once for all by having PatchCheck doing this automatically (on merge). Since we already have code to check email address in PatchCheck, factor the code out to reuse it, and add checks for committer/author addresses. Series only tested on Linux. Since v3 [1]: - Correct maintainer Cc tag in patch description Since v2 [2]: - Added 2020 Copyright notice in header - Added Bob Feng Reviewed-by tag Since v1 [3]: - Addressed Jordan Justen review comment [1] https://edk2.groups.io/g/devel/message/53062 [2] https://edk2.groups.io/g/devel/message/52656 [3] https://edk2.groups.io/g/devel/message/52885 Cc: Bob Feng Cc: Liming Gao Philippe Mathieu-Daud=C3=A9 (4): BaseTools/PatchCheck.py: Extract email check code to EmailAddressCheck BaseTools/PatchCheck.py: Let EmailAddressCheck describe email checked BaseTools/PatchCheck.py: Check the patch author email address BaseTools/PatchCheck.py: Check the committer email address BaseTools/Scripts/PatchCheck.py | 100 ++++++++++++++++++++++---------- 1 file changed, 70 insertions(+), 30 deletions(-) --=20 2.21.1