public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH 1/1] MdeModulePkg/SdMmcPciHcDxe: Fix unknown doxygen tag error
@ 2020-01-10 10:26 Albecki, Mateusz
  2020-01-13  1:09 ` Wu, Hao A
  0 siblings, 1 reply; 3+ messages in thread
From: Albecki, Mateusz @ 2020-01-10 10:26 UTC (permalink / raw)
  To: devel; +Cc: Mateusz Albecki, Hao A Wu

Changed @rtval to @retval in SdMmcHcStartSdClock
function description.

Cc: Hao A Wu <hao.a.wu@intel.com>

Signed-off-by: Mateusz Albecki <mateusz.albecki@intel.com>
---
 MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +-
 MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
index e7f2fac69b..d1e60938f9 100644
--- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
+++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
@@ -765,7 +765,7 @@ SdMmcHcStopClock (
   @param[in] Slot   The slot number.
 
   @retval EFI_SUCCESS  Succeeded to start the SD clock.
-  @rtval  Others       Failed to start the SD clock.
+  @retval Others       Failed to start the SD clock.
 **/
 EFI_STATUS
 SdMmcHcStartSdClock (
diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h
index 4753bb6864..16229a846c 100644
--- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h
+++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h
@@ -485,7 +485,7 @@ SdMmcHcStopClock (
   @param[in] Slot   The slot number.
 
   @retval EFI_SUCCESS  Succeeded to start the SD clock.
-  @rtval  Others       Failed to start the SD clock.
+  @retval Others       Failed to start the SD clock.
 **/
 EFI_STATUS
 SdMmcHcStartSdClock (
-- 
2.14.1.windows.1

--------------------------------------------------------------------

Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] MdeModulePkg/SdMmcPciHcDxe: Fix unknown doxygen tag error
  2020-01-10 10:26 [PATCH 1/1] MdeModulePkg/SdMmcPciHcDxe: Fix unknown doxygen tag error Albecki, Mateusz
@ 2020-01-13  1:09 ` Wu, Hao A
  2020-01-13  1:26   ` [edk2-devel] " Wu, Hao A
  0 siblings, 1 reply; 3+ messages in thread
From: Wu, Hao A @ 2020-01-13  1:09 UTC (permalink / raw)
  To: Albecki, Mateusz, devel@edk2.groups.io

> -----Original Message-----
> From: Albecki, Mateusz
> Sent: Friday, January 10, 2020 6:26 PM
> To: devel@edk2.groups.io
> Cc: Albecki, Mateusz; Wu, Hao A
> Subject: [PATCH 1/1] MdeModulePkg/SdMmcPciHcDxe: Fix unknown
> doxygen tag error
> 
> Changed @rtval to @retval in SdMmcHcStartSdClock
> function description.
> 
> Cc: Hao A Wu <hao.a.wu@intel.com>
> 
> Signed-off-by: Mateusz Albecki <mateusz.albecki@intel.com>
> ---
>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +-
>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> index e7f2fac69b..d1e60938f9 100644
> --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> @@ -765,7 +765,7 @@ SdMmcHcStopClock (
>    @param[in] Slot   The slot number.
> 
>    @retval EFI_SUCCESS  Succeeded to start the SD clock.
> -  @rtval  Others       Failed to start the SD clock.
> +  @retval Others       Failed to start the SD clock.
>  **/
>  EFI_STATUS
>  SdMmcHcStartSdClock (
> diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h
> b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h
> index 4753bb6864..16229a846c 100644
> --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h
> +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h
> @@ -485,7 +485,7 @@ SdMmcHcStopClock (
>    @param[in] Slot   The slot number.
> 
>    @retval EFI_SUCCESS  Succeeded to start the SD clock.
> -  @rtval  Others       Failed to start the SD clock.
> +  @retval Others       Failed to start the SD clock.
>  **/


Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu


>  EFI_STATUS
>  SdMmcHcStartSdClock (
> --
> 2.14.1.windows.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/SdMmcPciHcDxe: Fix unknown doxygen tag error
  2020-01-13  1:09 ` Wu, Hao A
@ 2020-01-13  1:26   ` Wu, Hao A
  0 siblings, 0 replies; 3+ messages in thread
From: Wu, Hao A @ 2020-01-13  1:26 UTC (permalink / raw)
  To: devel@edk2.groups.io, Wu, Hao A, Albecki, Mateusz

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Monday, January 13, 2020 9:09 AM
> To: Albecki, Mateusz; devel@edk2.groups.io
> Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/SdMmcPciHcDxe: Fix
> unknown doxygen tag error
> 
> > -----Original Message-----
> > From: Albecki, Mateusz
> > Sent: Friday, January 10, 2020 6:26 PM
> > To: devel@edk2.groups.io
> > Cc: Albecki, Mateusz; Wu, Hao A
> > Subject: [PATCH 1/1] MdeModulePkg/SdMmcPciHcDxe: Fix unknown
> > doxygen tag error
> >
> > Changed @rtval to @retval in SdMmcHcStartSdClock
> > function description.
> >
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> >
> > Signed-off-by: Mateusz Albecki <mateusz.albecki@intel.com>
> > ---
> >  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +-
> >  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > index e7f2fac69b..d1e60938f9 100644
> > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > @@ -765,7 +765,7 @@ SdMmcHcStopClock (
> >    @param[in] Slot   The slot number.
> >
> >    @retval EFI_SUCCESS  Succeeded to start the SD clock.
> > -  @rtval  Others       Failed to start the SD clock.
> > +  @retval Others       Failed to start the SD clock.
> >  **/
> >  EFI_STATUS
> >  SdMmcHcStartSdClock (
> > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h
> > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h
> > index 4753bb6864..16229a846c 100644
> > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h
> > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h
> > @@ -485,7 +485,7 @@ SdMmcHcStopClock (
> >    @param[in] Slot   The slot number.
> >
> >    @retval EFI_SUCCESS  Succeeded to start the SD clock.
> > -  @rtval  Others       Failed to start the SD clock.
> > +  @retval Others       Failed to start the SD clock.
> >  **/
> 
> 
> Reviewed-by: Hao A Wu <hao.a.wu@intel.com>


Pushed via commit 27f44ea1fb.

Best Regards,
Hao Wu


> 
> Best Regards,
> Hao Wu
> 
> 
> >  EFI_STATUS
> >  SdMmcHcStartSdClock (
> > --
> > 2.14.1.windows.1
> 
> 
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-01-13  1:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-10 10:26 [PATCH 1/1] MdeModulePkg/SdMmcPciHcDxe: Fix unknown doxygen tag error Albecki, Mateusz
2020-01-13  1:09 ` Wu, Hao A
2020-01-13  1:26   ` [edk2-devel] " Wu, Hao A

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox