public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Vitaly Cheptsov" <vit9696@protonmail.com>
To: devel@edk2.groups.io
Subject: [PATCH 1/1] ShellPkg: Do not connect handles without device paths
Date: Sun, 12 Jan 2020 21:38:49 +0000	[thread overview]
Message-ID: <20200112213845.96853-2-vit9696@protonmail.com> (raw)
In-Reply-To: <20200112213845.96853-1-vit9696@protonmail.com>

[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2460

Doing this reduces the amount of needless work during device
connection and resolves issues with firmwares that freeze
when connecting handles without device paths.

Signed-off-by: Vitaly Cheptsov <vit9696@protonmail.com>
---
 ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c b/ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c
index b6e7c952fa..083aac0dba 100644
--- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c
+++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c
@@ -32,8 +32,8 @@ ConnectAllEfi (
   UINTN       Index;
 
   Status = gBS->LocateHandleBuffer (
-                  AllHandles,
-                  NULL,
+                  ByProtocol,
+                  &gEfiDevicePathProtocolGuid,
                   NULL,
                   &HandleCount,
                   &HandleBuffer
-- 
2.21.0 (Apple Git-122.2)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 489 bytes --]

  reply	other threads:[~2020-01-12 21:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-12 21:38 [PATCH 0/1] ShellPkg: Do not connect handles without device paths Vitaly Cheptsov
2020-01-12 21:38 ` Vitaly Cheptsov [this message]
2020-01-13  8:11   ` [edk2-devel] [PATCH 1/1] " Gao, Zhichao
2020-01-13  9:19     ` Vitaly Cheptsov
2020-01-13 11:56       ` Ni, Ray
2020-01-13 17:55         ` Laszlo Ersek
2020-01-13 20:46           ` Vitaly Cheptsov
2020-01-14  2:53             ` Ni, Ray
2020-01-14  8:36               ` Vitaly Cheptsov
2020-01-14 10:34                 ` Vitaly Cheptsov
2020-01-14 12:53                   ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200112213845.96853-2-vit9696@protonmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox