From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-40134.protonmail.ch (mail-40134.protonmail.ch [185.70.40.134]) by mx.groups.io with SMTP id smtpd.web10.28038.1578865138140981471 for ; Sun, 12 Jan 2020 13:38:59 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@protonmail.com header.s=default header.b=CMtHXwBp; spf=pass (domain: protonmail.com, ip: 185.70.40.134, mailfrom: vit9696@protonmail.com) Date: Sun, 12 Jan 2020 21:38:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=default; t=1578865134; bh=Yurlh2VbIjVPyujSVHZnumZRPWTyn+f7CvG7dew00uo=; h=Date:To:From:Reply-To:Subject:In-Reply-To:References:Feedback-ID: From; b=CMtHXwBpdeaGlNuw7AaehTbfsriRd+bJxCRcHOj/4HGF3xXv+NabHEqjqKkQgNFwm Sd65pK8/yXzUo1i4/7opiOMq3Qn2Uivkmy6YjlVx4X1dEeXtHgiB6iCNOvM9PIRnG/ 151VlTxkNJjmMNYp0d+TcQqDYbwiXoSM0w+pNDWI= To: devel@edk2.groups.io From: "Vitaly Cheptsov" Reply-To: Vitaly Cheptsov Subject: [PATCH 1/1] ShellPkg: Do not connect handles without device paths Message-ID: <20200112213845.96853-2-vit9696@protonmail.com> In-Reply-To: <20200112213845.96853-1-vit9696@protonmail.com> References: <20200112213845.96853-1-vit9696@protonmail.com> Feedback-ID: p9QuX-L1wMgUm6nrSvNrf8juLupNs0VSnzXGVXuYDxlEahFdWtaedWDMB9zpwGDklGt7kzs1-RBc0cqz327Gcg==:Ext:ProtonMail MIME-Version: 1.0 X-Spam-Status: No, score=3.3 required=7.0 tests=ALL_TRUSTED,BAYES_50, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,FREEMAIL_REPLYTO_END_DIGIT shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 X-Spam-Level: *** X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.protonmail.ch X-Groupsio-MsgNum: 53170 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha256; boundary="---------------------24d2cdfb310e37a22cbd59992c763e27"; charset=UTF-8 -----------------------24d2cdfb310e37a22cbd59992c763e27 Content-Transfer-Encoding: quoted-printable Date: Mon, 13 Jan 2020 00:38:45 +0300 From: Vitaly Cheptsov In-Reply-To: <20200112213845.96853-1-vit9696@protonmail.com> Message-Id: <20200112213845.96853-2-vit9696@protonmail.com> Mime-Version: 1.0 References: <20200112213845.96853-1-vit9696@protonmail.com> Subject: [PATCH 1/1] ShellPkg: Do not connect handles without device paths To: devel@edk2.groups.io X-Mailer: git-send-email 2.21.0 (Apple Git-122.2) REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2460 Doing this reduces the amount of needless work during device connection and resolves issues with firmwares that freeze when connecting handles without device paths. Signed-off-by: Vitaly Cheptsov --- ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c b/ShellPkg/= Library/UefiShellLevel2CommandsLib/Load.c index b6e7c952fa..083aac0dba 100644 --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c @@ -32,8 +32,8 @@ ConnectAllEfi ( UINTN Index; =20 Status =3D gBS->LocateHandleBuffer ( - AllHandles, - NULL, + ByProtocol, + &gEfiDevicePathProtocolGuid, NULL, &HandleCount, &HandleBuffer --=20 2.21.0 (Apple Git-122.2) -----------------------24d2cdfb310e37a22cbd59992c763e27 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: ProtonMail wsBmBAEBCAAQBQJeG5HoCRBPsoxt7Hy0xQAKCRBPsoxt7Hy0xV0VB/42eqzn TCGsJ2Sa61hSyO267J+wvL1wlxDhPu3paMLBpTurrMkcsbqkBEA2mvwmy9de aQurii4IGgyVGOIuNHSmjWpV1aaokq1sdmYkEpBFf4DZ3k8WSdkhAd1X+zNE Usbvw4kHFezqVE0jbGqesjPUsFOWmu7yEIMu8rm4QdURWhPbcGGxRFKnmhNF cl7QYC9WMdSkV6L5SqP4+Xwpca2C9i9qg6g1in+fYuDWk7P2xcFDu8diWoYu 3K7rh7xk2o68NhJupxIYvujee6Dt9SUyeDeX4g22/OVlFiuVTH7G6TRHWxdu T9lv6v9gSCkCvJQ2sXCe0K1wIzr0G90747Xs =tkkD -----END PGP SIGNATURE----- -----------------------24d2cdfb310e37a22cbd59992c763e27--