From: "Albecki, Mateusz" <mateusz.albecki@intel.com>
To: devel@edk2.groups.io
Cc: Mateusz Albecki <mateusz.albecki@intel.com>,
Hao A Wu <hao.a.wu@intel.com>, Marcin Wojtas <mw@semihalf.com>,
Zhichao Gao <zhichao.gao@intel.com>,
Liming Gao <liming.gao@intel.com>
Subject: [PATCHv2 0/4] MdeModulePkg/SdMmcPciHcDxe: Retry the commands that failed due to CRC error
Date: Tue, 14 Jan 2020 13:05:26 +0100 [thread overview]
Message-ID: <20200114120530.1660-1-mateusz.albecki@intel.com> (raw)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1140
Some of the boards report that just after we change the clock frequency to 200MHz link is unable to stabilize fast enough and when driver sends the CMD13 it will often fail randomly with CRC error. To protect against this kind of random failures this patch series will make the driver retry the commands that failed due to random CRC errors.
Since async code has not yet been tested it has been put into separate patch. That patch is not needed to solve most pressing CMD13 issues.
changes in v2:
-Split first patch into bugfix and refactor
-Normal interrupt status register will now only be read once during SdMmcCheckTrbResult
-We will no longer clear the data transfer timeout error in SdMmcCheckAndRecoverErrors. Instead we will immedieatly return for such case and register reset will be done in next SdMmcExecTrb
Tets performed:
-Boot eMMC in HS400
-Boot eMMC in HS400 with simulated CRC error on every first CMD13
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Marcin Wojtas <mw@semihalf.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Mateusz Albecki <mateusz.albecki@intel.com>
Mateusz Albecki (4):
MdeModulePkg/SdMmcPciHcDxe: Fix DAT lane SW reset
MdeModulePkg/SdMmcPciHcDxe: Refactor command error detection
MdeModulePkg/SdMmcPciHcDxe: Add retries for sync commands
MdeModulePkg/SdMmcPciHcDxe: Add retries for async commands
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 89 ++++++---
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 5 +-
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 218 ++++++++++++++-------
3 files changed, 204 insertions(+), 108 deletions(-)
--
2.14.1.windows.1
--------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.
next reply other threads:[~2020-01-14 12:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 12:05 Albecki, Mateusz [this message]
2020-01-14 12:05 ` [PATCHv2 1/4] MdeModulePkg/SdMmcPciHcDxe: Fix DAT lane SW reset Albecki, Mateusz
2020-01-14 12:05 ` [PATCHv2 2/4] MdeModulePkg/SdMmcPciHcDxe: Refactor command error detection Albecki, Mateusz
2020-01-14 12:05 ` [PATCHv2 3/4] MdeModulePkg/SdMmcPciHcDxe: Add retries for sync commands Albecki, Mateusz
2020-01-14 12:05 ` [PATCHv2 4/4] MdeModulePkg/SdMmcPciHcDxe: Add retries for async commands Albecki, Mateusz
2020-01-15 1:49 ` [edk2-devel] [PATCHv2 0/4] MdeModulePkg/SdMmcPciHcDxe: Retry the commands that failed due to CRC error Wu, Hao A
2020-01-19 2:04 ` Wu, Hao A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114120530.1660-1-mateusz.albecki@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox