public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] BaseTools:Fix tools_def.txt contains hard-coded path to mtoc
@ 2020-01-15 10:15 Lan-chinX Hsu
  0 siblings, 0 replies; 4+ messages in thread
From: Lan-chinX Hsu @ 2020-01-15 10:15 UTC (permalink / raw)
  To: devel; +Cc: Lan-chinX Hsu, Liming Gao

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2030

Change MTOC PATH to reference $PATH to find mtoc.

The Patch is going to fix this issue

Signed-off-by: Lan-chinX Hsu <lan-chinx.hsu@intel.com>

Cc: Liming Gao <liming.gao@intel.com>
---
 BaseTools/Conf/tools_def.template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
index feee2bbf16..39b8c2e7df 100755
--- a/BaseTools/Conf/tools_def.template
+++ b/BaseTools/Conf/tools_def.template
@@ -2853,7 +2853,7 @@ NOOPT_CLANGPDB_X64_DLINK2_FLAGS     =
 *_XCODE5_*_ASLPP_PATH    = clang
 *_XCODE5_*_ASLDLINK_PATH = ld
 *_XCODE5_*_DSYMUTIL_PATH = /usr/bin/dsymutil
-*_XCODE5_*_MTOC_PATH     = /usr/local/bin/mtoc
+*_XCODE5_*_MTOC_PATH     = mtoc
 *_XCODE5_*_DEPS_FLAGS    = DEF(GCC_DEPS_FLAGS)
 
 ##################
-- 
2.17.1.windows.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] BaseTools:Fix tools_def.txt contains hard-coded path to mtoc
@ 2020-01-15 10:39 Lan-chinX Hsu
  0 siblings, 0 replies; 4+ messages in thread
From: Lan-chinX Hsu @ 2020-01-15 10:39 UTC (permalink / raw)
  To: devel; +Cc: Lan-chinX Hsu, Liming Gao

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2030

Change MTOC PATH to reference $PATH to find mtoc.

The Patch is going to fix this issue

Signed-off-by: Lan-chinX Hsu <lan-chinx.hsu@intel.com>

Cc: Liming Gao <liming.gao@intel.com>
---
 BaseTools/Conf/tools_def.template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
index feee2bbf16..39b8c2e7df 100755
--- a/BaseTools/Conf/tools_def.template
+++ b/BaseTools/Conf/tools_def.template
@@ -2853,7 +2853,7 @@ NOOPT_CLANGPDB_X64_DLINK2_FLAGS     =
 *_XCODE5_*_ASLPP_PATH    = clang
 *_XCODE5_*_ASLDLINK_PATH = ld
 *_XCODE5_*_DSYMUTIL_PATH = /usr/bin/dsymutil
-*_XCODE5_*_MTOC_PATH     = /usr/local/bin/mtoc
+*_XCODE5_*_MTOC_PATH     = mtoc
 *_XCODE5_*_DEPS_FLAGS    = DEF(GCC_DEPS_FLAGS)
 
 ##################
-- 
2.17.1.windows.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] BaseTools:Fix tools_def.txt contains hard-coded path to mtoc
@ 2020-01-15 10:42 Lan-chinX Hsu
  2020-01-15 15:24 ` Liming Gao
  0 siblings, 1 reply; 4+ messages in thread
From: Lan-chinX Hsu @ 2020-01-15 10:42 UTC (permalink / raw)
  To: devel; +Cc: Lan-chinX Hsu, Liming Gao, Bob Feng

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2030

Change MTOC PATH to reference $PATH to find mtoc.

The Patch is going to fix this issue

Signed-off-by: Lan-chinX Hsu <lan-chinx.hsu@intel.com>

Cc: Liming Gao <liming.gao@intel.com>
Cc: Bob Feng <bob.c.feng@intel.com>
---
 BaseTools/Conf/tools_def.template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
index feee2bbf16..39b8c2e7df 100755
--- a/BaseTools/Conf/tools_def.template
+++ b/BaseTools/Conf/tools_def.template
@@ -2853,7 +2853,7 @@ NOOPT_CLANGPDB_X64_DLINK2_FLAGS     =
 *_XCODE5_*_ASLPP_PATH    = clang
 *_XCODE5_*_ASLDLINK_PATH = ld
 *_XCODE5_*_DSYMUTIL_PATH = /usr/bin/dsymutil
-*_XCODE5_*_MTOC_PATH     = /usr/local/bin/mtoc
+*_XCODE5_*_MTOC_PATH     = mtoc
 *_XCODE5_*_DEPS_FLAGS    = DEF(GCC_DEPS_FLAGS)
 
 ##################
-- 
2.25.0.windows.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] BaseTools:Fix tools_def.txt contains hard-coded path to mtoc
  2020-01-15 10:42 Lan-chinX Hsu
@ 2020-01-15 15:24 ` Liming Gao
  0 siblings, 0 replies; 4+ messages in thread
From: Liming Gao @ 2020-01-15 15:24 UTC (permalink / raw)
  To: Hsu, Lan-chinX, devel@edk2.groups.io; +Cc: Feng, Bob C

Hi, 
  DSYMUTIL path can be changed together.

Thanks
Liming
> -----Original Message-----
> From: Hsu, Lan-chinX <lan-chinx.hsu@intel.com>
> Sent: Wednesday, January 15, 2020 6:42 PM
> To: devel@edk2.groups.io
> Cc: Hsu, Lan-chinX <lan-chinx.hsu@intel.com>; Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
> Subject: [PATCH] BaseTools:Fix tools_def.txt contains hard-coded path to mtoc
> 
> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2030
> 
> Change MTOC PATH to reference $PATH to find mtoc.
> 
> The Patch is going to fix this issue
> 
> Signed-off-by: Lan-chinX Hsu <lan-chinx.hsu@intel.com>
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> ---
>  BaseTools/Conf/tools_def.template | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
> index feee2bbf16..39b8c2e7df 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -2853,7 +2853,7 @@ NOOPT_CLANGPDB_X64_DLINK2_FLAGS     =
>  *_XCODE5_*_ASLPP_PATH    = clang
> 
>  *_XCODE5_*_ASLDLINK_PATH = ld
> 
>  *_XCODE5_*_DSYMUTIL_PATH = /usr/bin/dsymutil
> 
> -*_XCODE5_*_MTOC_PATH     = /usr/local/bin/mtoc
> 
> +*_XCODE5_*_MTOC_PATH     = mtoc
> 
>  *_XCODE5_*_DEPS_FLAGS    = DEF(GCC_DEPS_FLAGS)
> 
> 
> 
>  ##################
> 
> --
> 2.25.0.windows.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-01-15 15:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-15 10:39 [PATCH] BaseTools:Fix tools_def.txt contains hard-coded path to mtoc Lan-chinX Hsu
  -- strict thread matches above, loose matches on Subject: below --
2020-01-15 10:42 Lan-chinX Hsu
2020-01-15 15:24 ` Liming Gao
2020-01-15 10:15 Lan-chinX Hsu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox