* [Patch] MdePkg Base.h: Use correct style to check the defined macro
@ 2020-01-16 3:48 Liming Gao
0 siblings, 0 replies; only message in thread
From: Liming Gao @ 2020-01-16 3:48 UTC (permalink / raw)
To: devel; +Cc: Zhiguang Liu
#if MACRO is not good style. It should be changed to
#ifdef MACRO style or #if defined (MACRO) style.
Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
---
MdePkg/Include/Base.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h
index e0bcd0ae67..321d729c04 100644
--- a/MdePkg/Include/Base.h
+++ b/MdePkg/Include/Base.h
@@ -195,7 +195,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
///
#define ASM_PFX(name) _CONCATENATE (__USER_LABEL_PREFIX__, name)
-#if __APPLE__
+#ifdef __APPLE__
//
// Apple extension that is used by the linker to optimize code size
// with assembly functions. Put at the end of your .S files
@@ -799,7 +799,7 @@ typedef UINTN *BASE_LIST;
**/
#ifdef MDE_CPU_EBC
#define STATIC_ASSERT(Expression, Message)
-#elif _MSC_EXTENSIONS
+#elif defined(_MSC_EXTENSIONS)
#define STATIC_ASSERT static_assert
#else
#define STATIC_ASSERT _Static_assert
--
2.24.1.windows.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-01-16 3:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-16 3:48 [Patch] MdePkg Base.h: Use correct style to check the defined macro Liming Gao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox