From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web12.3949.1579211731415043601 for ; Thu, 16 Jan 2020 13:55:31 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=aJj8Jd7K; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: leif.lindholm@linaro.org) Received: by mail-wr1-f66.google.com with SMTP id q6so20622056wro.9 for ; Thu, 16 Jan 2020 13:55:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=z4GX/soJm+P7OGINLzsTB5PRfiOjFZenUiwz5Z7bqiA=; b=aJj8Jd7Kt+OsF3/XgM3CiYYx+s9cmx+7MIOKgy+YyfxoxvdYrSddvVj7oKic/8xuXT VaLHzl6gP9oqhsCP7Kuiq5fZSakuB7QJItAolevqiczE6R/p5DetNLAelnXFXwNB6PKW 6C/M/E2NBet/jCeXYW9pV+VHDA0D0s4QiSWc9tUS/3fAtNPRErpZlQIUljsIZ0at7qry xS2fe3jUHokQyWwJ8HvuZCJzecRwSUrZoxo7NLIV82Co/G8FKEpBXpnL1PA2R8BWO/Ml lFqPzqLJH45P4DZzILWMh6me2D7TIlDOgRJG6EyxZkk/0pw4iC9AbVu7pD1bNfyVOKPy ZRFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=z4GX/soJm+P7OGINLzsTB5PRfiOjFZenUiwz5Z7bqiA=; b=HDbP3FXjGcn+qMccR/RSNbuOfskZAwfbsIQszfAPntY34MD8Y0axwG8izwMTO2tQ45 ki3sKD8+moRNh8SAoZXhbdJMd6pY3oDUtqnxQPMks7ygpM+9UVHm4dTan0kH0/tqNyTD qn3oeil4qncsPNsfgdwonNNE6hkpczIYXIKWzhz9QjvR3oDdNBFjgIfZZCgM1h3oRJDu LRDYkZKb0Bbx/Q+4cJ8F1n+4HfO0F7VlQAIfTcNknzr4pbwsDqEV05+evSFhw9GpCwPP vRSWgR2vKN3GnAQSJ07Y2AwiA8f6P8UwY+ASinxtcF6VG1Jy8CLQdi9RBAZ8Z4AHifAi wJ8w== X-Gm-Message-State: APjAAAXflZ3qyANBsjuWEDYDuzGr41BGZlVC/GzS14EDs2DYDyAv/DER 0Pr2LktmTX6F8sIRy2/4tw8e1RlfE28= X-Google-Smtp-Source: APXvYqwll0Ilia3iheohSoQb7aXO1mvUDHhZS6ZIa2ZicTsVE3lK7/fZrZgrpQ0W6ebCw9DnwC3mbQ== X-Received: by 2002:a05:6000:149:: with SMTP id r9mr5312554wrx.147.1579211730047; Thu, 16 Jan 2020 13:55:30 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id m10sm31081439wrx.19.2020.01.16.13.55.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2020 13:55:29 -0800 (PST) Date: Thu, 16 Jan 2020 21:55:28 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: devel@edk2.groups.io Subject: Re: [PATCH edk2-platforms] Silicon/AMD/StyxSpiFvDxe: declare missing GUID dependency Message-ID: <20200116215528.GH20629@bivouac.eciton.net> References: <20200115154401.12972-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20200115154401.12972-1-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jan 15, 2020 at 16:44:01 +0100, Ard Biesheuvel wrote: > StyxSpiFvDxe depends on gEfiEventVirtualAddressChangeGuid, but got > away with not declaring it in its INF because of a transitive > dependency. However, this dependency got dropped in core EDK2, > resulting in build failures of the Styx platform. > > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf b/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf > index bcc2306ec93d..54a2e4ea9da6 100644 > --- a/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf > +++ b/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf > @@ -35,6 +35,9 @@ > UefiRuntimeLib > DxeServicesTableLib > > +[Guids] > + gEfiEventVirtualAddressChangeGuid > + > [FixedPcd] > gArmTokenSpaceGuid.PcdFdBaseAddress > > -- > 2.20.1 >