* [PATCH edk2-platforms] Silicon/AMD/StyxSpiFvDxe: declare missing GUID dependency
@ 2020-01-15 15:44 Ard Biesheuvel
2020-01-16 21:55 ` Leif Lindholm
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2020-01-15 15:44 UTC (permalink / raw)
To: devel; +Cc: leif.lindholm, Ard Biesheuvel
StyxSpiFvDxe depends on gEfiEventVirtualAddressChangeGuid, but got
away with not declaring it in its INF because of a transitive
dependency. However, this dependency got dropped in core EDK2,
resulting in build failures of the Styx platform.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf b/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf
index bcc2306ec93d..54a2e4ea9da6 100644
--- a/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf
+++ b/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf
@@ -35,6 +35,9 @@
UefiRuntimeLib
DxeServicesTableLib
+[Guids]
+ gEfiEventVirtualAddressChangeGuid
+
[FixedPcd]
gArmTokenSpaceGuid.PcdFdBaseAddress
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH edk2-platforms] Silicon/AMD/StyxSpiFvDxe: declare missing GUID dependency
2020-01-15 15:44 [PATCH edk2-platforms] Silicon/AMD/StyxSpiFvDxe: declare missing GUID dependency Ard Biesheuvel
@ 2020-01-16 21:55 ` Leif Lindholm
2020-01-17 7:41 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2020-01-16 21:55 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: devel
On Wed, Jan 15, 2020 at 16:44:01 +0100, Ard Biesheuvel wrote:
> StyxSpiFvDxe depends on gEfiEventVirtualAddressChangeGuid, but got
> away with not declaring it in its INF because of a transitive
> dependency. However, this dependency got dropped in core EDK2,
> resulting in build failures of the Styx platform.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf b/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf
> index bcc2306ec93d..54a2e4ea9da6 100644
> --- a/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf
> +++ b/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf
> @@ -35,6 +35,9 @@
> UefiRuntimeLib
> DxeServicesTableLib
>
> +[Guids]
> + gEfiEventVirtualAddressChangeGuid
> +
> [FixedPcd]
> gArmTokenSpaceGuid.PcdFdBaseAddress
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH edk2-platforms] Silicon/AMD/StyxSpiFvDxe: declare missing GUID dependency
2020-01-16 21:55 ` Leif Lindholm
@ 2020-01-17 7:41 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2020-01-17 7:41 UTC (permalink / raw)
To: Leif Lindholm; +Cc: edk2-devel-groups-io
On Thu, 16 Jan 2020 at 22:55, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Wed, Jan 15, 2020 at 16:44:01 +0100, Ard Biesheuvel wrote:
> > StyxSpiFvDxe depends on gEfiEventVirtualAddressChangeGuid, but got
> > away with not declaring it in its INF because of a transitive
> > dependency. However, this dependency got dropped in core EDK2,
> > resulting in build failures of the Styx platform.
> >
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
Pushed, thanks.
> > ---
> > Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf b/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf
> > index bcc2306ec93d..54a2e4ea9da6 100644
> > --- a/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf
> > +++ b/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf
> > @@ -35,6 +35,9 @@
> > UefiRuntimeLib
> > DxeServicesTableLib
> >
> > +[Guids]
> > + gEfiEventVirtualAddressChangeGuid
> > +
> > [FixedPcd]
> > gArmTokenSpaceGuid.PcdFdBaseAddress
> >
> > --
> > 2.20.1
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-17 7:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-15 15:44 [PATCH edk2-platforms] Silicon/AMD/StyxSpiFvDxe: declare missing GUID dependency Ard Biesheuvel
2020-01-16 21:55 ` Leif Lindholm
2020-01-17 7:41 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox