From: Leif Lindholm <leif.lindholm@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: "Gao, Liming" <liming.gao@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Feng, Bob C" <bob.c.feng@intel.com>
Subject: Re: [PATCH] BaseTools/Conf/gitattributes: fix "--function-context" for *.h and *.c
Date: Fri, 17 Jan 2020 13:05:48 +0000 [thread overview]
Message-ID: <20200117130548.GK20629@bivouac.eciton.net> (raw)
In-Reply-To: <a99da3d0-b5d4-57ae-ef78-488d1f0d8978@redhat.com>
On Fri, Jan 17, 2020 at 09:30:49 +0100, Laszlo Ersek wrote:
> On 01/17/20 01:56, Gao, Liming wrote:
> > Leif:
> > .act is same to .aslc. There are no cases in open source.
>
> How about this then:
>
> *.[Aa][Cc][Tt] diff=cpp
> *.[Aa][Ss][Ll][Cc] diff=cpp
> *.[CcHh] diff=cpp
> *.[Cc][Cc] diff=cpp
> *.[Cc][Pp][Pp] diff=cpp
To be honest, I would rather just see them all listed explicitly.
The above actually adds capitalisation-combos not currently listed in
build_rules.template (like .CpP).
Given how abolutely trivial the fixup for anyone affected would be, I
think we should also start considering deprecating (with warning) and
finally retiring file endings not available in any public trees.
Clearly, that isn't something that needs fixing for this set :)
Best Regards,
Leif
next prev parent reply other threads:[~2020-01-17 13:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 18:49 [PATCH] BaseTools/Conf/gitattributes: fix "--function-context" for *.h and *.c Laszlo Ersek
2020-01-16 21:54 ` Leif Lindholm
2020-01-17 0:22 ` Liming Gao
2020-01-17 0:51 ` Leif Lindholm
2020-01-17 0:56 ` Liming Gao
2020-01-17 8:30 ` Laszlo Ersek
2020-01-17 13:05 ` Leif Lindholm [this message]
2020-01-17 18:09 ` Laszlo Ersek
2020-01-17 19:37 ` Leif Lindholm
2020-01-19 1:47 ` Liming Gao
2020-01-17 8:24 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117130548.GK20629@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox