From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.groups.io with SMTP id smtpd.web11.6199.1579266353063073051 for ; Fri, 17 Jan 2020 05:05:53 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=uxwU9zZP; spf=pass (domain: linaro.org, ip: 209.85.221.65, mailfrom: leif.lindholm@linaro.org) Received: by mail-wr1-f65.google.com with SMTP id q6so22562842wro.9 for ; Fri, 17 Jan 2020 05:05:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=67ZMiR/y+Kiugq+mSrbL0zhExxUMPofzxWG/bla/n2M=; b=uxwU9zZPvf/crByaRV77RYZdVS35xRL9Ug6aFRMPkBYKyFSQZGfuV3hOy0NbnK8KkX 5rLroIfYIFjr5Cp9rhWORvJhpRINw2gmhIU14rVHcOEFkaMuLI+AGDBRaGt8zgjUWtfn mkRoCs+2PWgSUdK8y6IZgflYFxGK9XpQyb9rkDMF7Mx1ZwdBgJuOc+9NW6Z0FZvIUn7h j2MGNIaCmyBpKldXU6ApNtXHukBdEcGG31lY5VE+1J41xWEvewQ1TiLKWpsTzADFJs7m Qbm0GUi0rzb039yXeon+6ya186xnjIBIXouq7oN5JzYNRnO6j9xqe4vWQE/gg+8Ex2Nx +MtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=67ZMiR/y+Kiugq+mSrbL0zhExxUMPofzxWG/bla/n2M=; b=Y4Q/ismMfpOd8AEtjbSyxgxrbC//jR8+ohhhtj/qiD0GvZp+65JpInHV6m2VGydC8H iQyhk33wMjSG1DO6MwdgYtLVT3rp80o+fHIIm8xOE98EUOBOR5FlE6DYW7oM74UmNGs5 NJWnNlZWCqr6T3xhCae3TWZ1weggEa7jZmSZw0NEKlM+uy4UpUzqNVE0ICGfzcTP2eoA 1RS1lPVS6vSaPrgGpc6IxYwP706iFm9joz5QDTewOu8ielF7qcisI0AhmrhZ9FutAi6P 9RoEvpePFVRlK6pmaKcTbQBKBPvG5Jz2Dvu/2A4hfLhcTd+vPcP5zLCxMnjw8TMLzhuv fegQ== X-Gm-Message-State: APjAAAW2pyzHaNtYPWgVEsRsTykxWt//lr1HGmYzwopoEYdJW7Z5VAh0 hEvB9Csc7+aGH1jR3TDkoc1t9A== X-Google-Smtp-Source: APXvYqxdIMqNvnZuw7wEnZmOID1S99qTqrehq8J2+kQSkTlx6/AxBHK8OFQdlsDg3dKX3RMrwJ0RwQ== X-Received: by 2002:a5d:6408:: with SMTP id z8mr2980334wru.122.1579266351597; Fri, 17 Jan 2020 05:05:51 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id z6sm33574805wrw.36.2020.01.17.05.05.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2020 05:05:50 -0800 (PST) Date: Fri, 17 Jan 2020 13:05:48 +0000 From: Leif Lindholm To: Laszlo Ersek Cc: "Gao, Liming" , "devel@edk2.groups.io" , "Feng, Bob C" Subject: Re: [PATCH] BaseTools/Conf/gitattributes: fix "--function-context" for *.h and *.c Message-ID: <20200117130548.GK20629@bivouac.eciton.net> References: <20200116184929.18020-1-lersek@redhat.com> <20200116215459.GG20629@bivouac.eciton.net> <428016653b214ab699ec2d6b4ecf2fc9@intel.com> <20200117005102.GJ20629@bivouac.eciton.net> <1529165fc50e49e3abdf073f079c1efd@intel.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 17, 2020 at 09:30:49 +0100, Laszlo Ersek wrote: > On 01/17/20 01:56, Gao, Liming wrote: > > Leif: > > .act is same to .aslc. There are no cases in open source. > > How about this then: > > *.[Aa][Cc][Tt] diff=cpp > *.[Aa][Ss][Ll][Cc] diff=cpp > *.[CcHh] diff=cpp > *.[Cc][Cc] diff=cpp > *.[Cc][Pp][Pp] diff=cpp To be honest, I would rather just see them all listed explicitly. The above actually adds capitalisation-combos not currently listed in build_rules.template (like .CpP). Given how abolutely trivial the fixup for anyone affected would be, I think we should also start considering deprecating (with warning) and finally retiring file endings not available in any public trees. Clearly, that isn't something that needs fixing for this set :) Best Regards, Leif