public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: devel@edk2.groups.io
Subject: Re: [PATCH edk2-platforms] Silicon/SynQuacer/NetsecDxe: ignore DMA coherency at binding time
Date: Fri, 17 Jan 2020 13:07:00 +0000	[thread overview]
Message-ID: <20200117130659.GL20629@bivouac.eciton.net> (raw)
In-Reply-To: <20200117111651.10740-1-ard.biesheuvel@linaro.org>

On Fri, Jan 17, 2020 at 12:16:51 +0100, Ard Biesheuvel wrote:
> Whether the Netsec driver is built to support coherent or non-coherent
> DMA is decided by the DmaLib library class resolution that is provided
> by the platform description, and there are various other places where
> the platform needs to be consistent with this (ACPI tables, device
> tree, platform driver, etc)
> 
> Since the driver has no way to figure out which flavor of DmaLib it was
> built against, there is no point in limiting it to one flavor only, and
> we can drop the DmaType check at binding time entirely.
> 
> This fixes an issue introduced by commit 88c7874481b856578662b775
> ("Silicon/SynQuacer/PlatformDxe: set NETSEC DMA as coherent"), which
> incorrectly stated that the driver does not look at the DmaType flag
> in the first place.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> ---
>  Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/DriverBinding.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/DriverBinding.c b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/DriverBinding.c
> index 9820585e0dd5..392d1b474f5e 100644
> --- a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/DriverBinding.c
> +++ b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/DriverBinding.c
> @@ -52,8 +52,7 @@ NetsecDriverBindingSupported (
>      return Status;
>    }
>  
> -  if (CompareGuid (Dev->Type, &gNetsecNonDiscoverableDeviceGuid) &&
> -      Dev->DmaType == NonDiscoverableDeviceDmaTypeNonCoherent) {
> +  if (CompareGuid (Dev->Type, &gNetsecNonDiscoverableDeviceGuid)) {
>      Status = EFI_SUCCESS;
>    } else {
>      Status = EFI_UNSUPPORTED;
> -- 
> 2.20.1
> 

  reply	other threads:[~2020-01-17 13:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-17 11:16 [PATCH edk2-platforms] Silicon/SynQuacer/NetsecDxe: ignore DMA coherency at binding time Ard Biesheuvel
2020-01-17 13:07 ` Leif Lindholm [this message]
2020-01-17 14:54   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200117130659.GL20629@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox