From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68])
 by mx.groups.io with SMTP id smtpd.web09.899.1579289830880194356
 for <devel@edk2.groups.io>;
 Fri, 17 Jan 2020 11:37:11 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=Ri4NDadH;
 spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: leif.lindholm@linaro.org)
Received: by mail-wr1-f68.google.com with SMTP id g17so23805210wro.2
        for <devel@edk2.groups.io>; Fri, 17 Jan 2020 11:37:10 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=xEA6cXYi9mH9qIq/gAcukjw0T+mWvyakZNXm8YHLw34=;
        b=Ri4NDadH9LiQeYajgTdBJeMf6bIjbERdJ7b/7/lkZPYQ+3mVUzUvX/aUQYMpgikNn5
         EJaPIjYroG6OD7dYp8WirhITyxQaIw1iukUcRAuVXC9FlrwwOLgHwm57MVKuWDNR24AC
         dwOtuSyzvUgnWEYQ7jYw6XCM5WYJ7jimPWlEvlj1X4G40BY0eha92j748HJVFcGtDMlR
         tyeDJR6n01/22nuXFOOShRHlbioykuNzWjxznPQZ7xyV5sYEUB+N7XMg9WltR7JuqF6o
         or/944h8v6TNU8xRXGiT1KRkGHCmNOlM4YZ0Y+mn6qrESYXB7yUvZgRm6nl4e+sUFWs6
         KFiw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=xEA6cXYi9mH9qIq/gAcukjw0T+mWvyakZNXm8YHLw34=;
        b=d5s9t7pn/J+TocDoxQ+Tkw2x6r1Xb9x/Gy7wZnRIksUqq3jKAJYvLWTpR4xRyMoEGq
         dAoyBhDO4EHGXFEvsveUEvMczWgfgSJlUa7qUmlAYv3E+KWVsDA+0lpivxbWYrrLaMuh
         arMsMxzoO4tElc4rpWrjl31zigz8dKsE9w5YBvyQMrqTBDWuDDYomoL/IMINbMiyJBS4
         irRppsBG827XFEumzMf4O2qF6gzkQll0Sx7MS+VzikigjTJZqIKLC1cMoq3jWOR457H6
         R4eeeQH7QY4pco86ay7St7VqXqoc8fsP6YwNezsbRopzcdlanMG/jYSVHDSjEVQwgyxk
         9d5A==
X-Gm-Message-State: APjAAAWNomR05gCF51yCOf40Nyi7WaImfzInjXkjCOXyMCIQnephVWeP
	YtvpzfmKiF36vdMdJqzysQET4Q==
X-Google-Smtp-Source: APXvYqwJnd/5GAGRHeB0H9kBsyEtuINN597/S3WMxiQoSkRSAMpmLU6dSszhg73/J0KTn4qg7+bqeA==
X-Received: by 2002:adf:fc03:: with SMTP id i3mr4908268wrr.306.1579289829324;
        Fri, 17 Jan 2020 11:37:09 -0800 (PST)
Return-Path: <leif.lindholm@linaro.org>
Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2])
        by smtp.gmail.com with ESMTPSA id m7sm974974wma.39.2020.01.17.11.37.08
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Fri, 17 Jan 2020 11:37:08 -0800 (PST)
Date: Fri, 17 Jan 2020 19:37:06 +0000
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: "Gao, Liming" <liming.gao@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Feng, Bob C" <bob.c.feng@intel.com>
Subject: Re: [PATCH] BaseTools/Conf/gitattributes: fix "--function-context" for *.h and *.c
Message-ID: <20200117193706.GM20629@bivouac.eciton.net>
References: <20200116184929.18020-1-lersek@redhat.com>
 <20200116215459.GG20629@bivouac.eciton.net>
 <428016653b214ab699ec2d6b4ecf2fc9@intel.com>
 <20200117005102.GJ20629@bivouac.eciton.net>
 <1529165fc50e49e3abdf073f079c1efd@intel.com>
 <a99da3d0-b5d4-57ae-ef78-488d1f0d8978@redhat.com>
 <20200117130548.GK20629@bivouac.eciton.net>
 <a39f54a7-6007-697f-2b5a-ec4d6e6fc64a@redhat.com>
MIME-Version: 1.0
In-Reply-To: <a39f54a7-6007-697f-2b5a-ec4d6e6fc64a@redhat.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi Laszlo,

On Fri, Jan 17, 2020 at 19:09:22 +0100, Laszlo Ersek wrote:
> On 01/17/20 14:05, Leif Lindholm wrote:
> > On Fri, Jan 17, 2020 at 09:30:49 +0100, Laszlo Ersek wrote:
> >> On 01/17/20 01:56, Gao, Liming wrote:
> >>> Leif:
> >>>   .act is same to .aslc. There are no cases in open source. 
> >>
> >> How about this then:
> >>
> >> *.[Aa][Cc][Tt]     diff=cpp
> >> *.[Aa][Ss][Ll][Cc] diff=cpp
> >> *.[CcHh]           diff=cpp
> >> *.[Cc][Cc]         diff=cpp
> >> *.[Cc][Pp][Pp]     diff=cpp
> > 
> > To be honest, I would rather just see them all listed explicitly.
> > The above actually adds capitalisation-combos not currently listed in
> > build_rules.template (like .CpP).
> 
> I agree .CpP is non-intuitive, but you previously quoted .Cpp from
> "BaseTools/Conf/build_rule.template", which is just as non-intuitive to
> me. Who'd *capitalize* a file suffix? (I'd understand *all*-caps.)

I agree, I just included everything explicitly listed today.

> So anyway: you suggest to copy the file suffix list verbatim from the
> [C-Code-File] and [Acpi-Table-Code-File] sections in
> "BaseTools/Conf/build_rule.template". Plus, on top of those, *.h and
> *.H. Correct?

Yes please.

Best Regards,

Leif