From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.7195.1580739549421278112 for ; Mon, 03 Feb 2020 06:19:09 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: mateusz.albecki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Feb 2020 06:19:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,398,1574150400"; d="scan'208";a="263433925" Received: from gklab-27-32.ger.corp.intel.com ([10.102.28.45]) by fmsmga002.fm.intel.com with ESMTP; 03 Feb 2020 06:19:05 -0800 From: "Albecki, Mateusz" To: devel@edk2.groups.io Cc: Mateusz Albecki , Hao A Wu , Marcin Wojtas , Zhichao Gao , Liming Gao Subject: [PATCH 0/4] MdeModulePkg/SdMmcPciHcDxe: Refactor command processing Date: Mon, 3 Feb 2020 15:18:54 +0100 Message-Id: <20200203141858.3236-1-mateusz.albecki@intel.com> X-Mailer: git-send-email 2.14.1.windows.1 This patch series aims to refactor command processing to achieve following 1. Trace the failing TRB packets to see what commands are failing and for what reasons 2. Get the response data even if data transfer timed out to allow easier debugging 3. Fix the PIO mode which is currently completely broken. Tests performed: 1. Each patch in the series has passed boot from eMMC with ADMAv3 data transfer mode 2. SDMA based boot has been tested with the full patch series 3. PIO based boot has been tested with the full patch series 4. PIO based data transfer has been additionally tested by creating and modyfing a file in EFI shell All tests were performed with eMMC in HS400 @200MHz clock frequency. For easier review & integration patch has been pushed here: Whole series: https://github.com/malbecki/edk2/tree/emmc_transfer_refactor Whole series + SDMA force code(test 3): https://github.com/malbecki/edk2/tree/emmc_transfer_refactor_force_sdma Whole series + PIO force code(test 4): https://github.com/malbecki/edk2/tree/emmc_transfer_refactor_force_pio Cc: Hao A Wu Cc: Marcin Wojtas Cc: Zhichao Gao Cc: Liming Gao Mateusz Albecki (4): MdeModulePkg/SdMmcPciHcDxe: Enhance driver traces MdeModulePkg/SdMmcPciHcDxe: Read response on command completion MdeModulePkg/SdMmcPciHcDxe: Refactor data transfer completion MdeModulePkg/SdMmcPciHcDxe: Fix PIO transfer mode MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 4 + MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 502 ++++++++++++++++----- 2 files changed, 398 insertions(+), 108 deletions(-) -- 2.14.1.windows.1 -------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.