From: "Anthony PERARD" <anthony.perard@citrix.com>
To: "Gao, Liming" <liming.gao@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
Julien Grall <julien@xen.org>,
"Feng, Bob C" <bob.c.feng@intel.com>
Subject: Re: [PATCH 2/5] MdePkg: Allow PcdFSBClock to by Dynamic
Date: Mon, 3 Feb 2020 15:34:07 +0000 [thread overview]
Message-ID: <20200203153407.GH2306@perard.uk.xensource.com> (raw)
In-Reply-To: <c283b839b42e4262bfde10474bf6a794@intel.com>
On Mon, Feb 03, 2020 at 01:34:55AM +0000, Gao, Liming wrote:
> Anthony:
> This change is OK to me. But if this PCD is configured as Dynamic, its value will be got from PCD service. This operation will take some time and cause the inaccurate time delay. Have you measured its impact?
No, I haven't. But I don't think it matter in a Xen guest, the APIC timer is
emulated anyway, so reading from a register of the APIC is going to be
slower than getting the value from the PCD services, I think.
(Hopefully, I'm not too wrong.)
But I'll give it at measuring the difference, it would be interesting to
know.
Thanks,
--
Anthony PERARD
next prev parent reply other threads:[~2020-02-03 15:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 12:12 [PATCH 0/5] OvmfXen: Set PcdFSBClock at runtime Anthony PERARD
2020-01-29 12:12 ` [PATCH 1/5] OvmfPkg/XenResetVector: Silent a warning from nasm Anthony PERARD
2020-01-29 16:08 ` Laszlo Ersek
2020-01-29 12:12 ` [PATCH 2/5] MdePkg: Allow PcdFSBClock to by Dynamic Anthony PERARD
2020-01-29 16:10 ` Laszlo Ersek
2020-02-03 1:34 ` Liming Gao
2020-02-03 15:34 ` Anthony PERARD [this message]
2020-02-03 17:26 ` Anthony PERARD
2020-02-04 6:49 ` [edk2-devel] " Liming Gao
2020-01-29 12:12 ` [PATCH 3/5] OvmfPkg/IndustryStandard/Xen: Apply EDK2 coding style to XEN_VCPU_TIME_INFO Anthony PERARD
2020-01-29 16:14 ` Laszlo Ersek
2020-01-30 10:31 ` Anthony PERARD
2020-01-29 12:12 ` [PATCH 4/5] OvmfPkg/XenPlatformPei: Calibrate APIC timer frequency Anthony PERARD
2020-01-29 16:29 ` Laszlo Ersek
2020-01-30 9:12 ` Roger Pau Monné
2020-01-30 12:44 ` Anthony PERARD
2020-01-30 13:10 ` [Xen-devel] " Andrew Cooper
2020-01-29 12:12 ` [PATCH 5/5] OvmfPkg/OvmfXen: Set PcdFSBClock Anthony PERARD
2020-01-29 16:36 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203153407.GH2306@perard.uk.xensource.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox