From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web09.1505.1580856579050040799 for ; Tue, 04 Feb 2020 14:49:39 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=T4u/mvQC; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580856578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kNXJzIlS/LMs/aeQW3YKkmWF2yvTKjf/5R0cvxpBBb0=; b=T4u/mvQC3OAsi3YqJmuyn1YokB1JN6dWDAYeABuPR/xxDKeG8teA2dG+6dq6kACauVGFrA 7jUWrTqQ5x4FhtZZAXQDom9dRTFnKX18o5v7kT5yD+5HWjtWLlS92cxnnCFj0XfiRq9y8Y NkFsCPbXSMC7O6x5UnZMYzmvnb4Dr0s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-136-hegVuM0oPHiauR0L7s7RRg-1; Tue, 04 Feb 2020 17:49:31 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9BD19A0CC1; Tue, 4 Feb 2020 22:49:30 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-152.brq.redhat.com [10.40.204.152]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BB6AF7FB79; Tue, 4 Feb 2020 22:49:28 +0000 (UTC) From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= To: devel@edk2.groups.io Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Bob Feng , Liming Gao Subject: [PATCH 2/3] BaseTools/Scripts/PatchCheck.py: Detect emails rewritten by Groups.Io Date: Tue, 4 Feb 2020 23:49:15 +0100 Message-Id: <20200204224916.11320-3-philmd@redhat.com> In-Reply-To: <20200204224916.11320-1-philmd@redhat.com> References: <20200204224916.11320-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: hegVuM0oPHiauR0L7s7RRg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Philippe Mathieu-Daud=C3=A9 Due to strict DMARC / DKIM / SPF rules, Groups.Io sometimes rewrite the author email. See for example commit df851da3ceff5b6bcf5e12616. Add a check to detect these rewrites with PatchCheck.py. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Philippe Mathieu-Daude --- BaseTools/Scripts/PatchCheck.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck= .py index 07881abaf64e..13da6967785d 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -79,6 +79,10 @@ class EmailAddressCheck: self.error("The email address cannot contain a space: " + mo.group(3)) =20 + if ' via Groups.Io' in name and mo.group(3).endswith('@groups.io')= : + self.error("Email rewritten by lists DMARC / DKIM / SPF: " + + email) + class CommitMessageCheck: """Checks the contents of a git commit message.""" =20 --=20 2.21.1