From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web10.7114.1581041543382557531 for ; Thu, 06 Feb 2020 18:12:23 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=S0hKFJI1; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581041542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1Wd7Ib3JP2tdmPXzKsU4BebJnr89D1Bs6Ke3Dau5Mqk=; b=S0hKFJI1JTShf75jTK/ZLY/zByBmnn1U817eFg8LRZDWfZKcQjrdF6omy+wPWPvlEqieXf 4IYRaqa1pFTFOO7vLJftS5nHff9kGcA6YJNMxfYPEVSQ3BxXbowbAT0hHQtMG0sKdCTLsV 0FSqGJnhkBgKOi5jR/ZRcrGa2t1OrRg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-101-ARgHpMLxOGSdjlWm2GOQXg-1; Thu, 06 Feb 2020 21:12:18 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 355FC101FC62; Fri, 7 Feb 2020 02:12:17 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-120.brq.redhat.com [10.40.204.120]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2589560BEC; Fri, 7 Feb 2020 02:12:13 +0000 (UTC) From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= To: devel@edk2.groups.io Cc: Laszlo Ersek , Eric Dong Subject: [PATCH v3 71/78] SourceLevelDebugPkg/DebugAgent: Fix various typos Date: Fri, 7 Feb 2020 02:08:24 +0100 Message-Id: <20200207010831.9046-72-philmd@redhat.com> In-Reply-To: <20200207010831.9046-1-philmd@redhat.com> References: <20200207010831.9046-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: ARgHpMLxOGSdjlWm2GOQXg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Antoine Coeur Fix various typos in documentation, comments and debug strings. Cc: Hao A Wu Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Hao A Wu Signed-off-by: Philippe Mathieu-Daude --- .../DebugAgent/DebugAgentCommon/DebugMp.h | 6 +-- .../DebugAgentCommon/Ia32/ArchDebugSupport.h | 2 +- .../DebugAgentCommon/Ia32/DebugException.h | 2 +- .../DebugAgentCommon/X64/ArchDebugSupport.h | 2 +- .../DebugAgentCommon/X64/DebugException.h | 2 +- .../DebugAgentDxe/DebugAgentDxe.c | 2 +- .../DebugAgentPei/DebugAgentPei.c | 2 +- .../DebugAgent/DebugAgentCommon/DebugAgent.c | 52 +++++++++---------- .../DxeDebugAgent/DxeDebugAgentLib.c | 2 +- .../DebugAgent/DxeDebugAgent/SerialIo.c | 6 +-- .../SecPeiDebugAgent/SecPeiDebugAgentLib.c | 10 ++-- .../SmmDebugAgent/SmmDebugAgentLib.c | 10 ++-- .../DebugAgentCommon/Ia32/AsmFuncs.nasm | 4 +- 13 files changed, 51 insertions(+), 51 deletions(-) diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugM= p.h b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h index 71d7802d1548..07ddccad335d 100644 --- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h +++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h @@ -17,7 +17,7 @@ typedef struct { } DEBUG_CPU_DATA; =20 typedef struct { - SPIN_LOCK MpContextSpinLock; ///< Lock for writting MP= context + SPIN_LOCK MpContextSpinLock; ///< Lock for writing MP = context SPIN_LOCK DebugPortSpinLock; ///< Lock for access debu= g port SPIN_LOCK MailboxSpinLock; ///< Lock for accessing m= ail box UINT8 CpuBreakMask[DEBUG_CPU_MAX_COUNT/8]; //= /< Bitmask of all breaking CPUs @@ -26,8 +26,8 @@ typedef struct { UINT32 BspIndex; ///< Processor index valu= e of BSP UINT32 BreakAtCpuIndex; ///< Processor index valu= e of the current breaking CPU UINT32 DebugTimerInitCount; ///< Record BSP's init ti= mer count - BOOLEAN IpiSentByAp; ///< TRUR: IPI is sent by= AP. TALSE: IPI is sent by BSP - BOOLEAN RunCommandSet; ///< TRUE: RUN commmand i= s executing. FALSE : RUN command has been executed. + BOOLEAN IpiSentByAp; ///< TRUE: IPI is sent by= AP. FALSE: IPI is sent by BSP + BOOLEAN RunCommandSet; ///< TRUE: RUN command is= executing. FALSE: RUN command has been executed. } DEBUG_MP_CONTEXT; =20 extern DEBUG_MP_CONTEXT volatile mDebugMpContext; diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/A= rchDebugSupport.h b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon= /Ia32/ArchDebugSupport.h index d816bdaecdbe..3acb0352bf76 100644 --- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/ArchDebu= gSupport.h +++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/ArchDebu= gSupport.h @@ -1,5 +1,5 @@ /** @file - IA32 specific defintions for debug agent library instance. + IA32 specific definitions for debug agent library instance. =20 Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/D= ebugException.h b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/I= a32/DebugException.h index 750b3e4724eb..9147fabe6c3e 100644 --- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/DebugExc= eption.h +++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/DebugExc= eption.h @@ -1,5 +1,5 @@ /** @file - Exception defintions. + Exception definitions. =20 Copyright (c) 2010, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/Ar= chDebugSupport.h b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/= X64/ArchDebugSupport.h index 4ee12b771e9c..1e45941a9927 100644 --- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/ArchDebug= Support.h +++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/ArchDebug= Support.h @@ -1,5 +1,5 @@ /** @file - X64 specific defintions for debug agent library instance. + X64 specific definitions for debug agent library instance. =20 Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/De= bugException.h b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X6= 4/DebugException.h index 750b3e4724eb..9147fabe6c3e 100644 --- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/DebugExce= ption.h +++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/DebugExce= ption.h @@ -1,5 +1,5 @@ /** @file - Exception defintions. + Exception definitions. =20 Copyright (c) 2010, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent diff --git a/SourceLevelDebugPkg/DebugAgentDxe/DebugAgentDxe.c b/SourceLeve= lDebugPkg/DebugAgentDxe/DebugAgentDxe.c index 7ed4edb810a1..33fc9f3646dc 100644 --- a/SourceLevelDebugPkg/DebugAgentDxe/DebugAgentDxe.c +++ b/SourceLevelDebugPkg/DebugAgentDxe/DebugAgentDxe.c @@ -41,7 +41,7 @@ DisableDebugTimerExitBootService ( @param[in] SystemTable A pointer to the EFI System Table. =20 @retval EFI_SUCCESS The entry point is executed successfully. - @retval other Some error occurs when initialzed Debug Agent. + @retval other Some error occurs when initialized Debug Agent= . =20 **/ EFI_STATUS diff --git a/SourceLevelDebugPkg/DebugAgentPei/DebugAgentPei.c b/SourceLeve= lDebugPkg/DebugAgentPei/DebugAgentPei.c index 4ef1945cd88e..fc2a8f75abf7 100644 --- a/SourceLevelDebugPkg/DebugAgentPei/DebugAgentPei.c +++ b/SourceLevelDebugPkg/DebugAgentPei/DebugAgentPei.c @@ -21,7 +21,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent @param[in] PeiServices Pointer to PEI Services Table =20 @retval EFI_SUCCESS Debug Agent successfully initialized. - @retval other Some error occurs when initialzed Debug Agent. + @retval other Some error occurs when initialized Debug Agent. =20 **/ EFI_STATUS diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugA= gent.c b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent= .c index 3ab4a81589c8..8021437ca903 100644 --- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c +++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c @@ -1,5 +1,5 @@ /** @file - Commond Debug Agent library implementition. It mainly includes + Commond Debug Agent library implementation. It mainly includes the first C function called by exception/interrupt handlers, read/write debug packet to communication with HOST based on transfer protocol. @@ -594,7 +594,7 @@ DebugAgentDataMsgPrint ( Index ++; if (Index >=3D Length) { // - // The last character of debug message has been foramtted in buffer + // The last character of debug message has been formatted in buffer // DestBuffer +=3D AsciiSPrint(DestBuffer, DEBUG_DATA_MAXIMUM_REAL_DATA= - (DestBuffer - Buffer), "]\n"); SendDebugMsgPacket (Buffer, DestBuffer - Buffer); @@ -723,7 +723,7 @@ SetDebugSetting ( } =20 /** - Exectue GO command. + Execute GO command. =20 @param[in] CpuContext Pointer to saved CPU context. =20 @@ -1081,12 +1081,12 @@ DecompressDataInPlace ( @param[out] IncompatibilityFlag If IncompatibilityFlag is not NULL, retu= rn TRUE: Compatible packet received. FALSE: Incompatible packet received. - @param[in] Timeout Time out value to wait for acknowlege fr= om HOST. + @param[in] Timeout Time out value to wait for acknowledge f= rom HOST. The unit is microsecond. @param[in] SkipStartSymbol TRUE: Skip time out when reading start = symbol. FALSE: Does not Skip time out when readi= ng start symbol. =20 - @retval RETURN_SUCCESS A valid package was reveived in InputPacket. + @retval RETURN_SUCCESS A valid package was received in InputPacket. @retval RETURN_TIMEOUT Timeout occurs. =20 **/ @@ -1190,17 +1190,17 @@ ReceivePacket ( Receive acknowledge packet OK from HOST in specified time. =20 @param[in] Command The command type issued by TARGET. - @param[in] Timeout Time out value to wait for acknowlege fr= om HOST. + @param[in] Timeout Time out value to wait for acknowledge f= rom HOST. The unit is microsecond. @param[out] BreakReceived If BreakReceived is not NULL, - TRUE is retured if break-in symbol recei= ved. - FALSE is retured if break-in symbol not = received. + TRUE is returned if break-in symbol rece= ived. + FALSE is returned if break-in symbol not= received. @param[out] IncompatibilityFlag If IncompatibilityFlag is not NULL, retu= rn TRUE: Compatible packet received. FALSE: Incompatible packet received. =20 - @retval RETRUEN_SUCCESS Succeed to receive acknowlege packet from HOST= , - the type of acknowlege packet saved in Ack. + @retval RETURN_SUCCESS Succeed to receive acknowledge packet from HOS= T, + the type of acknowledge packet saved in Ack. @retval RETURN_TIMEOUT Specified timeout value was up. =20 **/ @@ -1497,7 +1497,7 @@ CompressData ( } =20 /** - Read memory with speicifed width and send packet with response data to H= OST. + Read memory with specified width and send packet with response data to H= OST. =20 @param[in] Data Pointer to response data buffer. @param[in] Count The number of data with specified Width. @@ -1669,16 +1669,16 @@ SendDataResponsePacket ( Try to attach the HOST. =20 Send init break packet to HOST: - If no acknowlege received in specified Timeout, return RETURN_TIMEOUT. - If received acknowlege, check the revision of HOST. + If no acknowledge received in specified Timeout, return RETURN_TIMEOUT. + If received acknowledge, check the revision of HOST. Set Attach Flag if attach successfully. =20 @param[in] BreakCause Break cause of this break event. - @param[in] Timeout Time out value to wait for acknowlege from HO= ST. + @param[in] Timeout Time out value to wait for acknowledge from H= OST. The unit is microsecond. @param[out] BreakReceived If BreakReceived is not NULL, - TRUE is retured if break-in symbol received. - FALSE is retured if break-in symbol not recei= ved. + TRUE is returned if break-in symbol received. + FALSE is returned if break-in symbol not rece= ived. **/ RETURN_STATUS AttachHost ( @@ -1732,8 +1732,8 @@ AttachHost ( @param[in] BreakCause Break cause of this break event. @param[in] ProcessorIndex Processor index value. @param[out] BreakReceived If BreakReceived is not NULL, - TRUE is retured if break-in symbol received. - FALSE is retured if break-in symbol not recei= ved. + TRUE is returned if break-in symbol received. + FALSE is returned if break-in symbol not rece= ived. =20 **/ VOID @@ -1777,7 +1777,7 @@ SendBreakPacketToHost ( =20 It received the command packet from HOST, and sent response data packet = to HOST. =20 - @param[in] Vector Vector value of exception or interrutp. + @param[in] Vector Vector value of exception or interrupt. @param[in, out] CpuContext Pointer to saved CPU context. @param[in] BreakReceived TRUE means break-in symbol received. FALSE means break-in symbol not received. @@ -1881,20 +1881,20 @@ CommandCommunication ( =20 Mailbox =3D GetMailboxPointer (); if (DebugHeader->SequenceNo =3D=3D Mailbox->HostSequenceNo) { - DebugAgentMsgPrint (DEBUG_AGENT_WARNING, "TARGET: Receive one old co= mmand[%x] agaist command[%x]\n", DebugHeader->SequenceNo, Mailbox->HostSequ= enceNo); + DebugAgentMsgPrint (DEBUG_AGENT_WARNING, "TARGET: Receive one old co= mmand[%x] against command[%x]\n", DebugHeader->SequenceNo, Mailbox->HostSeq= uenceNo); SendAckPacket (Mailbox->LastAck); ReleaseMpSpinLock (&mDebugMpContext.DebugPortSpinLock); continue; } else if (DebugHeader->SequenceNo =3D=3D (UINT8) (Mailbox->HostSequen= ceNo + 1)) { UpdateMailboxContent (Mailbox, DEBUG_MAILBOX_HOST_SEQUENCE_NO_INDEX,= (UINT8) DebugHeader->SequenceNo); } else { - DebugAgentMsgPrint (DEBUG_AGENT_WARNING, "Receive one invalid comamn= d[%x] agaist command[%x]\n", DebugHeader->SequenceNo, Mailbox->HostSequence= No); + DebugAgentMsgPrint (DEBUG_AGENT_WARNING, "Receive one invalid comman= d[%x] against command[%x]\n", DebugHeader->SequenceNo, Mailbox->HostSequenc= eNo); ReleaseMpSpinLock (&mDebugMpContext.DebugPortSpinLock); continue; } =20 // - // Save CPU content before executing HOST commond + // Save CPU content before executing HOST command // UpdateMailboxContent (Mailbox, DEBUG_MAILBOX_EXCEPTION_BUFFER_POINTER_= INDEX, (UINT64)(UINTN) &AgentExceptionBuffer.JumpBuffer); if (SetJump (&AgentExceptionBuffer.JumpBuffer) !=3D 0) { @@ -2019,7 +2019,7 @@ CommandCommunication ( =20 } else { // - // If reveived HALT command, need to defer the GO command + // If received HALT command, need to defer the GO command // SendAckPacket (DEBUG_COMMAND_HALT_PROCESSED); HaltDeferred =3D FALSE; @@ -2300,7 +2300,7 @@ CommandCommunication ( /** C function called in interrupt handler. =20 - @param[in] Vector Vector value of exception or interrutp. + @param[in] Vector Vector value of exception or interrupt. @param[in] CpuContext Pointer to save CPU context. =20 **/ @@ -2341,7 +2341,7 @@ InterruptProcess ( if (MultiProcessorDebugSupport()) { ProcessorIndex =3D GetProcessorIndex (); // - // If this processor has alreay halted before, need to check it later + // If this processor has already halted before, need to check it later // if (IsCpuStopped (ProcessorIndex)) { IssuedViewPoint =3D ProcessorIndex; @@ -2372,7 +2372,7 @@ InterruptProcess ( =20 if (MultiProcessorDebugSupport()) { // - // If RUN commmand is executing, wait for it done. + // If RUN command is executing, wait for it done. // while (mDebugMpContext.RunCommandSet) { CpuPause (); diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/DxeDebugA= gentLib.c b/SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/DxeDebugAg= entLib.c index 1f388d9c0281..bb37aa99b4d4 100644 --- a/SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/DxeDebugAgentLib= .c +++ b/SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/DxeDebugAgentLib= .c @@ -1,5 +1,5 @@ /** @file - Debug Agent library implementition for Dxe Core and Dxr modules. + Debug Agent library implementation for Dxe Core and Dxr modules. =20 Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/SerialIo.= c b/SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/SerialIo.c index 07f47262d24e..3e64852e9027 100644 --- a/SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/SerialIo.c +++ b/SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/SerialIo.c @@ -9,7 +9,7 @@ #include "DxeDebugAgentLib.h" =20 // -// Serial I/O Protocol Interface defintions. +// Serial I/O Protocol Interface definitions. // =20 /** @@ -231,7 +231,7 @@ typedef struct { } DEBUG_SERIAL_FIFO; =20 // -// Global Varibles +// Global Variables // EFI_HANDLE mSerialIoHandle =3D NULL; UINTN mLoopbackBuffer =3D 0; @@ -389,7 +389,7 @@ SerialReset ( mSerialIoMode.ControlMask =3D SERIAL_PORT_DEFAULT_CONTROL_MASK; mLoopbackBuffer =3D 0; // - // Not reset serial devcie hardware indeed. + // Not reset serial device hardware indeed. // return EFI_SUCCESS; } diff --git a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPei= DebugAgentLib.c b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/S= ecPeiDebugAgentLib.c index da2a75e91246..51e07f70e7bb 100644 --- a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAg= entLib.c +++ b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAg= entLib.c @@ -1,5 +1,5 @@ /** @file - SEC Core Debug Agent Library instance implementition. + SEC Core Debug Agent Library instance implementation. =20 Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -198,7 +198,7 @@ GetMailboxPointer ( =20 MailboxLocationInHob =3D GetMailboxLocationFromHob (); // - // Compare mailbox in IDT enry with mailbox in HOB, + // Compare mailbox in IDT entry with mailbox in HOB, // need to fix mailbox location if HOB moved by PEI CORE // if (MailboxLocationInHob !=3D MailboxLocationInIdt && MailboxLocationInH= ob !=3D NULL) { @@ -323,7 +323,7 @@ DebugAgentCallbackMemoryDiscoveredPpi ( =20 This function is used to set up debug environment for SEC and PEI phase. =20 - If InitFlag is DEBUG_AGENT_INIT_PREMEM_SEC, it will overirde IDT table e= ntries + If InitFlag is DEBUG_AGENT_INIT_PREMEM_SEC, it will override IDT table e= ntries and initialize debug port. It will enable interrupt to support break-in = feature. It will set up debug agent Mailbox in cache-as-ramfrom. It will be calle= d before physical memory is ready. @@ -546,7 +546,7 @@ InitializeDebugAgent ( SetDebugFlag (DEBUG_AGENT_FLAG_INIT_ARCH, DEBUG_ARCH_SYMBOL); // // Register for a callback once memory has been initialized. - // If memery has been ready, the callback funtion will be invoked imme= diately + // If memory has been ready, the callback function will be invoked imm= ediately // Status =3D PeiServicesNotifyPpi (&mDebugAgentMemoryDiscoveredNotifyLis= t[0]); if (EFI_ERROR (Status)) { @@ -626,7 +626,7 @@ InitializeDebugAgent ( EnableInterrupts (); } // - // If Function is not NULL, invoke it always whatever debug agent was in= itialized sucesssfully or not. + // If Function is not NULL, invoke it always whatever debug agent was in= itialized successfully or not. // if (Function !=3D NULL) { Function (Context); diff --git a/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgent/SmmDebugA= gentLib.c b/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgent/SmmDebugAg= entLib.c index b759918e8531..37b0e8f39759 100644 --- a/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgent/SmmDebugAgentLib= .c +++ b/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgent/SmmDebugAgentLib= .c @@ -1,5 +1,5 @@ /** @file - Debug Agent library implementition. + Debug Agent library implementation. =20 Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -152,13 +152,13 @@ RestoreDebugRegister ( /** Initialize debug agent. =20 - This function is used to set up debug enviroment for source level debug + This function is used to set up debug environment for source level debug in SMM code. =20 - If InitFlag is DEBUG_AGENT_INIT_SMM, it will overirde IDT table entries + If InitFlag is DEBUG_AGENT_INIT_SMM, it will override IDT table entries and initialize debug port. It will get debug agent Mailbox from GUIDed H= OB, it it exists, debug agent wiil copied it into the local Mailbox in SMM s= pace. - it will overirde IDT table entries and initialize debug port. Context wi= ll be + it will override IDT table entries and initialize debug port. Context wi= ll be NULL. If InitFlag is DEBUG_AGENT_INIT_ENTER_SMI, debug agent will save Debug Registers and get local Mailbox in SMM space. Context will be NULL. @@ -295,7 +295,7 @@ InitializeDebugAgent ( Mailbox =3D GetMailboxPointer (); if (GetDebugFlag (DEBUG_AGENT_FLAG_AGENT_IN_PROGRESS) =3D=3D 1) { // - // If Debug Agent has been communicaton state with HOST, we need ski= p + // If Debug Agent has been communication state with HOST, we need sk= ip // any break points set in SMM, set Skip Breakpoint flag // mSkipBreakpoint =3D TRUE; diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/A= smFuncs.nasm b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32= /AsmFuncs.nasm index a5a734a46351..912256ba455a 100644 --- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/AsmFuncs= .nasm +++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/AsmFuncs= .nasm @@ -226,7 +226,7 @@ NoExtrPush: push ebx ; temporarily save value of ebx on stack cpuid ; use CPUID to determine if FXSAVE/FXRESTOR and ; DE are supported - pop ebx ; retore value of ebx that was overwritten by CPUI= D + pop ebx ; restore value of ebx that was overwritten by CPU= ID mov eax, cr4 push eax ; push cr4 firstly test edx, BIT24 ; Test for FXSAVE/FXRESTOR support @@ -407,7 +407,7 @@ NoExtrPush: mov esp, ebp pop ebp ; restore ebp maybe updated pop esp ; restore esp maybe updated - sub esp, 4 * 3 ; restore interupt pushced stack + sub esp, 4 * 3 ; restore interrupt pushced stack =20 iretd =20 --=20 2.21.1