public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH V2] MdePkg/SmBios.h: Add two additional DWORD for smbios 3.3.0 type17
@ 2020-02-07  8:37 Gao, Zhichao
  2020-02-07  9:31 ` Liming Gao
  0 siblings, 1 reply; 2+ messages in thread
From: Gao, Zhichao @ 2020-02-07  8:37 UTC (permalink / raw)
  To: devel; +Cc: Matthew Carlson, Michael D Kinney, Liming Gao

From: Matthew Carlson <macarl@microsoft.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2482

Refer to DSP0134_3.3.0.pdf, there are two additional DWORD added
for type 17. One is "Extended Speed", the other is "Extended
Configured Memory Speed". The lack of these field may cause strange
error in some operating systems.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
V2:

1. fix some typo.
2. Do not update the copyright.

 MdePkg/Include/IndustryStandard/SmBios.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
index 8b3c4d7ba9..def874be28 100644
--- a/MdePkg/Include/IndustryStandard/SmBios.h
+++ b/MdePkg/Include/IndustryStandard/SmBios.h
@@ -1843,6 +1843,11 @@ typedef struct {
   UINT64                                    VolatileSize;
   UINT64                                    CacheSize;
   UINT64                                    LogicalSize;
+  //
+  // Add for smbios 3.3.0
+  //
+  UINT32                                    ExtendedSpeed;
+  UINT32                                    ExtendedConfiguredMemorySpeed;
 } SMBIOS_TABLE_TYPE17;
 
 ///
-- 
2.16.2.windows.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH V2] MdePkg/SmBios.h: Add two additional DWORD for smbios 3.3.0 type17
  2020-02-07  8:37 [PATCH V2] MdePkg/SmBios.h: Add two additional DWORD for smbios 3.3.0 type17 Gao, Zhichao
@ 2020-02-07  9:31 ` Liming Gao
  0 siblings, 0 replies; 2+ messages in thread
From: Liming Gao @ 2020-02-07  9:31 UTC (permalink / raw)
  To: Gao, Zhichao, devel@edk2.groups.io; +Cc: Matthew Carlson, Kinney, Michael D

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Gao, Zhichao <zhichao.gao@intel.com>
> Sent: Friday, February 7, 2020 4:37 PM
> To: devel@edk2.groups.io
> Cc: Matthew Carlson <macarl@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH V2] MdePkg/SmBios.h: Add two additional DWORD for smbios 3.3.0 type17
> 
> From: Matthew Carlson <macarl@microsoft.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2482
> 
> Refer to DSP0134_3.3.0.pdf, there are two additional DWORD added
> for type 17. One is "Extended Speed", the other is "Extended
> Configured Memory Speed". The lack of these field may cause strange
> error in some operating systems.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
> V2:
> 
> 1. fix some typo.
> 2. Do not update the copyright.
> 
>  MdePkg/Include/IndustryStandard/SmBios.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
> index 8b3c4d7ba9..def874be28 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -1843,6 +1843,11 @@ typedef struct {
>    UINT64                                    VolatileSize;
>    UINT64                                    CacheSize;
>    UINT64                                    LogicalSize;
> +  //
> +  // Add for smbios 3.3.0
> +  //
> +  UINT32                                    ExtendedSpeed;
> +  UINT32                                    ExtendedConfiguredMemorySpeed;
>  } SMBIOS_TABLE_TYPE17;
> 
>  ///
> --
> 2.16.2.windows.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-07  9:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-07  8:37 [PATCH V2] MdePkg/SmBios.h: Add two additional DWORD for smbios 3.3.0 type17 Gao, Zhichao
2020-02-07  9:31 ` Liming Gao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox