* [Patch 1/1] BaseTools: Fixed a Incremental build issue
@ 2020-02-07 8:41 Bob Feng
2020-02-07 9:29 ` Liming Gao
0 siblings, 1 reply; 3+ messages in thread
From: Bob Feng @ 2020-02-07 8:41 UTC (permalink / raw)
To: edk2-devel, devel; +Cc: Bob Feng, Guo Dong, Liming Gao
From: Bob Feng <bob.c.feng@intel.com>
The .map file is not update to FFS_OUTPUT_DIR folder
in the incremental build.
Signed-off-by: Guo Dong <guo.dong@intel.com>
Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
BaseTools/Source/Python/AutoGen/GenMake.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py b/BaseTools/Source/Python/AutoGen/GenMake.py
index ba199c1aa73d..9ae09c47caf8 100755
--- a/BaseTools/Source/Python/AutoGen/GenMake.py
+++ b/BaseTools/Source/Python/AutoGen/GenMake.py
@@ -718,11 +718,11 @@ cleanlib:
Src = self.ReplaceMacro(Src)
Dst = self.ReplaceMacro(Dst)
if Dst not in self.ResultFileList:
self.ResultFileList.append(Dst)
if '%s :' %(Dst) not in self.BuildTargetList:
- self.BuildTargetList.append("%s :" %(Dst))
+ self.BuildTargetList.append("%s : %s" %(Dst,Src))
self.BuildTargetList.append('\t' + self._CP_TEMPLATE_[self._FileType] %{'Src': Src, 'Dst': Dst})
FfsCmdList = Cmd[0]
for index, Str in enumerate(FfsCmdList):
if '-o' == Str:
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Patch 1/1] BaseTools: Fixed a Incremental build issue
@ 2020-02-07 8:45 Bob Feng
0 siblings, 0 replies; 3+ messages in thread
From: Bob Feng @ 2020-02-07 8:45 UTC (permalink / raw)
To: devel; +Cc: Guo Dong, Liming Gao
The .map file is not update to FFS_OUTPUT_DIR folder
in the incremental build.
Signed-off-by: Guo Dong <guo.dong@intel.com>
Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
BaseTools/Source/Python/AutoGen/GenMake.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py b/BaseTools/Source/Python/AutoGen/GenMake.py
index ba199c1aa73d..9ae09c47caf8 100755
--- a/BaseTools/Source/Python/AutoGen/GenMake.py
+++ b/BaseTools/Source/Python/AutoGen/GenMake.py
@@ -718,11 +718,11 @@ cleanlib:
Src = self.ReplaceMacro(Src)
Dst = self.ReplaceMacro(Dst)
if Dst not in self.ResultFileList:
self.ResultFileList.append(Dst)
if '%s :' %(Dst) not in self.BuildTargetList:
- self.BuildTargetList.append("%s :" %(Dst))
+ self.BuildTargetList.append("%s : %s" %(Dst,Src))
self.BuildTargetList.append('\t' + self._CP_TEMPLATE_[self._FileType] %{'Src': Src, 'Dst': Dst})
FfsCmdList = Cmd[0]
for index, Str in enumerate(FfsCmdList):
if '-o' == Str:
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Patch 1/1] BaseTools: Fixed a Incremental build issue
2020-02-07 8:41 [Patch 1/1] BaseTools: Fixed a Incremental build issue Bob Feng
@ 2020-02-07 9:29 ` Liming Gao
0 siblings, 0 replies; 3+ messages in thread
From: Liming Gao @ 2020-02-07 9:29 UTC (permalink / raw)
To: Feng, Bob C, edk2-devel@lists.01.org, devel@edk2.groups.io; +Cc: Dong, Guo
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Feng, Bob C <bob.c.feng@intel.com>
> Sent: Friday, February 7, 2020 4:42 PM
> To: edk2-devel@lists.01.org; devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Dong, Guo <guo.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [Patch 1/1] BaseTools: Fixed a Incremental build issue
>
> From: Bob Feng <bob.c.feng@intel.com>
>
> The .map file is not update to FFS_OUTPUT_DIR folder
> in the incremental build.
>
> Signed-off-by: Guo Dong <guo.dong@intel.com>
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
> BaseTools/Source/Python/AutoGen/GenMake.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py b/BaseTools/Source/Python/AutoGen/GenMake.py
> index ba199c1aa73d..9ae09c47caf8 100755
> --- a/BaseTools/Source/Python/AutoGen/GenMake.py
> +++ b/BaseTools/Source/Python/AutoGen/GenMake.py
> @@ -718,11 +718,11 @@ cleanlib:
> Src = self.ReplaceMacro(Src)
> Dst = self.ReplaceMacro(Dst)
> if Dst not in self.ResultFileList:
> self.ResultFileList.append(Dst)
> if '%s :' %(Dst) not in self.BuildTargetList:
> - self.BuildTargetList.append("%s :" %(Dst))
> + self.BuildTargetList.append("%s : %s" %(Dst,Src))
> self.BuildTargetList.append('\t' + self._CP_TEMPLATE_[self._FileType] %{'Src': Src, 'Dst': Dst})
>
> FfsCmdList = Cmd[0]
> for index, Str in enumerate(FfsCmdList):
> if '-o' == Str:
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-07 9:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-07 8:41 [Patch 1/1] BaseTools: Fixed a Incremental build issue Bob Feng
2020-02-07 9:29 ` Liming Gao
-- strict thread matches above, loose matches on Subject: below --
2020-02-07 8:45 Bob Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox