From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web10.7136.1581182823438022094 for ; Sat, 08 Feb 2020 09:27:03 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=H/VsSwwI; spf=pass (domain: nuviainc.com, ip: 209.85.128.68, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f68.google.com with SMTP id f129so6081946wmf.2 for ; Sat, 08 Feb 2020 09:27:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=yuQliFVFehxk9h2iQnUDwE4lY0RCSmsRdoraVZAyQHU=; b=H/VsSwwIeWXH8eZJXLzIV+DkvgFWZG6et2W0H1oT/jSAeWyXAR79pllQC1bqYX2PNR Ip6sR189hTF83TyhDOnI/8HyTJOtbYVXNLqWjuCABrr960FRWVGRYinuNMk53EyXMiQJ T7rzJbButlpaeWPl/imY3Y89gf/9155RcBb50oT2Yf+BQYVVQCIZ3gaVMX6l2Sxlb916 BDwavF0Kdq9LxYz7Pc+xs+7QwL3nlxnjOhrCl/BWg/JR9H34O7xroM0H1KKO9O+77PVg blIZPlvvJa28cgryeptwd0UriMPPy2wbiI6a2BDcGiPILHVi5l4O2xrQUKgiPCxyRLX9 VAiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yuQliFVFehxk9h2iQnUDwE4lY0RCSmsRdoraVZAyQHU=; b=O+oxd3k+bQ1odUgnvaeqs4c516+UWXs5d33PIC+wGBoinBa0Q2qzRGbOjDqCG2ioUw EKFcr9S95cKiU63NP/rTdmcmE7dSQZ49oeMNBsnIU1KGFQNt2ZQ3Nabsj0rmcy4QlBWl lxeE+YhqdWIJxS8eecAITGXWhjA3isSjWXpVUWYX70NJ9aoK8WqOwcQyjs0Gu6tXXhFx uMRw5ttjm3iiWiCz/0wItUN1B9F3HZv9kXFhHbLPJSFJwYAKX/GPUVAYMBJaNyTUrmLG TmIHg5Nt48Xt4nxLoKPxlBA+lAzpsMIbGUF+S/ngn5D0jsOaitTPMh+D/0jXH+u5Eqj2 EGCg== X-Gm-Message-State: APjAAAXFXh6QfooKiBsmMTIxhR92/3hjQ+9UPK2ERVBqd8ht/zsmk4w7 Ib0tynNOBTi8W4pW0bF5vMETJw== X-Google-Smtp-Source: APXvYqxKZXKOAe9i5HHmfHTfBd60eKr3RlYalFVyGG0X4e21e/DrkXNp9f2BmHfs/LQ803vv52/yDA== X-Received: by 2002:a1c:f001:: with SMTP id a1mr4962266wmb.76.1581182822069; Sat, 08 Feb 2020 09:27:02 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id d16sm9210539wrg.27.2020.02.08.09.27.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2020 09:27:01 -0800 (PST) Date: Sat, 8 Feb 2020 17:27:00 +0000 From: "Leif Lindholm" To: Pankaj Bansal Cc: Meenakshi Aggarwal , Michael D Kinney , Varun Sethi , devel@edk2.groups.io Subject: Re: [PATCH 03/19] NXP/LS1043aRdb: Move Soc specific components to soc files Message-ID: <20200208172700.GF23627@bivouac.eciton.net> References: <20200207124328.8723-1-pankaj.bansal@nxp.com> <20200207124328.8723-4-pankaj.bansal@nxp.com> MIME-Version: 1.0 In-Reply-To: <20200207124328.8723-4-pankaj.bansal@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 07, 2020 at 18:13:12 +0530, Pankaj Bansal wrote: > Soc specific components ought to be part of Soc files and not > platform files. move the same to SOC files > > Signed-off-by: Pankaj Bansal > --- > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 7 +------ > Platform/NXP/NxpQoriqLs.dsc.inc | 2 ++ > Silicon/NXP/LS1043A/LS1043A.dsc.inc | 8 ++++++-- > 3 files changed, 9 insertions(+), 8 deletions(-) > > diff --git a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > index c810559353..802cccdce6 100644 > --- a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > +++ b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > @@ -2,7 +2,7 @@ > # > # LS1043ARDB Board package. > # > -# Copyright 2017-2019 NXP > +# Copyright 2017-2020 NXP > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -26,11 +26,7 @@ > !include Silicon/NXP/LS1043A/LS1043A.dsc.inc > > [LibraryClasses.common] > - SocLib|Silicon/NXP/Library/SocLib/LS1043aSocLib.inf > ArmPlatformLib|Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > - ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf > - SerialPortLib|Silicon/NXP/Library/DUartPortLib/DUartPortLib.inf > - IoAccessLib|Silicon/NXP/Library/IoAccessLib/IoAccessLib.inf > RealTimeClockLib|Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.inf > > [PcdsFixedAtBuild.common] > @@ -46,7 +42,6 @@ > # > # Board Specific Pcds > # > - gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x021c0500 > gNxpQoriqLsTokenSpaceGuid.PcdSerdes2Enabled|FALSE > gNxpQoriqLsTokenSpaceGuid.PcdPlatformFreqDiv|0x1 > > diff --git a/Platform/NXP/NxpQoriqLs.dsc.inc b/Platform/NXP/NxpQoriqLs.dsc.inc > index b28e0615f7..94d3e53a04 100644 > --- a/Platform/NXP/NxpQoriqLs.dsc.inc > +++ b/Platform/NXP/NxpQoriqLs.dsc.inc > @@ -95,6 +95,8 @@ > ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > > I2cLib|Silicon/NXP/Library/I2cLib/I2cLib.inf > + ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf > + IoAccessLib|Silicon/NXP/Library/IoAccessLib/IoAccessLib.inf > > [LibraryClasses.common.SEC] > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > diff --git a/Silicon/NXP/LS1043A/LS1043A.dsc.inc b/Silicon/NXP/LS1043A/LS1043A.dsc.inc > index dbd680b0ad..8790db6ff8 100644 > --- a/Silicon/NXP/LS1043A/LS1043A.dsc.inc > +++ b/Silicon/NXP/LS1043A/LS1043A.dsc.inc > @@ -1,12 +1,16 @@ > # LS1043A.dsc > # LS1043A Soc package. > # > -# Copyright 2017-2019 NXP > +# Copyright 2017-2020 NXP > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > # > > +[LibraryClasses.common] > + SocLib|Silicon/NXP/Library/SocLib/LS1043aSocLib.inf > + SerialPortLib|Silicon/NXP/Library/DUartPortLib/DUartPortLib.inf > + > ################################################################################ > # > # Pcd Section - list of all EDK II PCD Entries defined by this Platform > @@ -20,6 +24,7 @@ > gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0x01402000 > > [PcdsFixedAtBuild.common] > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x021c0500 > > # > # CCSR Address Space and other attached Memories > @@ -57,5 +62,4 @@ > # > gNxpQoriqLsTokenSpaceGuid.PcdGurBigEndian|TRUE > gNxpQoriqLsTokenSpaceGuid.PcdWatchdogBigEndian|TRUE > - Please drop this spurious blank line deletion. Once that's done: Reviewed-by: Leif Lindholm / Leif > ## > -- > 2.17.1 >