public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: devel@edk2.groups.io
Cc: Maurice Ma <maurice.ma@intel.com>,
	Nate DeSimone <nathaniel.l.desimone@intel.com>,
	Star Zeng <star.zeng@intel.com>
Subject: [PATCH 0/2] IntelFsp2Pkg: Coverity scan flags issues
Date: Mon, 10 Feb 2020 11:53:27 +0800	[thread overview]
Message-ID: <20200210035329.19432-1-chasel.chiu@intel.com> (raw)

GenCfgOpt.py:
Issue was: invalid_operation: Invalid operation on
null-like value "Base".
Fixed it by initializing Base to 0 before entering
while loop.

SplitFspBin.py:
Issues were:
1. copy_paste_error: PeOptHdr vs PePlusOptHdr.
2. invalid_operation: Invalid operation on
null-like value "roffset".
3. invalid_operation: Invalid operation on
null-like value "rsize".
Fixed them by initializing roffset and rsize as PE32
image type and overriding them when PE32+ header found.

Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>

Chasel Chiu (2):
  IntelFsp2Pkg/GenCfgOpt.py: Coverity scan flags issues.
  IntelFsp2Pkg/SplitFspBin.py: Coverity scan flags issues.

 IntelFsp2Pkg/Tools/GenCfgOpt.py   |  3 ++-
 IntelFsp2Pkg/Tools/SplitFspBin.py | 10 +++++-----
 2 files changed, 7 insertions(+), 6 deletions(-)

-- 
2.13.3.windows.1


             reply	other threads:[~2020-02-10  3:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-10  3:53 Chiu, Chasel [this message]
2020-02-10  3:53 ` [PATCH 1/2] IntelFsp2Pkg/GenCfgOpt.py: Coverity scan flags issues Chiu, Chasel
2020-02-10  8:36   ` [edk2-devel] " Philippe Mathieu-Daudé
2020-02-10 11:49     ` Chiu, Chasel
2020-02-10  3:53 ` [PATCH 2/2] IntelFsp2Pkg/SplitFspBin.py: " Chiu, Chasel
2020-02-10  6:52 ` [PATCH 0/2] IntelFsp2Pkg: " Zeng, Star
2020-02-12  7:30 ` Nate DeSimone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200210035329.19432-1-chasel.chiu@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox