From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.16855.1581306819865977960 for ; Sun, 09 Feb 2020 19:53:40 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: chasel.chiu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Feb 2020 19:53:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,423,1574150400"; d="scan'208";a="232981251" Received: from unknown (HELO cchiu4-MOBL1.gar.corp.intel.com) ([10.5.215.139]) by orsmga003.jf.intel.com with ESMTP; 09 Feb 2020 19:53:38 -0800 From: "Chiu, Chasel" To: devel@edk2.groups.io Cc: Maurice Ma , Nate DeSimone , Star Zeng Subject: [PATCH 0/2] IntelFsp2Pkg: Coverity scan flags issues Date: Mon, 10 Feb 2020 11:53:27 +0800 Message-Id: <20200210035329.19432-1-chasel.chiu@intel.com> X-Mailer: git-send-email 2.13.3.windows.1 GenCfgOpt.py: Issue was: invalid_operation: Invalid operation on null-like value "Base". Fixed it by initializing Base to 0 before entering while loop. SplitFspBin.py: Issues were: 1. copy_paste_error: PeOptHdr vs PePlusOptHdr. 2. invalid_operation: Invalid operation on null-like value "roffset". 3. invalid_operation: Invalid operation on null-like value "rsize". Fixed them by initializing roffset and rsize as PE32 image type and overriding them when PE32+ header found. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu Chasel Chiu (2): IntelFsp2Pkg/GenCfgOpt.py: Coverity scan flags issues. IntelFsp2Pkg/SplitFspBin.py: Coverity scan flags issues. IntelFsp2Pkg/Tools/GenCfgOpt.py | 3 ++- IntelFsp2Pkg/Tools/SplitFspBin.py | 10 +++++----- 2 files changed, 7 insertions(+), 6 deletions(-) -- 2.13.3.windows.1