From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web10.8913.1581421226608411347 for ; Tue, 11 Feb 2020 03:40:26 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=qf6xtR2q; spf=pass (domain: nuviainc.com, ip: 209.85.128.67, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f67.google.com with SMTP id a9so3125993wmj.3 for ; Tue, 11 Feb 2020 03:40:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=nC5bwgKLLlIr19DM3pzamIUIjQy7DHTY9ZkFnfOnAws=; b=qf6xtR2qCFD3+MaQljMPOYYnB04lYb2pUaNVZmDP7UpQSCz3R5PpnbdP5yToaOEB47 +VbzUskq/NbhxkQ+D9b+Ht7dEQfbII1Vbcup1vvuDatyLeYrj5zfD0jnvPBcD3GiTaRS 0QdjAJDf4QA1BaD/EN8vq4kTEDnyaxjghjDVpb4R7JEI3Bjj0N/l1lAvaX6Wf0ocXDZY ReyNonNNCfqeO6ayHV40vx2QJSF6EOMJA5eWHl2t7C8GdEymVbkx+bwSlIGB1uGx07gL uUxIkFgZFTgn4fms8cbrnzW2EQUnL5GmcnU6hx1hBCkXdDtnHsE0TbZxN7iveSLHdFMV +4Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nC5bwgKLLlIr19DM3pzamIUIjQy7DHTY9ZkFnfOnAws=; b=DGlLfp1uJN5PoZYmJyzfBL7lkeGi8smSCa8B/7cAfG9zhs8Oh1uiU/XUxVXOHX3oF+ J+YlTNnV2hLkkNUNd0GKZRsJ7zVljooPaZlHun6QFr5sGZmYN/Bd6e13q0REDHHNtjPN xdVe+YwXHhZFNAcDLsrxRCxjQ3kTjNmy9iHyj1UXSKjoBLZc+vj6n537RlCdtohg2KFC d8TXR780DuVKRuOQrdUUmYSHJ9NO4YtQ4v7PzS7Sjr9hYWwIIxhXVry/5oppAztuJwQP +zOXds3FTqSZQoy/tv6ZKKz3HjpsNPN8GD0Ma5fdQSHr1Mvq2BIqOQTk9BRE0GC8lKHr 7y+A== X-Gm-Message-State: APjAAAVGW9uGJ8SVIOhKIFxSSxhwk+nu4Q9aYGB1w0f1MSiFKDqMKHV1 IloAJK+4StrWaE+KpMY3LbytDA== X-Google-Smtp-Source: APXvYqwzw5U3o7Z6F+Bys0MAWqvgiNexJ0IaYeI3sPbhwWSvg5mLjrv/j313XLacXHPkIkEPqAi5YA== X-Received: by 2002:a1c:7215:: with SMTP id n21mr5505371wmc.154.1581421225205; Tue, 11 Feb 2020 03:40:25 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id y17sm4829180wrs.82.2020.02.11.03.40.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2020 03:40:24 -0800 (PST) Date: Tue, 11 Feb 2020 11:40:23 +0000 From: "Leif Lindholm" To: Pankaj Bansal Cc: Meenakshi Aggarwal , Michael D Kinney , Varun Sethi , devel@edk2.groups.io Subject: Re: [PATCH 10/19] Platform/NXP: rename the ArmPlatformLib as per ArmPlatformPkg Message-ID: <20200211114023.GT23627@bivouac.eciton.net> References: <20200207124328.8723-1-pankaj.bansal@nxp.com> <20200207124328.8723-11-pankaj.bansal@nxp.com> MIME-Version: 1.0 In-Reply-To: <20200207124328.8723-11-pankaj.bansal@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 07, 2020 at 18:13:19 +0530, Pankaj Bansal wrote: > Keep the names and location of files as mentioned in ArmPlatformPkg. This isn't really a goal in itself, but the AArch64/ addition is good cleanup, so I'm not objecting. But please mention that one explicitly. > This helps in porting the common changes (if any in future) easily. > > Signed-off-by: Pankaj Bansal > --- > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 2 +- > .../AArch64}/NxpQoriqLsHelper.S | 2 +- > .../Library/{PlatformLib => ArmPlatformLib}/ArmPlatformLib.c | 2 +- > .../{PlatformLib => ArmPlatformLib}/ArmPlatformLib.inf | 4 ++-- > .../NxpQoriqLsMem.c => ArmPlatformLib/ArmPlatformLibMem.c} | 0 > 5 files changed, 5 insertions(+), 5 deletions(-) > rename Platform/NXP/LS1043aRdbPkg/Library/{PlatformLib => ArmPlatformLib/AArch64}/NxpQoriqLsHelper.S (88%) > rename Platform/NXP/LS1043aRdbPkg/Library/{PlatformLib => ArmPlatformLib}/ArmPlatformLib.c (93%) > rename Platform/NXP/LS1043aRdbPkg/Library/{PlatformLib => ArmPlatformLib}/ArmPlatformLib.inf (89%) > rename Platform/NXP/LS1043aRdbPkg/Library/{PlatformLib/NxpQoriqLsMem.c => ArmPlatformLib/ArmPlatformLibMem.c} (100%) > > diff --git a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > index 7cffd09d7d..bc6fa4f19d 100644 > --- a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > +++ b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > @@ -26,7 +26,7 @@ > !include Silicon/NXP/LS1043A/LS1043A.dsc.inc > > [LibraryClasses.common] > - ArmPlatformLib|Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > + ArmPlatformLib|Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > RealTimeClockLib|Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.inf > > [PcdsFixedAtBuild.common] > diff --git a/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsHelper.S b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/AArch64/NxpQoriqLsHelper.S > similarity index 88% > rename from Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsHelper.S > rename to Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/AArch64/NxpQoriqLsHelper.S > index 84ee8c9f97..dfbf73675a 100644 > --- a/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsHelper.S > +++ b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/AArch64/NxpQoriqLsHelper.S > @@ -1,7 +1,7 @@ > # @file > # > # Copyright (c) 2012-2013, ARM Limited. All rights reserved. > -# Copyright 2017 NXP > +# Copyright 2017, 2020 NXP I don't think renaming a file qualifies for updating copyright on it. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > diff --git a/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.c b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c > similarity index 93% > rename from Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.c > rename to Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c > index eac7d4aa4e..718c71bf02 100644 > --- a/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.c > +++ b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c > @@ -6,7 +6,7 @@ > * > * Copyright (c) 2011-2012, ARM Limited. All rights reserved. > * Copyright (c) 2016, Freescale Semiconductor, Inc. All rights reserved. > -* Copyright 2017 NXP > +* Copyright 2017, 2020 NXP Same again. / Leif > * SPDX-License-Identifier: BSD-2-Clause-Patent > * > **/ > diff --git a/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > similarity index 89% > rename from Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > rename to Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > index 054dc4d003..6396d2982b 100644 > --- a/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > +++ b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > @@ -27,8 +27,8 @@ > SocLib > > [Sources.common] > - NxpQoriqLsHelper.S | GCC > - NxpQoriqLsMem.c > + AArch64/NxpQoriqLsHelper.S | GCC > + ArmPlatformLibMem.c > ArmPlatformLib.c > > [Ppis] > diff --git a/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLibMem.c > similarity index 100% > rename from Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c > rename to Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLibMem.c > -- > 2.17.1 >