From: "Gary Lin" <glin@suse.com>
To: <devel@edk2.groups.io>, <zailiang.sun@intel.com>
Cc: "Qian, Yi" <yi.qian@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/2] Vlv2TbltDevicePkg/GenerateCapsule: Create cab files with signed capsules
Date: Wed, 12 Feb 2020 14:41:54 +0800 [thread overview]
Message-ID: <20200212064154.GA6159@GaryLaptop> (raw)
In-Reply-To: <7CB7EF03E15B5D48981329A508747A9850D288D1@SHSMSX104.ccr.corp.intel.com>
On Wed, Feb 12, 2020 at 06:31:46AM +0000, Sun, Zailiang wrote:
> Hi Lin,
>
> Next time you might need have Mike Kinney in the cc list:)
>
Ok, will do that if I have patches for Vlv2TbltDevicePkg.
Thanks,
Gary Lin
> Reviewed-by: Zailiang Sun <Zailiang.sun@intel.com>
>
> -----Original Message-----
> From: Gary Lin <glin@suse.com>
> Sent: Wednesday, February 12, 2020 2:24 PM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>
> Subject: [PATCH 1/2] Vlv2TbltDevicePkg/GenerateCapsule: Create cab files with signed capsules
>
> The cab file previously contained the unsigned payload without the FMP
> header, so the firmware would reject the capsule generated by fwupd
> based on the cab file. This commit copies the signed capsule into the
> cab file so that fwupd can generate a valid capsule.
>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> cc: Yi Qian <yi.qian@intel.com>
> Signed-off-by: Gary Lin <glin@suse.com>
> ---
> .../Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleAll.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleAll.py b/Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleAll.py
> index a37648ac96..1a6c597c4a 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleAll.py
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleAll.py
> @@ -181,7 +181,7 @@ def GenCapsuleDevice (BaseName, PayloadFileName, Guid, Version, Lsv, CapsulesPat
> LogAlways (ProcessOutput[0].decode())
> Error ('GenerateCapsule returned an error')
>
> - Copy (PayloadFileName, (CapsulesPath, 'firmware.bin'))
> + Copy (FmpCapsuleFile, (CapsulesPath, 'firmware.bin'))
> MetaInfoXml = MetaInfoXmlTemplate
> MetaInfoXml = MetaInfoXml.replace ('FMP_CAPSULE_GUID', Guid)
> MetaInfoXml = MetaInfoXml.replace ('FMP_CAPSULE_BASE_NAME', BaseName)
> --
> 2.16.4
>
>
>
>
prev parent reply other threads:[~2020-02-12 6:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 6:24 [PATCH 1/2] Vlv2TbltDevicePkg/GenerateCapsule: Create cab files with signed capsules Gary Lin
2020-02-12 6:24 ` [PATCH 2/2] Vlv2TbltDevicePkg/PreBuild.py: Remove unused functions Gary Lin
2020-02-12 6:33 ` Sun, Zailiang
2020-02-12 6:31 ` [PATCH 1/2] Vlv2TbltDevicePkg/GenerateCapsule: Create cab files with signed capsules Sun, Zailiang
2020-02-12 6:41 ` Gary Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212064154.GA6159@GaryLaptop \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox