From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from m9a0013g.houston.softwaregrp.com (m9a0013g.houston.softwaregrp.com [15.124.64.91]) by mx.groups.io with SMTP id smtpd.web11.960.1581489748622981403 for ; Tue, 11 Feb 2020 22:42:30 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: suse.com, ip: 15.124.64.91, mailfrom: glin@suse.com) Received: FROM m9a0013g.houston.softwaregrp.com (15.121.0.191) BY m9a0013g.houston.softwaregrp.com WITH ESMTP; Wed, 12 Feb 2020 06:41:51 +0000 Received: from M9W0068.microfocus.com (2002:f79:bf::f79:bf) by M9W0068.microfocus.com (2002:f79:bf::f79:bf) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Wed, 12 Feb 2020 06:42:05 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (15.124.72.11) by M9W0068.microfocus.com (15.121.0.191) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10 via Frontend Transport; Wed, 12 Feb 2020 06:42:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FH8yy/OFz55KRuS6SOHKVjMZDWzuKkzEdf90sCmrg465ch23ISh9bXtzmJ8guycwK+Gm+W4a8oGlJF/ruEni9Tcey68cDKZwEO/D3GSEMHo23tK2VvTDcJE4fhGL3utZA/J0FTj5QvqHQ7sArqCW0Qm92LwQdvB7RsYWOVcZ7y61GxrQOo7pQbfacsclrxC739oL/oWaMiu7aLPcwKg+yOktIV62PzNUUfvLFVbej/v07/oXQLuhr25kJklLOGIde1lhCpq1etURsjis38p7Lk1GD15bzl9jN6z0aOS0fmM92B5guiA2/fmwk75hP7XEj5wdpA7wqfn1ezB5NMcTiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AeIPnZyZo6IkWPhj461MegtlJiaI8ZTIk46xHWDwdMM=; b=h7Ei2554t5ApPy87OU8PD/wIO/tIn+cho/+2N/1fVesBhE8okOBNZFNxYLui5yxQU914xEax79NW2Edlplv6UvsizNoiEifsWRemjyi7nWHU+ZKndMkgVUMygu5a6FPgtOEuM7f/A2z8f3/HD+79k5OIvIA0+oyal1Ol8sXvBDmyUNBv7DLhisUKj7V3n3ROHV1UGltjKeGbxmBHij+D0vcZWbXQj557MlXRpCcHYvcBmjvzLAU/ybwEuG0rEf9YJgYvFOsgUuC/mO+oBJs+xXg/U6ERK0KukeWPXhKkrC1+LLh990ETjvUBufe/AY1xlX7CsWoh5TI123f9vGGmIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=GLin@suse.com; Received: from DM6PR18MB3258.namprd18.prod.outlook.com (10.255.175.31) by DM6PR18MB2809.namprd18.prod.outlook.com (20.179.48.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2707.25; Wed, 12 Feb 2020 06:42:03 +0000 Received: from DM6PR18MB3258.namprd18.prod.outlook.com ([fe80::386b:b2:de3f:151a]) by DM6PR18MB3258.namprd18.prod.outlook.com ([fe80::386b:b2:de3f:151a%6]) with mapi id 15.20.2707.030; Wed, 12 Feb 2020 06:42:03 +0000 Date: Wed, 12 Feb 2020 14:41:54 +0800 From: "Gary Lin" To: , CC: "Qian, Yi" Subject: Re: [edk2-devel] [PATCH 1/2] Vlv2TbltDevicePkg/GenerateCapsule: Create cab files with signed capsules Message-ID: <20200212064154.GA6159@GaryLaptop> References: <20200212062403.21714-1-glin@suse.com> <7CB7EF03E15B5D48981329A508747A9850D288D1@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <7CB7EF03E15B5D48981329A508747A9850D288D1@SHSMSX104.ccr.corp.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-ClientProxiedBy: BYAPR07CA0058.namprd07.prod.outlook.com (2603:10b6:a03:60::35) To DM6PR18MB3258.namprd18.prod.outlook.com (2603:10b6:5:1cd::31) Return-Path: GLin@suse.com MIME-Version: 1.0 Received: from GaryLaptop (36.229.208.188) by BYAPR07CA0058.namprd07.prod.outlook.com (2603:10b6:a03:60::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2707.24 via Frontend Transport; Wed, 12 Feb 2020 06:42:02 +0000 X-Originating-IP: [36.229.208.188] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 94e09b78-6a31-4f2e-2f3e-08d7af86ab5f X-MS-TrafficTypeDiagnostic: DM6PR18MB2809: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4714; X-Forefront-PRVS: 0311124FA9 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4636009)(396003)(346002)(376002)(366004)(136003)(39860400002)(199004)(189003)(6666004)(66946007)(19627235002)(33716001)(66556008)(66476007)(81166006)(86362001)(8936002)(81156014)(5660300002)(8676002)(33656002)(966005)(4326008)(53546011)(52116002)(26005)(478600001)(55016002)(956004)(6496006)(9686003)(186003)(16526019)(1076003)(2906002)(316002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR18MB2809;H:DM6PR18MB3258.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; Received-SPF: None (protection.outlook.com: suse.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: okuchMl2ndURfhGXp48FHqjpS/hxaG/DPV72bl/AAb8etaE2bWJnf13lFsFS8zlUsvvfXmQPRz0gDzFplYFSXBLNVvY+zod4KPk0pRFHIv8I/vqj0tU+TQltbnsjQMpBR+ttNZxTLsL4lKHXnLeg3ICR7PrZMOMiDSdANvs7IStUeY1NAcbxM6rD245Oi/l56dUw/1yPbhaD4dDsMD1IQt7AuTqJZ0Qce41tyLS0nqcJ/UMvA3xkSWoasHZnIVjOCH8aSZPPvnuw8IoLPJkYJGBrSf7E5Y2gK39sEbTJw9ya3DwnH33dLHiplrtDkLkOrAmBLlyr+Za+iDXNcBeNh5HeTdCR1+XR0nK5OIRu689ZntZFNuWeL74KomrphUrxNjVReEb4wQ6V6ASSOOXBU0G1ryKot7bw877T8N7xCQ1ttw4Dx5U2BChO+NZFcfLIJ9IVrpxFLqG7v5ru5jaHwNklZD09RPmWWpvkZotDhc0/nfWCkp1BSvQXd/p/JEYGYYV5aNM4QEv3JT3LCF22bg== X-MS-Exchange-AntiSpam-MessageData: JmfoFgMvhhcBYkK9Q8nACFMQYzapAbztlZ65ojRHeHLEgbm/kim+MdIAsQXGy4yNdOTDn6MvB1aP9vCvkLlnUrHPN2aAGdSAsgUSIUlCa6lKAXNHO8d7Exw7kkzKu0CSsxpUxfzCDokvdMhbHeKqzw== X-MS-Exchange-CrossTenant-Network-Message-Id: 94e09b78-6a31-4f2e-2f3e-08d7af86ab5f X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2020 06:42:03.3124 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 856b813c-16e5-49a5-85ec-6f081e13b527 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mGkMwOceNZOgmhFdbxAUOpSf57dhPwImzP0706ZqKORDbF1lHzRBtoXEZPx+C2+i X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2809 X-OriginatorOrg: suse.com Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Wed, Feb 12, 2020 at 06:31:46AM +0000, Sun, Zailiang wrote: > Hi Lin, > > Next time you might need have Mike Kinney in the cc list:) > Ok, will do that if I have patches for Vlv2TbltDevicePkg. Thanks, Gary Lin > Reviewed-by: Zailiang Sun > > -----Original Message----- > From: Gary Lin > Sent: Wednesday, February 12, 2020 2:24 PM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi > Subject: [PATCH 1/2] Vlv2TbltDevicePkg/GenerateCapsule: Create cab files with signed capsules > > The cab file previously contained the unsigned payload without the FMP > header, so the firmware would reject the capsule generated by fwupd > based on the cab file. This commit copies the signed capsule into the > cab file so that fwupd can generate a valid capsule. > > Cc: Zailiang Sun > cc: Yi Qian > Signed-off-by: Gary Lin > --- > .../Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleAll.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleAll.py b/Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleAll.py > index a37648ac96..1a6c597c4a 100644 > --- a/Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleAll.py > +++ b/Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleAll.py > @@ -181,7 +181,7 @@ def GenCapsuleDevice (BaseName, PayloadFileName, Guid, Version, Lsv, CapsulesPat > LogAlways (ProcessOutput[0].decode()) > Error ('GenerateCapsule returned an error') > > - Copy (PayloadFileName, (CapsulesPath, 'firmware.bin')) > + Copy (FmpCapsuleFile, (CapsulesPath, 'firmware.bin')) > MetaInfoXml = MetaInfoXmlTemplate > MetaInfoXml = MetaInfoXml.replace ('FMP_CAPSULE_GUID', Guid) > MetaInfoXml = MetaInfoXml.replace ('FMP_CAPSULE_BASE_NAME', BaseName) > -- > 2.16.4 > > > >