public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
Cc: devel@edk2.groups.io, michael.d.kinney@intel.com,
	Ard.Biesheuvel@arm.com, thomas.abraham@arm.com
Subject: Re: [edk2-platforms] [PATCH v2 5/5] Platform/ARM/Sgi: Add initial support for RD-N1-Edge-Dual platform
Date: Thu, 13 Feb 2020 17:23:08 +0000	[thread overview]
Message-ID: <20200213172308.GP23627@bivouac.eciton.net> (raw)
In-Reply-To: <1581514167-1340-6-git-send-email-vijayenthiran.subramaniam@arm.com>

On Wed, Feb 12, 2020 at 18:59:27 +0530, Vijayenthiran Subramaniam wrote:
> For RD-N1-Edge platforms, use multi-chip-mode information from the
> SGI platform descriptor HOB to pick the correct ACPI table to be
> installed.
> 
> Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>

Reviewed-by: Leif Lindholm <leif@nuviainc.com>

> ---
>  Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 1 +
>  Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c   | 5 +++++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf
> index a95c0d1dddd6..741dcc75ed6a 100644
> --- a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf
> +++ b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf
> @@ -32,6 +32,7 @@ [Guids]
>    gArmSgiPlatformIdDescriptorGuid
>    gSgi575AcpiTablesFileGuid
>    gRdN1EdgeAcpiTablesFileGuid
> +  gRdN1EdgeX2AcpiTablesFileGuid
>    gRdE1EdgeAcpiTablesFileGuid
>  
>  [FeaturePcd]
> diff --git a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
> index a2250a37bb57..3ef775187ac6 100644
> --- a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
> +++ b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
> @@ -38,6 +38,11 @@ STATIC SGI_PLATFORM_ACPI_TABLE_GUID_LOOKUP AcpiTableGuidLookup[] = {
>        &gRdN1EdgeAcpiTablesFileGuid),
>    ACPI_GUID_LOOKUP (
>        RD_N1E1_EDGE_PART_NUM,
> +      RD_N1_EDGE_CONF_ID,
> +      MULTI_CHIP_MODE_ENABLED,
> +      &gRdN1EdgeX2AcpiTablesFileGuid),
> +  ACPI_GUID_LOOKUP (
> +      RD_N1E1_EDGE_PART_NUM,
>        RD_E1_EDGE_CONF_ID,
>        MULTI_CHIP_MODE_DISABLED,
>        &gRdE1EdgeAcpiTablesFileGuid),
> -- 
> 2.7.4
> 

  reply	other threads:[~2020-02-13 17:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-12 13:29 [edk2-platforms] [PATCH v2 0/5] Platform/ARM/SgiPkg: Add support for RD-N1-Edge-Dual platform Vijayenthiran Subramaniam
2020-02-12 13:29 ` [edk2-platforms] [PATCH v2 1/5] Platform/ARM/SgiPkg: Disable use of deprecated APIs Vijayenthiran Subramaniam
2020-02-13 16:56   ` Leif Lindholm
2020-02-12 13:29 ` [edk2-platforms] [PATCH v2 2/5] Platform/ARM/SgiPkg: Use lookup table to install ACPI table Vijayenthiran Subramaniam
2020-02-13 17:14   ` Leif Lindholm
2020-02-12 13:29 ` [edk2-platforms] [PATCH v2 3/5] Platform/ARM/SgiPkg: Add MultiChipMode to Platform Descriptor Vijayenthiran Subramaniam
2020-02-13 17:16   ` Leif Lindholm
2020-02-12 13:29 ` [edk2-platforms] [PATCH v2 4/5] Platform/ARM/Sgi: Add ACPI tables for dual-chip RD-N1-Edge platform Vijayenthiran Subramaniam
2020-02-13 17:22   ` Leif Lindholm
2020-02-12 13:29 ` [edk2-platforms] [PATCH v2 5/5] Platform/ARM/Sgi: Add initial support for RD-N1-Edge-Dual platform Vijayenthiran Subramaniam
2020-02-13 17:23   ` Leif Lindholm [this message]
2020-02-13 17:31 ` [edk2-platforms] [PATCH v2 0/5] Platform/ARM/SgiPkg: Add " Leif Lindholm
2020-02-14 13:52   ` [edk2-devel] " Vijayenthiran Subramaniam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200213172308.GP23627@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox